Re-word tab context menu's "Configure" item/dialog title for clarity

- Make it confirm to the Label HIG (must start with a verb)
- Remove the redundant word "Current", which is implied
- Add the word "Rename" for clarity
- Rename the name of the resulting dialog for clarity

BUG: 426344
FIXED-IN: 20.12
wilder
Nate Graham 6 years ago
parent d368745ec4
commit c8bd9a816b
  1. 2
      src/RenameTabDialog.cpp
  2. 2
      src/session/SessionController.cpp
  3. 2
      src/widgets/ViewContainer.cpp

@ -35,7 +35,7 @@ RenameTabDialog::RenameTabDialog(QWidget *parent) :
QDialog(parent),
_ui(nullptr)
{
setWindowTitle(i18n("Current Tab Settings"));
setWindowTitle(i18n("Tab Properties"));
auto buttonBox = new QDialogButtonBox(QDialogButtonBox::Ok|QDialogButtonBox::Cancel);
auto mainWidget = new QWidget(this);
auto mainLayout = new QVBoxLayout;

@ -742,7 +742,7 @@ void SessionController::setupExtraActions()
// Rename Session
QAction* action = collection->addAction(QStringLiteral("rename-session"), this, &SessionController::renameSession);
action->setText(i18n("&Current Tab Settings..."));
action->setText(i18n("&Configure or Rename Tab..."));
action->setIcon(QIcon::fromTheme(QStringLiteral("edit-rename")));
collection->setDefaultShortcut(action, Konsole::ACCEL + Qt::ALT + Qt::Key_S);

@ -119,7 +119,7 @@ TabbedViewContainer::TabbedViewContainer(ViewManager *connectedViewManager, QWid
auto editAction = _contextPopupMenu->addAction(
QIcon::fromTheme(QStringLiteral("edit-rename")),
i18nc("@action:inmenu", "&Current Tab Settings..."), this,
i18nc("@action:inmenu", "&Configure or Rename Tab..."), this,
[this]{ renameTab(_contextMenuTabIndex); }
);
editAction->setObjectName(QStringLiteral("edit-rename"));

Loading…
Cancel
Save