getProcessInfo() returned _foregroundProcessInfo without checking the
return value of updateForegroundProcessInfo() indicating whether
_foregroundProcessInfo was non-existent or invalid.
I think this might be the solution to a bunch of recent crash bugs,
but not closing them as I can't test.
Also skipping RB because it is a simple patch and RB is down from here.
CCBUG: 372401
CCBUG: 372620
CCBUG: 372619
CCBUG: 372593
cursorRight() does not resize the _screenLines vector, leading to an
assert in QVector when trying to look up the _cuX which is bigger than
the amount of characters in the current line.
BUG: 372530
The previous set of blueish colors offered fairly bad contrast with the
charcoal grey background when using the "black" contrast value. To give
a more uniform experience the default "black" color is now charcoal grey
with it's intense variant shifted into a light grey to complement the
intense background, which is charcoal grey shifted into a more intense dark
This should offer overall better contrast, in particular in htop.
BUG: 371068
REVIEW: 129368
CHANGELOG: Breeze color scheme uses better contrasting color for "black" color value
Adds a setting for forcing the use of multiple instances instead of
running all instances in the same process. This way all terminals don't
go down when one instance crashes.
REVIEW: 129345
Use the new std::random APIs in c++11 for generating random numbers,
which is much safer and doesn't abuse qsrand().
This also means we don't need to copy in the QUuid::createUuid() code
anymore, which generated a warning in ubsan.
REVIEW: 129342
Recent code changed how %u is handled (only when %u is required, poll
/proc filesystem). This correct an issue when %u is added/removed from
the Rename Tab dialog.
The key sequence 'Ctrl+Shift+S' is ambiguous. Use 'Configure Shortcuts'
from the 'Settings' menu to solve the ambiguity. This shortcut was used
repeated times.
Now its changed to CTRL+SHIFT+X. For closing active tab in the konsole
of the split screen, it uses CTRL+SHIFT+X
Thanks to Aniketh Girish anikethgireesh gmail com
REVIEW: 129305
BUG: 354954
QAccessible::updateAccessibility() expects a pointer, but doesn't take
ownership of the argument and expects us to delete it after we've called
it. So just allocate the object on the stack like other users of this
API do.
Found by ASAN.
If a new Konsole instance is launched via DBus (e. g. single process
mode), it re-used the QCommandLineParser each time, so each new instance
would inherit all parsed options.
Most noticeably is if you have konsole running, press Shift+F4 in
Dolphin to launch a Konsole instance in the current folder (which leads
Konsole to use a temporary profile), and then try to open a new konsole
instance outside of that, it would open in the folder from Dolphin.
REVIEW: 129217
Update the tab title to current program running.
Martin, this "if" was committed in
79ca76a946. For now, I removed the "if"
CCBUG: 368785
(cherry picked from commit 3747ecfde0)
These 2 were hard coded - this allow them to be set in the profile.
There is currently no UI for these; add these to profile:
[General]
TerminalMargin=1
TerminalCenter=false
Thanks to Josef Kufner jk frozen doe net for patch
It appears the center flag doesn't work and perhaps hasn't for a long
time.
BUG: 346450