The intention of using --nofork with Konsole is to start Konsole in
foreground and wait for it to finish, so the only logical behavior is
using new process instead of reusing existing process.
CCBUG: 288200
The old way of calling isatty() is problmatic, because the checked
file descriptor might be redirected by users. For example, 'konsole <
/dev/null > /dev/null 2> /dev/null' will make that method fail.
The better way is trying to open /dev/tty to see whether we have
controlling terminal.
Thanks to Askar Safin <safinaskar@mail.ru> for pointing this out.
Disabing scrollback does not influence scroll bar in current code,
although it seems logical to automatically hide scroll bar after
scrollback is disabled.
I'm not sure whether that can be called as improvement. That global
shortcut has always been configurable through systemsettings. Now the
global shortcut is also configurable thourgh shoutcuts dialog, but it
is only available in the background window when it is shown.
I wonder how many users know and really use the --background-mode
option. It feels to me more like a clever trick than a mature feature.
- remove entries which are simply duplicates of the one in the 'fallback' profile
- remove outdated entries
Shell.profile will only contain 'Name' and 'Comment' entries from now on
REVIEW: 103668
The current default shortcut is Ctrl+Shift+X, which might be accidentally
pressed when users intend to press Ctrl+Shift+C for copying or Ctrl+Shift+V for
pasting. Scrollback is important asset, but it is impossible to recover
once gone. So change the default shortcut to decrease the chance of
accidents.
FEATURE: 282593
FIXED-IN: 4.9
REVIEW: 103660
This reverts commit 7ead97bfb2.
It is not going to be worth the trouble to build this small, non-
changing file on every OS.
I'll fix it so it can be build if the LineFont.src is changed.
Use the code provided by Thomas Lübking in
https://git.reviewboard.kde.org/r/103357/ to change the font dialog's
sample text. Since the text entry is large I added a lot of text
that some fonts may appears too similiar in the terminal.