Commit 60b0c9d breaks bidi rendering, essentialy making all spaces
hard L2R characters, instead of neutral.
The deleted mostly does not do anything - it groups a
sequence of space which would be grouped anyway.
The problem is the break at the end, which exits the outer loop so
stops grouping after any sequence of space.
It "works" by having more groups, thus the rendering is closer to
rendering each character in its place, mitigating somewhat the issue
caused by non-fixed fonts (fallback to a font with different width).
To support focusing a session from a notification in Wayland, we need to
use the XdgActivation protocol. This is done by passing to
KWindowSystem an XDG activation token that we get from the notification.
Adds a "Show session" button to notifications, which, when clicked, will
focus the originating session.
Original patch by Kasper Laudrup at bug 305162, then updated by Martin
T. H. Sandsmark.
Now updated and extended to silence/activity/process termination
notifications, adding support for focusing a TerminalDisplay inside a
hierarchy of ViewSplitters inside a TabbedViewContainer, and using
KWindowSystem::forceActiveWindow() instead of ::activateWindow().
BUG: 305162
BUG: 344208
Before 3d6c839b, sessions were snapshotted every 2 seconds, and also
half a second after the associated view received focus or a key press.
This second timer could theoretically be postponed indefinitely.
Commit 3d6c839b tries to save energy by not taking a snapshot every 2
seconds, and instead has a timer that fires half a second after any
event received by the application.
This commit goes back to the old behavior, but still without the 2
second timer, and also sets the half second timer after receiving the
Emulation::outputChanged signal, which is sent at a maximum 40ms after
the emulation receives data. It also copies the idea from commit
3d6c839b of not restarting the timer if it's already started, since
otherwise, continuous output could postpone the timer indefinitely.
- Selecting Copy (or pressing ctrl-shift-c) when there is no selection
selects current output if current mode is output, current input if
current mode is input and input is non-empty, and last output if current
input is empty.
- Ctrl + mouse triple click selects the pointed input/output/prompt.
- There is also a fix that was missed in previous patch for keeping
track of current semantic mode through scrolls.
Bugs reported here:
https://invent.kde.org/utilities/konsole/-/merge_requests/691#note_480025
- Properly ignore OSC parameters for now. (later we'll support some).
- Handle Input end for when command gets shorter.
- Always draw separating line in foreground color
- Don't group characters of different REPL type.
- Don't reset double width/height attributes of erased lines.
When showing URL hints, show also visual hints for semantic shell:
- A thin line above every line where a prompt starts.
- Prompts become less intense.
- User input becomes more intense.
- Add `OSC 133 ; *` escape sequences (where * stands for one of
A,B,C,D,L,P. For the shell to report text mode
(one of prompt/input/output).
- Store the mode of each character written to the screen.
- Replace isRealCharacter field in Character with flags.
- Store line length in _lineProperties array.
Walk over LocalTabTitle just once looking for percent signs, and doing
the appropriate substitution based on the next character.
This not only is slightly more performant, but also avoids trouble if
one of the substitutions happens to contain a percent sign.
Mostly fallout from not paying attention to it when resolving the
conflict with 5888a377.
Reporting parse errors (and many other things) can be enabled with:
QT_LOGGING_RULES="org.kde.konsole.debug=true"
- Only recognize SGR 38/48 semicolon forms if there are no subparams for
that parameter.
- Add some tests for SGR 38 parsing.
- Add comment about ignoring 0x7F in Ground state.
- Fix off-by-one when collect()ing intermediates.
Plus another one triggered by code quality warnings:
- Don't test for impossible conditions.
- Add a new hasSubParams field to params.
- Ignore CSIs with subparams other than SGR.
- Only recognize SGR 38/48 semicolon forms if there are no subparams in
the SGR.
- Add comment on subparam 0 being empty.
Add support in the new parser for chars >= 0xa0 in OSC, DCS, APC, PM,
SOS. This allows OSC 8 to support non ASCII URLs:
printf '\e]8;;https://example.com/naïve\e\\Link to naïve\e]8;;\e\\\n'
Note that while «Williams, Paul Flo. “A parser for DEC’s ANSI-compatible
video terminals.” VT100.net. https://vt100.net/emu/dec_ansi_parser»
treats codes A0-FF identically to codes 20-7F, this does not seem to be
typical in terminal emulators: only xterm seems to follow this
peculiarity of DEC VTs, which allows:
printf '\e[4\xedtest\e[0m\n'
to be treated as if it had an "m" instead of "\xed", and shows an
underscored "test" in VT102, VT240, and xterm +u8 (use "\xc3\xad" for
xterm -u8).
This adds supports for sub-parameters in control sequences. For now, it
supports the colon-separated variants of SGR 38 and SGR 48 for RGB and
indexed colours:
CSI 38 : 2 : <id> : <red> : <green> : <blue> [ : ... ] m
CSI 38 : 2 : <red> : <green> : <blue> m
CSI 38 : 5 : <index8> m
and likewise for SGR 48. <id> is ignored (it's supposed to be a colour
space id, to support different kinds of RGB).
Substitute konsole's old vt102 parser with one based on the diagram at
vt100.net.
Williams, Paul Flo. “A parser for DEC’s ANSI-compatible video
terminals.” VT100.net. https://vt100.net/emu/dec_ansi_parser
The "return" in "#define QCOMPARE(actual, expected)" does not allow us
to delete the new-ed objects. This raises clangd "konsole/src/autotests/TerminalTest.cpp:28:5:
Potential leak of memory pointed to by 'display' [clang-analyzer-cplusplus.NewDeleteLeaks]"
and PVS-Studio V773.
The "return" in "#define QCOMPARE(actual, expected)" does not allow us
to delete the new-ed objects.
This raises clangd
"Potential leak of memory pointed to by 'X' [clang-analyzer-cplusplus.NewDeleteLeaks]"
and PVS-Studio V773.
The split-view actions define a shortcut using `Konsole::ACCEL`, which
since !609 expands to `Qt::CTRL | Qt::SHIFT` on systems that aren't
macOS. This breaks the shortcut for the split-view actions however as
`Qt::Key_ParenLeft` and `Qt::Key_ParenRight` do not work with the
`Qt::SHIFT` modifier.
Using `Qt::CTRL` (Cmd on macOS, Ctrl everywhere else) as the base
accelerator for these two actions makes splitting views work again as
expected.
ecm_set_disabled_deprecation_versions() in versions < 5.96 was brokwn
when it comes to SHOW_DEPRECATIONS, warnings for newer deprecations
were disabled if the flag was set or not.
Starting with ECM 5.96 the macro now enables warnings by default,
so the flag is no longer needed.
GIT_SILENT
Nate Graham
Harald Sitter
l10n daemon script
Matan Ziv-Av
Luis Javier Merino Morán
Liu Bodong
Marius P
Georg Gadinger
Ahmad Samir
Heiko Becker
Friedrich W. H. Kossebau
Laurent Montel