commit b84c0f49 replaced the previous hack, clearly failing to notice
that in-thread qobject conections are direct by default. we need to make
the competing connection queued instead.
this remains a hack; a proper solution would be avoiding the instant
resize by skipping the initialization to 80x25, but i'm not going to
touch any of that mess.
BUG: 412598
This escape matches what e. g. vim and screen recognizes, and seems to
be fairly standard.
NB: By default ctrl+tab is mapped to changing tabs in Konsole, so you
need to reset that in the shortcut settings for this to have any impact.
This isn't needed as QMenu takes care of deleting removed actions (that
are children of it). Confirmed with QObject::connect() call on
QObject::destroyed signal. And skimming the upstream QMenu::actionEvent()
code.
_preventClose has to be set to false right at the end, so as to prevent
crashes if the user selects the "close session" action from the context
menu in a Konsole KPart (e.g. the terminal panel in Dolphin).
Check menu object isn't null before deleting actions from it.
BUG: 429538
There are now actions in dolphin and konqueror
directly added. This has advantage that they can respect the
global settings in regards to the default terminal. Also in the case
of dolphin the shortcut is shown, which is makes a bit more self documenting.
This option is deprecated on Qt since 5.12. Konsole cmake minimal Qt
version set is 5.12, giving warning messages while making.
A regular expression is automatically optimized the first time it is
used now.
Since there is no universal way to tell a text editor about line/column
on the cli (each editor seems to have its own scheme), there is a profile
option to let the user specify the command to use to open local text files,
e.g.:
/usr/bin/kate PATH:LINE:COLUMN
/usr/bin/gedit +LINE:COLUMN PATH
then we replace PATH LINE and COLUMN to create the cmd to pass on
to KIO::ApplicationLauncherJob.
Current use cases, opening a file at:
- specific line, from the ouput of "grep -n": "path/to/some/file:123"
- specific line/column, from the output of gcc compiler errors:
"/path/to/file:123:123"
- specific line, from the ouput of ctest, when there is a compilation error:
"[/path/to/some/file(123)]"
Change the regex to also match absolute file paths, this is useful in
general and also compilation errors usually use absolute file paths.
Tweak the regex matching text between two single/double quotes so that it
doesn't match newline characters.
Refactor the UI file to use QBoxLayouts, this way each related set of
options can be put together, which makes future changes slightly easier.
Gustavo Carneiro
Oswald Buddenhagen
Edwin Pujols
Laurent Montel
Christoph Feck
Kurt Hindenburg
Ahmad Samir
Friedrich W. H. Kossebau
Carlos Alves
Martin T. H. Sandsmark
Alexander Lohnau
Carson Black
Piotr Henryk Dabrowski
Tomaz Canabrava