Summary:
Defaults taken from kde coding style.
This file enables a minimum style guide to be enforced across editors,
like line endings, character encoding, tabs vs spaces, indent size
and some more.
https://editorconfig.org/
Reviewers: hindenburg, tcanabrava, gszymaszek
Reviewed By: hindenburg, tcanabrava, gszymaszek
Subscribers: Omar, gszymaszek, dhaumann, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D15383
Summary:
This is uneeded and we can create and use the mimetype
directly inside of the DetachableTabBar as nothing else
needs to know about it.
Test Plan: Compile and runs. Unused code.
Reviewers: hindenburg, sandsmark, ngraham
Reviewed By: hindenburg
Subscribers: konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D15378
Summary:
Whenever I change the font size doing so is usually temporary and I usually go back to the default font size in after a short time. Currently I do so by changing to a different profile and discarding the change, which resets the font size to the default. I feel like there should be a shortcut for resetting the size.
I could not find an appropriate icon, so I left it without icon.
The default shortcut ctrl+r seemed reasonable and easy to type, 'r' reset.
Test Plan: Manual.
Reviewers: hindenburg, tcanabrava, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: muhlenpfordt, ach, kvermette, rizzitello, lbergdoll, hindenburg, fabianr, dhaumann, kde-doc-english, z3ntu, ngraham, konsole-devel
Tags: #konsole, #documentation
Differential Revision: https://phabricator.kde.org/D15380
Summary:
If you moved the tabs to splits in a way that you have a different
number of tabs in each split, and started closing it, the count()
of the tabs would be different and we would hit an assert.
The fix is simple: don't separate the logic between tabEmpty and
tabDestroyed, if the tab is empty it will be destroyed but we can
treat everything in the tabEmpty signal, this way we will never hit
a dangling pointer.
Because of that it was possible that a splitView had a invalid
activeWidget for a microsecond, when it's deleting itself, so
instead of asserting if we have no active view, I choose to return
a empty list of properties.
Reviewers: hindenburg, ngraham, sandsmark
Reviewed By: hindenburg
Subscribers: konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D15379
Summary:
This continues the patch series of the rewrite
of the Tab handling code to a more modern approach
using QTabWidget.
This fixes the attach and reattach bug on multiple
konsole windows and reworks the drag & drop code
to a more simplified version of it.
Reviewers: hindenburg, ngraham, sandsmark
Reviewed By: hindenburg
Subscribers: lbergdoll, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D15377
Summary:
There's no need to create a layout for the central widget
that will hold only one widget.
Test Plan: compiled, triggered a few actions that could cause a layout change.
Reviewers: #konsole, hindenburg, ngraham
Reviewed By: ngraham
Subscribers: ngraham, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D14198
Summary:
Fixes a regression from ac59cc7e00.
LibreOffice Writer, for example, will hang during startup when
QT_NO_GLIB is set. It uses GLib and has KDE integration.
Test Plan:
In a shell, set QT_NO_GLIB to a string, or an empty string, or
unset it. Run konsole from that shell, check that QT_NO_GLIB in
the new shell inside konsole has the same value as in the
launching shell.
Reviewers: hindenburg, #konsole, sandsmark, dfaure
Reviewed By: dfaure
Subscribers: dfaure, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D14558
Summary: Allowing the test to pass without a running X server.
Test Plan: Test still passes
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D14539
(cherry picked from commit ee5e70e7d9882aa245f79594df169f8db84b63d8)
Summary:
Show tabbar and hide tabbar got lost in the transition to a modern
QTabBar, this re-enables them. These options will override the
current settings if you use --hide-tabbar or --show-tabbar.
Changing these options in the settings will change these settings.
To use the current preferences just start konsole without --hide-tabbar
or --show-tabbar
Reviewers: #konsole, sandsmark, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: ngraham, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D14294
Builds have been failing since this new QTabBar code was committed
since QOperatingSystemVersion::currentType() is Qt5.9+. We currently
only require Qt5.6 and I don't want to change that just for this.
ENABLE_DETACHING is only set to false for MacOSX/Darwin.
Summary:
This patch fixes the lack of profile in the new tab button,
and it makes the close button to behave the same way
as the old implementation.
Reviewers: #konsole, sandsmark, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D14295
Summary:
Lambdas don't auto disconnect. Removing that code also
removed one of Nathan's nitpicks on my code.
Reviewers: #konsole, hindenburg, sandsmark
Reviewed By: #konsole, hindenburg
Subscribers: konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D14298
Summary:
this is a WIP, I don't plan to merge this yet, there are many thigns to solve.
Drop the handmade TabWidget used inside of konsole in favor of Qt's QTabWidget
This drops tons of code we manually did, but it also drops a bit of functionality.
Everything besides detach should be working.
I'm now trying to finish detach.
a nice overvie:
15 files changed, 314 insertions(+), 1609 deletions(-)
Missing features:
- Detach
and lots of testing.
Reviewers: hindenburg, #konsole, ngraham
Reviewed By: ngraham
Subscribers: ngraham, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D13882
(Detaching is still broken atm)
Move out of the CMake the check for crashes in detaching
It's better to check that in the code - I was quite lost
for a while on why there was a DETACHING_ENABLED definition
as it did not made sense
Lukas Bergdoll
Yuri Chornoivan
Tomaz Canabrava
Anthony Fieroni
l10n daemon script
Laurent Montel
Sune Vuorela
Kurt Hindenburg
Andreas Hartmetz
Heiko Becker