Move code responsible for 'forgetting' a view outside of code responding to the
TerminalDisplay deletion.
This avoids a loop like this:
~MainWindow
=> ~QStackedWidget
=> ~TerminalDisplay
=> QObject::destroyed
=> ViewContainer::viewDestroyed
=> ViewContainer::removeViewWidget
- internal cleanup
- try to remove TerminalDisplay from QStackedWidget which is being deleted and
crash
Instead the code now does:
~MainWindow
=> ~QStackedWidget
=> ~TerminalDisplay
=> QObject::destroyed
=> ViewContainer::viewDestroyed
=> ViewContainer::forgetView (does the internal clean up)
And if one tries to explicitly remove a view, sequence is:
ViewContainer::removeView
=> ViewContainer::forgetView
=> ViewContainer::removeViewWidget
The patch also removes ViewManager::focusActiveView() because it causes a crash
when closing a TerminalDisplay as it tries to put the focus on the deleted
TerminalDisplay. I initially called it through a queued connection, but realized
it is actually not needed for focus to be passed to the correct view, so just
removed it.
BUG: 331724
REVIEW: 118839
Fix box lines - using kmag is a great help
Thanks to Egmont Koblinger egmont gmail com for report and patch
BUG: 335339
FIXED-IN: 4.13.2
(cherry picked from commit 58d79e3624)
Coverity mentions the 128 array issue w/ possible Out-of-bounds writes.
The qFatal would catch it. However, adding comments on why [128] is
used and re-arranging the 'if' clarifies it.
(cherry picked from commit 14e9eb8b58)
This needs looked at later.
The below causes a noticable delay when opening the dialog - I'm not
entirely sure this is the best way to handle this.
Issue is QLineEdit->SetCompleter() won't work w/ KDE's KUrlCompletion
New feature in 2.13 allows columns/rows in profiles; however, the
rows would be incorrect depending on if tabbar was visible. Ideally,
this should not be needed but I would guess this won't get fixed
correctly until frameworks timeframe.
This calculation can still be wrong if ShowNavigationAsNeeded and
perhaps other times depending on height of tabbar.
FIXED: 2.13
(cherry picked from commit 73e1db3e3b)
This adds a push button to the Configure Konsole -> General Settings
Ideally, having a separate page listings all the possible entries
would be better.
BUG: 331474
FIXED-IN: 2.13
(cherry picked from commit 5a386ad591)
Thanks to tsdgeos for helping debug this. I'm using zsh on all my
local machines so '/tmp' would auto-cd there. This is why it was
failing on build.kde.org
(cherry picked from commit a961ddc216)
Lukáš Tinkl
Montel Laurent
Kurt Hindenburg
Aurélien Gâteau
Eike Hein
Alex Richardson
Alex Merry
Kevin Ottens
David Faure
Burkhard Lück
Yuri Chornoivan
Luigi Toscano