This reverts commit f96deb39aa.
This was anti-optimization.
QStringLiteral is a QString created at build time. Initialization of
QString with it has no overhead.
QLatin1String is 8 bit C string wrapper which needs run-time conversion
to 16 bit encoding used in QString.
Fixes warning:
"kf5.kxmlgui: 0xXXXXXXXXXXXX deleted without having been removed from
the factory first. This will leak standalone popupmenus and could lead
to crashes."
When pasting urls of local files, remove the the scheme part, "file://",
and paste the urls as a space-separated list of local file paths, which
are quoted as needed.
Commands such as cp, mv, ls... etc, don't understand/parse the file://
bit of local urls, therefore it's more useful to strip the scheme for local
files.
CCBUG: 408813
Konsole was not opening a new tab when --new-tab is specified.
Even if we change the konsole settings to open in a unique PID,
we could open a new window sometimes.
See https://phabricator.kde.org/D25084 for KDBusAddons patch
discussion.
The old code was filtering things like characters from Private Use Area
and surrogates (used to represent code points > 0xFFFF, e.g. emojis). In
worst case, when pasted, they appear as <?>. The filter is now limited
to all control characters except TAB, CR, LF.
Summary:
This fixes the bug with tabs not indicating terminal activity.
When the tab is split and has multiple child terminals, activity in any
of the child terminals will be indicated.
BUG: 406828
FIXED-IN: 19.12.0
Test Plan:
Open two tabs, run `sleep 2` in the first one and switch to the other.
After the sleep ends, the tab activity is indicated just as it was before
the bug was introduced.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, anthonyfieroni, nucleo, konsole-devel, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D25151
printf '\033]2;aaa\033bbb' prints bbb
printf '\033]2;aaa\033\\bbb' prints bbb
printf '\033]2;aaa\033' prints nothing;
title is changed when next character is received.
printf '\033]2;aaa\033\\' prints nothing
printf '\033]2;aaa\007bbb' prints bbb
printf '\033]2;aaa\007\\bbb' prints \bbb
printf '\033]2;a\ra\na\033bbb' prints bbb
printf '\033]2;a\ra\na\033\\bbb' prints bbb
printf '\033]2;a\ra\na\007bbb' prints bbb
In each case the title is set to aaa
BUG: 231405
FIXED-IN: 19.12.0
Summary:
This should fix the terminal not gaining focus when using konsolepart.
BUG: 411181
FIXED-IN: 19.12.0
Test Plan:
- The terminal panels in Dolphin and Kate now always gain focus
properly, not just the first time you open them
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D25001
QWidget::close() shows question popup when CloseAllTabs is set to false
(default). The comment in the function suggested it was handled, but
it wasn't - the popup blocks DBus method call, so QSignalSpy::wait()
was not reached until the popup was closed manually.
l10n daemon script
Tomaz Canabrava
Mariusz Glebocki
Björn Feber
Jonathan Riddell
Laurent Montel
Christoph Feck
Kurt Hindenburg
Nicolas Fella
Ahmad Samir
Albert Astals Cid
Yuri Chornoivan
Petr Velan
Alex Miranda