Follow-up to 2dcd584255.
konsole is not in the same repository as libkonq anymore, so we need
to check if it is installed before using it, and it is also better to
use the whole library path when linking instead of hardcoding "konq".
CCMAIL: konsole-devel@kde.org
It is possible that users invoke konsole from terminal in the form of
'konsole &> /dev/null' to get rid of warning messages. Checking stdout
won't give expected result.
On the other hand, 'konsole < ....' is almost never used. So checking
stdin should be more reliable.
That function just reports whether new konsole process should be use. It
has no side effect and does not create new process, while the old name
may give the impression that it does.
It is generally a good idea to pass more keyboard actions into terminal
process, instead of intercepting them. Anyway, Uses can still define the
alternative shortcuts themselfes if they want.
BUG: 188941
FIXED-IN: 4.8
The old code updates the argument list when it is asked to refresh
process info, but it calls ProcessInfo::addArgument() without ever
clearing existing arguements first. This means the argument list will
grow longer and longer for ever. For a long-running shell session in
which user has executed thousands of commands, that will waste quite
amount of memory, not to metion the logic error itself.
The reaseon why this bug keeps hidden is that the %c and %C formatter
have never been revealed to users, which are not implemented yet.
When user switches focus (even using mouse) between tabs/windows
of konsole, ibus will trigger inputMethodEvent(). Most of the time
commitString() will be empty. Do not emit keyPressedSignal in such case,
otherwise konsole will scroll active view to bottom. See bug #236733.
The side effect is when inputmethod is activated, the active view
will not scroll to bottom on keystroke until user has committed
some string.
BUG: 236733
REVIEW: 102238
FIXED-IN : 4.8
This is a temporary revert. Previous commit did not take split view
into account and puts new tab in weird order when used in split view.
A improved version will be commit shortly after.
This reverts commit 676df0c26e.
The original method is splitted into applyProfileToView() which applies
view-specific settings to TerminalDisplay, and applyProfileToContainer()
which applies container-specific settings to ViewContainer.
This comes as preparation for fixing bug #207213.
REVIEW: 102321
Raphael Kubo da Costa
Jekyll Wu
Kurt Hindenburg
Montel Laurent
Aaron Seigo