031a9d54e2
Do not insert one extra emtpy line every 500 lines in the saved history.
...
The code for adding that extra empty line was introduced in commit
d3d909 (4 years ago). The reason and intention is not clear, so removing
those code might cause regression. Anyway, this commit is simple and can
be reverted easily, if unfortunately needed.
BUG: 225501
FIXED-IN: 4.8
REVIEW: 102652
15 years ago
d11fd4ea18
Add "Select All" action for selecting the whole history of this session.
...
FEATURE: 199990
FIXED-IN: 4.8
REVIEW: 102372
15 years ago
bfc17f4a94
No need for a variable to store a value, use it and forget it
...
To compare the result of a method only with a calculated value, there
is no need for a local variable. Let the compiler create itself the
value in the best place, stack or registry.
15 years ago
7407585c15
Initialize the read write balance counter
...
Initialize the _readwritebalance member to 0.
If this is not initialized, at random konsole runs, the history could
not be mmaped even if lseek is slower.
Also, remove a valgrind warning about jump using unitialized value.
15 years ago
cd2e674d21
Rename to avoid confusion.
...
It is confusing to name a ViewManager* pointer as 'view', especially
when it is used in 'view->createView()'.
15 years ago
ea457d8973
add missing space
15 years ago
18df5b4731
Small fix in the text
...
desktop effect -> desktop effects
is -> were
Spacing fix
15 years ago
49c107966b
Konsole should never save a profile with empty name into disk.
...
BUG: 281268
FIXED-IN: 4.8
REVIEW:102559
15 years ago
050819bb8d
When searching, apply change in case sensitive option immediately.
...
Patch by Francesco Cecconi <francesco.cecconi@kdemail.net>
BUG: 273614
15 years ago
35fae00159
When using -e <command> don't save to profile for new tabs.
...
Currently using -e <command> will cause all new tabs/windows to run
<command>. This patch fixes that such that new tabs/windows will start
the default profile.
Patch by Gu Rui <chaos.proton@gmail.com> with minor edit by self.
FIXED-IN: 4.8
REVIEW: 102602
CCBUG: 192212
15 years ago
e14b2099cc
Each filename inserted in d&d operation should be followd by a space.
...
FEATURE: 280838
FIXED-IN:4.8
15 years ago
771b4b2228
ANSI escape code "\e[1;93m" should generate intensive color.
...
The current behavior is bold(1) will toggle the intensity of an
intensive color(93), so the result is a normal color. This is
counter-intuitive. Xterm, rxvt, and all vte-base emulators generate
intensive color in this case.
BUG: 274603
FIXED-IN: 4.8
REVIEW: 102554
15 years ago
1923acd434
SVN_SILENT made messages (.desktop file)
15 years ago
f45836543c
SVN_SILENT made messages (.desktop file)
15 years ago
1772401647
Rename for consistency
...
In '-p 2222', -p is the option and 2222 is its argument.
noOptionsArguments ==> noArgumentOptions
singleOptionArguments ==> singleArgumentOptions
argChar ==> optionChar
15 years ago
c4ab3d6c6d
Make the parsing of ssh command more robust, or more complicated.
...
It now can deal with both '-p 2222' and '-p2222'.
This is a follow up of 869cdb1090
15 years ago
7d2f153ae6
Warn users they may need to restart konsole to see transparent background.
...
If desktop effect is enabled only after konsole has started, then
users need to restart konsole to see transparent background.
FEATURE: 169305
FIXED-IN: 4.8
15 years ago
3ca9d38075
SVN_SILENT made messages (.desktop file)
15 years ago
d7ed89c473
SVN_SILENT made messages (.desktop file)
15 years ago
1233aa0f97
Initialize _maxLineCount in the initilization list directly.
15 years ago
02a821887f
Remove unused methods maxNbLines() .
15 years ago
57a83187ce
Remove unused member variable m_logFileName.
15 years ago
87b98de419
Rename member variable m_histType to _historyType.
15 years ago
5e8a76c302
Delete long obsolete method HistroyScroll:getCell().
...
This method is not used anymore, so it should be safe to remove.
15 years ago
45daca783f
Declare HistoryFile::isMapped() as const method.
15 years ago
4455c2a59f
Rename member variable fileMap and readWriteBalance.
15 years ago
31ba6915b2
Rename member variable length to _length.
15 years ago
02165475ea
Rename member variable tmpFile to _tmpFile.
15 years ago
1f1b54e733
Rename member varibale ion to _fd.
...
It store an file descriptor, so _fd is more natural than ion.
15 years ago
75017ee579
It is not a good idea to #include <KDebug> in SessionController.h
...
Except increasing building time, it also hides the problem of some
missing #include in other source files.
15 years ago
57412dce63
comment out unused variable rowIndex.
15 years ago
e83bc55fa4
Do not call selectedRow() at the end of tableSelectionChanged().
...
That line will cause infinite growing stack when Ctrl+A is pressed and
finally make konsole crash .
BUG: 281375
FIXED-IN: 4.8
15 years ago
96c0f3a44e
No need to call tableSelectionChanged() explicitly in populateTable().
...
The previous call to selectedRow() should have alreaddy triggered
tableSelectionChanged() automatically.
15 years ago
ce496b5933
Make the code a bit more readable.
15 years ago
b7e4742eb6
add KDialog:: prefix before ButtonCode.
15 years ago
ca7beebb0e
KTabWidget is not used by konsole yet.
15 years ago
50a38c2fcb
small changes with #include .
15 years ago
e828def700
Reorgnazie some #include.
15 years ago
de61d40c63
Include Qt headers in the form of "#include <Module/Class>"
15 years ago
f78b734ef2
Remove unused #include .
15 years ago
0f89f1bba9
Check the validity of context menu after it gets closed.
...
The patch is from Francesco Cecconi <francesco.cecconi@gmail.com>,
with slight modification by committer.
BUG: 233377
FIXED-in : 4.8
15 years ago
d90862d060
replace Q_SLOTS with slots.
15 years ago
4b02eba623
Change slotClose() as private slot, since it is not used externally.
15 years ago
6d08d04b56
adjust indentation to 4 spaces.
15 years ago
1b5d836219
Add KDialog:: prefix for ButtonCode.
...
Ok, Cancel and Default are so generic that they look ambiguous without
the KDialog:: prefix.
15 years ago
d99422730f
Less one-liner definitions for class methods .
...
This really hurts readability, especially when they appear successively.
15 years ago
976077e37f
Do not select the fixed size mode by default.
...
Current code always sets the line count spinbox as focused and selected,
even when the current setting of history size is no history or unlimited
history. This is counter-intuitive and may confuse users.
15 years ago
0012355e2e
slight adjustment of code layout. No functionality changes.
15 years ago
6f3b4bbab6
Use "{ }" consistently in "if... else..." statements.
15 years ago
0016b3c0c2
remove the TODO about unicode charcter composition, which is done.
15 years ago
Jekyll Wu
Jaime Torres
Yuri Chornoivan
Albert Astals Cid
Kurt Hindenburg
Script Kiddy