The only real changes in kmcomposewin.* are
- QListView *mAtmListBox;
+ KMail::AttachmentListView* mAtmListView;
in kmcomposewin.h and
- mAtmListBox = new QListView(mMainWidget, "mAtmListBox");
+ mAtmListView = new AttachmentListView( this, mMainWidget,
+ "attachment list view" );
in kmcomposewin.cpp. All other changes in kmcomposewin.cpp are just mAtmListBox -> mAtmListView
svn path=/trunk/kdepim/; revision=223858
- Extract bPopFilter clause into internal processPop() method.
- Extract ad-hoc filter application from ::process(). This was really silly. Instead
of writing a short overloaded ::process( KMMessage*, KMFilter* ) method,
it was crammed into the normal ::process() that iterates over the whole
list of filters. This led to two bugs:
1. The filter was only executed if it was in the filter manager's list.
This makes it impossible to write code like
KMFilter * filter = new FooFilter();
// ...
kernel->filterMgr()->process( msg, filter );
delete filter;
2. The filter was only executed if it was marked as
"execute on manual filtering" by the user. But if the user checks the
box that adds the filter to the Message->Apply Filter submenu, she
probably wants to _not_ have the filter executed on manual filtering.
(Example: report as spam action (<exec command> "spamassassin -r"))
svn path=/trunk/kdepim/; revision=223784
a large copy operation for example continues in the background when you change
out of the source folder. Seems to work well here, but left commented, I might
be missing something. Feel free to revert if this is stupid. :)
svn path=/trunk/kdepim/; revision=223735
that have been moved/copied local->imap.
o Only checkValidity of a folder if we are not already waiting on the result
of such a check. (Carsten, is this ok? They stack and put pressure on the
server when you copy a lot of messages to an imap folder, which results in
a lot of getFolder() while the transfers are going on.)
o Add folder names to debug statements.
svn path=/trunk/kdepim/; revision=223733
To Sven: follow the style of the file to which you are committing.
To all others: removing printf's and switching some asserts.
To myself: you got a nice butt.
svn path=/trunk/kdepim/; revision=223697
o Fix display of t/p parts when using the smart attachment strategy:
They're now also shown inline if they have no filename associated with them.
Together, they fix display of multi-part text messages, such as Simon Josefsson's nice example mail, which has a tradition of having it's display being broken in KMail ;-)
svn path=/trunk/kdepim/; revision=223610
Some notes:
- kmail now links libkcal
- the scheduler attributes are not ported, see comments
As a result msTNEFtovPart is broken now, Cornelius, Bo: Please have a look.
CCMAIL: schumacher@kde.org, bo@sonofthor.dk
Bernd das sprechende Brot says: "Was ein Spass..."
svn path=/trunk/kdepim/; revision=223605
Ouch. fcntl interprets the third parameter as struct flock * if it's called with the F_SETLK command. So much for 'function overloading' with plain C.
svn path=/trunk/kdepim/; revision=223508
- Added new InfoExtension as an interface for basic interaction between part
and framework
- Changed the layout of the sidebar and added a new header widget to the
mainwindow which makes use of the new extension. Currently it shows in which
folder you are in KMail.
A few things still need some polishing, I'll do that as soon as possible.
Thanks danimo for the help with signals/slots :)
svn path=/trunk/kdepim/; revision=223376
KMail sources day". It had to be done anyway. This commit adds KMail's
folder handling documentation. I'm half finished with it but I have to go
out for a sec so I'll commit the rest in a bit.
svn path=/trunk/kdepim/; revision=222851
Imagine you want to comment on the first part of the following quoted paragraph.
> KMail rules! But I miss the following feature. ...
Now all you have to do is the following: Place the cursor after the !, press four times Return, go up two lines, type your comment. KMail will automagically add the quote indicator before "But I ...".
This patch is based on a patch by Laurent Montel <lmontel@mandrakesoft.com>. But his patch didn't work as I expected/desired it to work (see my reply to his message) so I had to change it quite a bit.
svn path=/trunk/kdepim/; revision=222671
o KMMessage::headerAddrField() now returns a AddressList instead of a string list.
o New method KMMessage::extractAddrSpecs() returns a AddrSpecList (used in sender)
=> Now KMail copes with empty groups while sending (undisclosed recipients: ;)
Using new kio_smtp features:
o Dump prepareString() for KDE_IS_VERSION( 3, 1, 90 )
o Instruct slave to perform dotstuffing and lf->crlf conversion
o Adapt to KMMessage::headerAddrField() signature change
o Use mMessageLength * 1.05 for size declaration instead of KMMessage::msgLength()
svn path=/trunk/kdepim/; revision=222632
o same for slotExpandAll
o Deselect all but the parent before opening to avoid flicker, when opening
via mouse also.
svn path=/trunk/kdepim/; revision=222260
This fix also fixes a few other bugs, e. g. the From, Organization and Reply-To headers and the Sendmail folder were all overwritten by the values defined in the identity. Now the message that is sent again will have exactly the same headers as the original message (except for the Message-Id of course).
svn path=/trunk/kdepim/; revision=222228