GIT_SILENT: fix pedantic

wilder
Laurent Montel 5 years ago
parent 0430ebec84
commit d2865b35d7
  1. 2
      agents/archivemailagent/addarchivemaildialog.cpp
  2. 6
      agents/archivemailagent/archivemailkernel.cpp
  3. 2
      agents/followupreminderagent/followupreminderinfowidget.cpp
  4. 4
      agents/followupreminderagent/followupremindernoanswerdialog.cpp
  5. 2
      agents/mailfilteragent/dummykernel.cpp
  6. 2
      agents/mailfilteragent/filterlogdialog.cpp
  7. 2
      agents/mailfilteragent/mailfilteragent.cpp
  8. 2
      agents/unifiedmailboxagent/mailkernel.cpp
  9. 2
      agents/unifiedmailboxagent/unifiedmailboxagent.cpp
  10. 2
      src/collectionpage/collectionmailinglistpage.cpp
  11. 2
      src/configuredialog/configagentdelegate.cpp
  12. 6
      src/configuredialog/configureappearancepage.cpp
  13. 4
      src/editor/attachment/attachmentview.cpp
  14. 4
      src/editor/kmcomposereditorng.cpp
  15. 4
      src/editor/kmcomposerwin.cpp
  16. 2
      src/job/createnewcontactjob.cpp
  17. 8
      src/kmkernel.cpp
  18. 2
      src/kmmainwidget.cpp
  19. 2
      src/kontactplugin/kmail/summarywidget.cpp
  20. 2
      src/kontactplugin/summary/summaryview_part.cpp
  21. 2
      src/messageactions.cpp
  22. 4
      src/unityservicemanager.cpp

@ -167,7 +167,7 @@ void AddArchiveMailDialog::slotUpdateOkButton()
void AddArchiveMailDialog::slotFolderChanged(const Akonadi::Collection &collection) void AddArchiveMailDialog::slotFolderChanged(const Akonadi::Collection &collection)
{ {
Q_UNUSED(collection); Q_UNUSED(collection)
slotUpdateOkButton(); slotUpdateOkButton();
} }

@ -112,11 +112,11 @@ Akonadi::Collection::Id ArchiveMailKernel::lastSelectedFolder()
void ArchiveMailKernel::setLastSelectedFolder(Akonadi::Collection::Id col) void ArchiveMailKernel::setLastSelectedFolder(Akonadi::Collection::Id col)
{ {
Q_UNUSED(col); Q_UNUSED(col)
} }
void ArchiveMailKernel::expunge(Akonadi::Collection::Id col, bool sync) void ArchiveMailKernel::expunge(Akonadi::Collection::Id col, bool sync)
{ {
Q_UNUSED(col); Q_UNUSED(col)
Q_UNUSED(sync); Q_UNUSED(sync)
} }

@ -172,7 +172,7 @@ bool FollowUpReminderInfoWidget::save() const
void FollowUpReminderInfoWidget::slotCustomContextMenuRequested(const QPoint &pos) void FollowUpReminderInfoWidget::slotCustomContextMenuRequested(const QPoint &pos)
{ {
Q_UNUSED(pos); Q_UNUSED(pos)
const QList<QTreeWidgetItem *> listItems = mTreeWidget->selectedItems(); const QList<QTreeWidgetItem *> listItems = mTreeWidget->selectedItems();
const int nbElementSelected = listItems.count(); const int nbElementSelected = listItems.count();
if (nbElementSelected > 0) { if (nbElementSelected > 0) {

@ -88,8 +88,8 @@ void FollowUpReminderNoAnswerDialog::wakeUp()
void FollowUpReminderNoAnswerDialog::slotDBusNotificationsPropertiesChanged( void FollowUpReminderNoAnswerDialog::slotDBusNotificationsPropertiesChanged(
const QString &interface, const QVariantMap &changedProperties, const QStringList &invalidatedProperties) const QString &interface, const QVariantMap &changedProperties, const QStringList &invalidatedProperties)
{ {
Q_UNUSED(interface); // always "org.freedesktop.Notifications" Q_UNUSED(interface) // always "org.freedesktop.Notifications"
Q_UNUSED(invalidatedProperties); Q_UNUSED(invalidatedProperties)
const auto it = changedProperties.find(QStringLiteral("Inhibited")); const auto it = changedProperties.find(QStringLiteral("Inhibited"));
if (it != changedProperties.end()) { if (it != changedProperties.end()) {
const bool inhibited = it.value().toBool(); const bool inhibited = it.value().toBool();

@ -101,7 +101,7 @@ Akonadi::Collection::Id DummyKernel::lastSelectedFolder()
void DummyKernel::setLastSelectedFolder(Akonadi::Collection::Id col) void DummyKernel::setLastSelectedFolder(Akonadi::Collection::Id col)
{ {
Q_UNUSED(col); Q_UNUSED(col)
} }
void DummyKernel::expunge(Akonadi::Collection::Id id, bool sync) void DummyKernel::expunge(Akonadi::Collection::Id id, bool sync)

@ -358,7 +358,7 @@ FilterLogTextEdit::FilterLogTextEdit(QWidget *parent)
void FilterLogTextEdit::addExtraMenuEntry(QMenu *menu, QPoint pos) void FilterLogTextEdit::addExtraMenuEntry(QMenu *menu, QPoint pos)
{ {
Q_UNUSED(pos); Q_UNUSED(pos)
if (!document()->isEmpty()) { if (!document()->isEmpty()) {
auto *sep = new QAction(menu); auto *sep = new QAction(menu);
sep->setSeparator(true); sep->setSeparator(true);

@ -129,7 +129,7 @@ MailFilterAgent::~MailFilterAgent()
void MailFilterAgent::configure(WId windowId) void MailFilterAgent::configure(WId windowId)
{ {
Q_UNUSED(windowId); Q_UNUSED(windowId)
} }
void MailFilterAgent::initializeCollections() void MailFilterAgent::initializeCollections()

@ -118,7 +118,7 @@ Akonadi::Collection::Id MailKernel::lastSelectedFolder()
void MailKernel::setLastSelectedFolder(Akonadi::Collection::Id col) void MailKernel::setLastSelectedFolder(Akonadi::Collection::Id col)
{ {
Q_UNUSED(col); Q_UNUSED(col)
} }
void MailKernel::expunge(Akonadi::Collection::Id id, bool sync) void MailKernel::expunge(Akonadi::Collection::Id id, bool sync)

@ -218,7 +218,7 @@ void UnifiedMailboxAgent::retrieveItems(const Akonadi::Collection &c)
bool UnifiedMailboxAgent::retrieveItem(const Akonadi::Item &item, const QSet<QByteArray> &parts) bool UnifiedMailboxAgent::retrieveItem(const Akonadi::Item &item, const QSet<QByteArray> &parts)
{ {
// This method should never be called by Akonadi // This method should never be called by Akonadi
Q_UNUSED(parts); Q_UNUSED(parts)
qCWarning(UNIFIEDMAILBOXAGENT_LOG) << "retrieveItem() for item" << item.id() << "called but we can't own any items! This is a bug in Akonadi"; qCWarning(UNIFIEDMAILBOXAGENT_LOG) << "retrieveItem() for item" << item.id() << "called but we can't own any items! This is a bug in Akonadi";
return false; return false;
} }

@ -148,7 +148,7 @@ void CollectionMailingListPage::load(const Akonadi::Collection &col)
void CollectionMailingListPage::save(Akonadi::Collection &col) void CollectionMailingListPage::save(Akonadi::Collection &col)
{ {
Q_UNUSED(col); Q_UNUSED(col)
if (changed) { if (changed) {
if (mFolder) { if (mFolder) {
// settings for mailingList // settings for mailingList

@ -163,7 +163,7 @@ QWidget *ConfigAgentDelegate::createEditor(QWidget *, const QStyleOptionViewItem
bool ConfigAgentDelegate::editorEvent(QEvent *event, QAbstractItemModel *model, const QStyleOptionViewItem &option, const QModelIndex &index) bool ConfigAgentDelegate::editorEvent(QEvent *event, QAbstractItemModel *model, const QStyleOptionViewItem &option, const QModelIndex &index)
{ {
Q_UNUSED(model); Q_UNUSED(model)
if (!index.isValid()) { if (!index.isValid()) {
return false; return false;
} }

@ -1060,9 +1060,9 @@ void AppearancePage::MessageTagTab::slotEmitChangeCheck()
void AppearancePage::MessageTagTab::slotRowsMoved(const QModelIndex &, int sourcestart, int sourceEnd, const QModelIndex &, int destinationRow) void AppearancePage::MessageTagTab::slotRowsMoved(const QModelIndex &, int sourcestart, int sourceEnd, const QModelIndex &, int destinationRow)
{ {
Q_UNUSED(sourceEnd); Q_UNUSED(sourceEnd)
Q_UNUSED(sourcestart); Q_UNUSED(sourcestart)
Q_UNUSED(destinationRow); Q_UNUSED(destinationRow)
updateButtons(); updateButtons();
slotEmitChangeCheck(); slotEmitChangeCheck();
} }

@ -99,7 +99,7 @@ void AttachmentView::saveHeaderState()
void AttachmentView::contextMenuEvent(QContextMenuEvent *event) void AttachmentView::contextMenuEvent(QContextMenuEvent *event)
{ {
Q_UNUSED(event); Q_UNUSED(event)
Q_EMIT contextMenuRequested(); Q_EMIT contextMenuRequested();
} }
@ -178,7 +178,7 @@ void AttachmentView::selectNewAttachment()
void AttachmentView::startDrag(Qt::DropActions supportedActions) void AttachmentView::startDrag(Qt::DropActions supportedActions)
{ {
Q_UNUSED(supportedActions); Q_UNUSED(supportedActions)
const QModelIndexList selection = selectionModel()->selectedRows(); const QModelIndexList selection = selectionModel()->selectedRows();
if (!selection.isEmpty()) { if (!selection.isEmpty()) {

@ -42,7 +42,7 @@ KMComposerEditorNg::~KMComposerEditorNg()
void KMComposerEditorNg::addExtraMenuEntry(QMenu *menu, QPoint pos) void KMComposerEditorNg::addExtraMenuEntry(QMenu *menu, QPoint pos)
{ {
Q_UNUSED(pos); Q_UNUSED(pos)
const QList<QAction *> lstAct = mComposerWin->pluginToolsActionListForPopupMenu(); const QList<QAction *> lstAct = mComposerWin->pluginToolsActionListForPopupMenu();
for (QAction *a : lstAct) { for (QAction *a : lstAct) {
menu->addSeparator(); menu->addSeparator();
@ -111,7 +111,7 @@ QString KMComposerEditorNg::smartQuote(const QString &msg)
void KMComposerEditorNg::showSpellConfigDialog(const QString &configFileName) void KMComposerEditorNg::showSpellConfigDialog(const QString &configFileName)
{ {
Q_UNUSED(configFileName); Q_UNUSED(configFileName)
QPointer<SpellCheckerConfigDialog> dialog = new SpellCheckerConfigDialog(this); QPointer<SpellCheckerConfigDialog> dialog = new SpellCheckerConfigDialog(this);
if (!spellCheckingLanguage().isEmpty()) { if (!spellCheckingLanguage().isEmpty()) {
dialog->setLanguage(spellCheckingLanguage()); dialog->setLanguage(spellCheckingLanguage());

@ -643,7 +643,7 @@ void KMComposerWin::addAttachment(const QVector<KMail::Composer::AttachmentInfo>
void KMComposerWin::addAttachment(const QString &name, KMime::Headers::contentEncoding cte, const QString &charset, const QByteArray &data, const QByteArray &mimeType) void KMComposerWin::addAttachment(const QString &name, KMime::Headers::contentEncoding cte, const QString &charset, const QByteArray &data, const QByteArray &mimeType)
{ {
Q_UNUSED(cte); Q_UNUSED(cte)
mComposerBase->addAttachment(name, name, charset, data, mimeType); mComposerBase->addAttachment(name, name, charset, data, mimeType);
} }
@ -3742,7 +3742,7 @@ void KMComposerWin::slotIdentityDeleted(uint uoid)
void KMComposerWin::slotTransportRemoved(int id, const QString &name) void KMComposerWin::slotTransportRemoved(int id, const QString &name)
{ {
Q_UNUSED(name); Q_UNUSED(name)
if (mComposerBase->transportComboBox()->currentTransportId() == id) { if (mComposerBase->transportComboBox()->currentTransportId() == id) {
mIncorrectIdentityFolderWarning->mailTransportIsInvalid(); mIncorrectIdentityFolderWarning->mailTransportIsInvalid();
} }

@ -117,7 +117,7 @@ void CreateNewContactJob::createContact()
void CreateNewContactJob::contactStored(const Akonadi::Item &item) void CreateNewContactJob::contactStored(const Akonadi::Item &item)
{ {
Q_UNUSED(item); Q_UNUSED(item)
PimCommon::BroadcastStatus::instance()->setStatusMsg(i18n("Contact created successfully")); PimCommon::BroadcastStatus::instance()->setStatusMsg(i18n("Contact created successfully"));
} }

@ -1500,7 +1500,7 @@ MessageComposer::MessageSender *KMKernel::msgSender()
void KMKernel::transportRemoved(int id, const QString &name) void KMKernel::transportRemoved(int id, const QString &name)
{ {
Q_UNUSED(id); Q_UNUSED(id)
// reset all identities using the deleted transport // reset all identities using the deleted transport
QStringList changedIdents; QStringList changedIdents;
@ -1531,7 +1531,7 @@ void KMKernel::transportRemoved(int id, const QString &name)
void KMKernel::transportRenamed(int id, const QString &oldName, const QString &newName) void KMKernel::transportRenamed(int id, const QString &oldName, const QString &newName)
{ {
Q_UNUSED(id); Q_UNUSED(id)
QStringList changedIdents; QStringList changedIdents;
KIdentityManagement::IdentityManager *im = identityManager(); KIdentityManagement::IdentityManager *im = identityManager();
@ -1959,8 +1959,8 @@ void KMKernel::setShuttingDown(bool flag)
void KMKernel::expunge(Akonadi::Collection::Id col, bool sync) void KMKernel::expunge(Akonadi::Collection::Id col, bool sync)
{ {
Q_UNUSED(col); Q_UNUSED(col)
Q_UNUSED(sync); Q_UNUSED(sync)
} }
#ifdef WITH_KUSERFEEDBACK #ifdef WITH_KUSERFEEDBACK

@ -1239,7 +1239,7 @@ void KMMainWidget::slotCollectionChanged(const Akonadi::Collection &collection,
void KMMainWidget::slotItemAdded(const Akonadi::Item &msg, const Akonadi::Collection &col) void KMMainWidget::slotItemAdded(const Akonadi::Item &msg, const Akonadi::Collection &col)
{ {
Q_UNUSED(msg); Q_UNUSED(msg)
if (col.isValid()) { if (col.isValid()) {
if (col == CommonKernel->outboxCollectionFolder()) { if (col == CommonKernel->outboxCollectionFolder()) {
startUpdateMessageActionsTimer(); startUpdateMessageActionsTimer();

@ -92,7 +92,7 @@ void SummaryWidget::slotCollectionChanged()
void SummaryWidget::updateSummary(bool force) void SummaryWidget::updateSummary(bool force)
{ {
Q_UNUSED(force); Q_UNUSED(force)
QTimer::singleShot(0, this, &SummaryWidget::slotUpdateFolderList); QTimer::singleShot(0, this, &SummaryWidget::slotUpdateFolderList);
} }

@ -43,7 +43,7 @@ SummaryViewPart::SummaryViewPart(KontactInterface::Core *core, const KAboutData
: KParts::Part(parent) : KParts::Part(parent)
, mCore(core) , mCore(core)
{ {
Q_UNUSED(aboutData); Q_UNUSED(aboutData)
setComponentName(QStringLiteral("kontactsummary"), i18n("Kontact Summary")); setComponentName(QStringLiteral("kontactsummary"), i18n("Kontact Summary"));
loadLayout(); loadLayout();

@ -316,7 +316,7 @@ void MessageActions::slotItemRemoved(const Akonadi::Item &item)
void MessageActions::slotItemModified(const Akonadi::Item &item, const QSet< QByteArray > &partIdentifiers) void MessageActions::slotItemModified(const Akonadi::Item &item, const QSet< QByteArray > &partIdentifiers)
{ {
Q_UNUSED(partIdentifiers); Q_UNUSED(partIdentifiers)
if (item == mCurrentItem) { if (item == mCurrentItem) {
mCurrentItem = item; mCurrentItem = item;
const int numberOfVisibleItems = mVisibleItems.count(); const int numberOfVisibleItems = mVisibleItems.count();

@ -158,13 +158,13 @@ void UnityServiceManager::initUnity()
mUnityServiceWatcher->setWatchMode(QDBusServiceWatcher::WatchForUnregistration | QDBusServiceWatcher::WatchForRegistration); mUnityServiceWatcher->setWatchMode(QDBusServiceWatcher::WatchForUnregistration | QDBusServiceWatcher::WatchForRegistration);
mUnityServiceWatcher->addWatchedService(QStringLiteral("com.canonical.Unity")); mUnityServiceWatcher->addWatchedService(QStringLiteral("com.canonical.Unity"));
connect(mUnityServiceWatcher, &QDBusServiceWatcher::serviceRegistered, this, [this](const QString &service) { connect(mUnityServiceWatcher, &QDBusServiceWatcher::serviceRegistered, this, [this](const QString &service) {
Q_UNUSED(service); Q_UNUSED(service)
mUnityServiceAvailable = true; mUnityServiceAvailable = true;
updateCount(); updateCount();
}); });
connect(mUnityServiceWatcher, &QDBusServiceWatcher::serviceUnregistered, this, [this](const QString &service) { connect(mUnityServiceWatcher, &QDBusServiceWatcher::serviceUnregistered, this, [this](const QString &service) {
Q_UNUSED(service); Q_UNUSED(service)
mUnityServiceAvailable = false; mUnityServiceAvailable = false;
}); });

Loading…
Cancel
Save