Replace typedef by using / std::unique_ptr => std::make_unique

ktnef/src/qwmf.cpp

@@ -1085,7 +1085,7 @@ QColor QWinMetaFile::color(short *parm)
     green = (colorRef >> 8) & 255;
     blue = (colorRef >> 16) & 255;
 
-    return QColor(red, green, blue);
+    return {red, green, blue};
 }
 
 //-----------------------------------------------------------------------------

ktnef/src/wmfstruct.h

@@ -6,10 +6,10 @@
 #ifndef wmfstruct_h
 #define wmfstruct_h
 
-typedef short WORD;
+using WORD = short;
-typedef int DWORD;
+using DWORD = int;
-typedef qint32 LONG;
+using LONG = qint32;
-typedef void *_HANDLE;
+using _HANDLE = void *;
 
 typedef struct _RECT {
     WORD left;

src/configuredialog/configagentdelegate.cpp

@@ -153,7 +153,7 @@ QSize ConfigAgentDelegate::sizeHint(const QStyleOptionViewItem &option, const QM
     const int iconHeight = KIconLoader::global()->currentSize(KIconLoader::Desktop) + (s_delegatePaddingSize * 2);  //icon height + padding either side
     const int textHeight = option.fontMetrics.height() + qMax(option.fontMetrics.height(), 16) + (s_delegatePaddingSize * 2);   //height of text + icon/text + padding either side
 
-    return QSize(1, qMax(iconHeight, textHeight));    //any width,the view will give us the whole thing in list mode
+    return {1, qMax(iconHeight, textHeight)};    //any width,the view will give us the whole thing in list mode
 }
 
 QWidget *ConfigAgentDelegate::createEditor(QWidget *, const QStyleOptionViewItem &, const QModelIndex &) const

src/configuredialog/configureaccountpage.cpp

@@ -358,7 +358,7 @@ void AccountsPage::ReceivingTab::slotEditNotifications()
 {
     const auto instance = Akonadi::AgentManager::self()->instance(QStringLiteral("akonadi_newmailnotifier_agent"));
     if (instance.isValid()) {
-        std::unique_ptr<Akonadi::AgentConfigurationDialog>(new Akonadi::AgentConfigurationDialog(instance, this))->exec();
+        std::make_unique<Akonadi::AgentConfigurationDialog>(instance, this)->exec();
     } else {
         KMessageBox::error(this, i18n("New Mail Notifier Agent not registered. Please contact your administrator."));
     }

src/configuredialog/configureaccountpage.h

@@ -109,8 +109,8 @@ public:
     QString helpAnchor() const override;
 
     // hrmpf. moc doesn't like nested classes with slots/signals...:
-    typedef AccountsPageSendingTab SendingTab;
+    using SendingTab = AccountsPageSendingTab;
-    typedef AccountsPageReceivingTab ReceivingTab;
+    using ReceivingTab = AccountsPageReceivingTab;
 
 Q_SIGNALS:
     void accountListChanged(const QStringList &);

src/configuredialog/configureappearancepage.h

@@ -35,7 +35,7 @@ class ThemeComboBox;
 
 namespace MailCommon {
 class Tag;
-typedef QSharedPointer<Tag> TagPtr;
+using TagPtr = QSharedPointer<Tag>;
 }
 
 namespace MailCommon {
@@ -264,12 +264,12 @@ public:
     QString helpAnchor() const override;
 
     // hrmpf. moc doesn't like nested classes with slots/signals...:
-    typedef AppearancePageFontsTab FontsTab;
+    using FontsTab = AppearancePageFontsTab;
-    typedef AppearancePageColorsTab ColorsTab;
+    using ColorsTab = AppearancePageColorsTab;
-    typedef AppearancePageLayoutTab LayoutTab;
+    using LayoutTab = AppearancePageLayoutTab;
-    typedef AppearancePageHeadersTab HeadersTab;
+    using HeadersTab = AppearancePageHeadersTab;
-    typedef AppearancePageGeneralTab ReaderTab;
+    using ReaderTab = AppearancePageGeneralTab;
-    typedef AppearancePageMessageTagTab MessageTagTab;
+    using MessageTagTab = AppearancePageMessageTagTab;
 };
 
 #endif // CONFIGUREAPPEARANCEPAGE_H

src/configuredialog/configurecomposerpage.h

@@ -235,15 +235,15 @@ public:
     QString helpAnchor() const override;
 
     // hrmpf. moc doesn't like nested classes with slots/signals...:
-    typedef ComposerPageGeneralTab GeneralTab;
+    using GeneralTab = ComposerPageGeneralTab;
-    typedef ComposerPageTemplatesTab TemplatesTab;
+    using TemplatesTab = ComposerPageTemplatesTab;
-    typedef ComposerPageCustomTemplatesTab CustomTemplatesTab;
+    using CustomTemplatesTab = ComposerPageCustomTemplatesTab;
-    typedef ComposerPageSubjectTab SubjectTab;
+    using SubjectTab = ComposerPageSubjectTab;
-    typedef ComposerPageCharsetTab CharsetTab;
+    using CharsetTab = ComposerPageCharsetTab;
-    typedef ComposerPageHeadersTab HeadersTab;
+    using HeadersTab = ComposerPageHeadersTab;
-    typedef ComposerPageAttachmentsTab AttachmentsTab;
+    using AttachmentsTab = ComposerPageAttachmentsTab;
-    typedef ComposerPageAutoCorrectionTab AutoCorrectionTab;
+    using AutoCorrectionTab = ComposerPageAutoCorrectionTab;
-    typedef ComposerPageAutoImageResizeTab AutoImageResizeTab;
+    using AutoImageResizeTab = ComposerPageAutoImageResizeTab;
 };
 
 #endif // CONFIGURECOMPOSERPAGE_H

src/configuredialog/configuredialog.cpp

@@ -44,7 +44,7 @@ QSize ConfigureDialog::sizeHint() const
 {
     const int width = KMailSettings::self()->configureDialogWidth();
     const int height = KMailSettings::self()->configureDialogHeight();
-    return QSize(width, height);
+    return {width, height};
 }
 
 void ConfigureDialog::hideEvent(QHideEvent *ev)

src/configuredialog/configuremiscpage.h

@@ -59,8 +59,8 @@ public:
     explicit MiscPage(QWidget *parent = nullptr);
     QString helpAnchor() const override;
 
-    typedef MiscPageFolderTab FolderTab;
+    using FolderTab = MiscPageFolderTab;
-    typedef MiscPageInviteTab InviteTab;
+    using InviteTab = MiscPageInviteTab;
 };
 
 class MiscPagePrintingTab : public ConfigModuleTab

src/configuredialog/configuresecuritypage.h

@@ -138,11 +138,11 @@ public:
 
     QString helpAnchor() const override;
 
-    typedef SecurityPageGeneralTab ReadingTab;
+    using ReadingTab = SecurityPageGeneralTab;
-    typedef SecurityPageMDNTab MDNTab;
+    using MDNTab = SecurityPageMDNTab;
-    typedef SecurityPageComposerCryptoTab ComposerCryptoTab;
+    using ComposerCryptoTab = SecurityPageComposerCryptoTab;
-    typedef SecurityPageWarningTab WarningTab;
+    using WarningTab = SecurityPageWarningTab;
-    typedef SecurityPageSMimeTab SMimeTab;
+    using SMimeTab = SecurityPageSMimeTab;
 };
 
 #endif // CONFIGURESECURITYPAGE_H

src/editor/composer.h

@@ -42,7 +42,7 @@ public:
         HDR_DICTIONARY = 0x800,
         HDR_ALL = 0xfff
     };
-    typedef QFlags<VisibleHeaderFlag> VisibleHeaderFlags;
+    using VisibleHeaderFlags = QFlags<VisibleHeaderFlag>;
 
     struct AttachmentInfo {
         QString comment;

src/kmmainwidget.h

@@ -88,7 +88,7 @@ class KMAIL_EXPORT KMMainWidget : public QWidget
     Q_OBJECT
 
 public:
-    typedef QList<KMMainWidget *> PtrList;
+    using PtrList = QList<KMMainWidget *>;
 
     KMMainWidget(QWidget *parent, KXMLGUIClient *aGUIClient, KActionCollection *actionCollection, const KSharedConfig::Ptr &config = KMKernel::self()->config());
     ~KMMainWidget() override;