Fix clazy warning "Don't call QList::first() on temporary"

src/editor/kmcomposerwin.cpp

@@ -2401,8 +2401,8 @@ void KMComposerWin::printComposeResult(KJob *job, bool preview)
     if (composer->error() == MessageComposer::Composer::NoError) {
         Q_ASSERT(composer->resultMessages().size() == 1);
         Akonadi::Item printItem;
-        printItem.setPayload<KMime::Message::Ptr>(composer->resultMessages().first());
+        printItem.setPayload<KMime::Message::Ptr>(composer->resultMessages().constFirst());
-        Akonadi::MessageFlags::copyMessageFlags(*(composer->resultMessages().first()), printItem);
+        Akonadi::MessageFlags::copyMessageFlags(*(composer->resultMessages().constFirst()), printItem);
         const bool isHtml = mComposerBase->editor()->textMode() == MessageComposer::RichTextComposerNg::Rich;
         const MessageViewer::Viewer::DisplayFormatMessage format = isHtml ? MessageViewer::Viewer::Html : MessageViewer::Viewer::Text;
         KMPrintCommand *command = new KMPrintCommand(this, printItem, nullptr,

src/folderarchive/folderarchivemanager.cpp

@@ -120,7 +120,7 @@ void FolderArchiveManager::slotFetchCollection(KJob *job)
     }
 
     const Akonadi::Item::List itemIds = {Akonadi::Item(jobCol->property("itemId").toLongLong())};
-    setArchiveItems(itemIds, jobCol->collections().first().resource());
+    setArchiveItems(itemIds, jobCol->collections().constFirst().resource());
 }
 
 void FolderArchiveManager::setArchiveItems(const Akonadi::Item::List &items, const QString &instanceName)

src/job/createfollowupreminderonexistingmessagejob.cpp

@@ -54,7 +54,7 @@ void CreateFollowupReminderOnExistingMessageJob::itemFetchJobDone(KJob *job)
 {
     Akonadi::ItemFetchJob *fetchJob = qobject_cast<Akonadi::ItemFetchJob *>(job);
     if (fetchJob->items().count() == 1) {
-        mMessageItem = fetchJob->items().first();
+        mMessageItem = fetchJob->items().constFirst();
     } else {
         qCDebug(KMAIL_LOG) << " CreateFollowupReminderOnExistingMessageJob Error during fetch: " << job->errorString();
         deleteLater();

src/kmkernel.cpp

@@ -1284,7 +1284,7 @@ KMainWindow *KMKernel::mainWin()
     // case we are running inside Kontact) because we anyway only need
     // it for modal message boxes and for KNotify events.
     if (!KMainWindow::memberList().isEmpty()) {
-        KMainWindow *kmWin = KMainWindow::memberList().first();
+        KMainWindow *kmWin = KMainWindow::memberList().constFirst();
         if (kmWin) {
             return kmWin;
         }

src/kmmainwidget.cpp

@@ -1526,7 +1526,7 @@ void KMMainWidget::slotClearCurrentFolder()
 void KMMainWidget::slotExpireAll()
 {
     if (KMailSettings::self()->warnBeforeExpire()) {
-        const int ret = KMessageBox::warningContinueCancel(KMainWindow::memberList().first(),
+        const int ret = KMessageBox::warningContinueCancel(KMainWindow::memberList().constFirst(),
                                                            i18n("Are you sure you want to expire all old messages?"),
                                                            i18n("Expire Old Messages?"), KGuiItem(i18n("Expire")));
         if (ret != KMessageBox::Continue) {

src/kmreaderwin.cpp

@@ -743,8 +743,8 @@ void KMReaderWin::slotPrintComposeResult(KJob *job)
     if (composer->error() == ::MessageComposer::Composer::NoError) {
         Q_ASSERT(composer->resultMessages().size() == 1);
         Akonadi::Item printItem;
-        printItem.setPayload<KMime::Message::Ptr>(composer->resultMessages().first());
+        printItem.setPayload<KMime::Message::Ptr>(composer->resultMessages().constFirst());
-        Akonadi::MessageFlags::copyMessageFlags(*(composer->resultMessages().first()), printItem);
+        Akonadi::MessageFlags::copyMessageFlags(*(composer->resultMessages().constFirst()), printItem);
         const bool useFixedFont = MessageViewer::MessageViewerSettings::self()->useFixedFont();
         const QString overrideEncoding = MessageCore::MessageCoreSettings::self()->overrideCharacterEncoding();
 

src/manageshowcollectionproperties.cpp

@@ -190,7 +190,7 @@ void ManageShowCollectionProperties::slotCollectionPropertiesFinished(KJob *job)
         return;
     }
 
-    const Akonadi::Collection collection = fetch->collections().first();
+    const Akonadi::Collection collection = fetch->collections().constFirst();
 
     QPointer<Akonadi::CollectionPropertiesDialog> dlg = new Akonadi::CollectionPropertiesDialog(collection, mPages, mMainWidget);
     dlg->setWindowTitle(i18nc("@title:window", "Properties of Folder %1", collection.name()));

src/messageactions.cpp

@@ -374,7 +374,7 @@ void MessageActions::slotUpdateActionsFetchDone(KJob *job)
     if (fetchJob->items().isEmpty()) {
         return;
     }
-    Akonadi::Item messageItem = fetchJob->items().first();
+    const Akonadi::Item messageItem = fetchJob->items().constFirst();
     if (messageItem == mCurrentItem) {
         mCurrentItem = messageItem;
         updateMailingListActions(messageItem);

src/search/checkindexingjob.cpp

@@ -71,7 +71,7 @@ void CheckIndexingJob::slotCollectionPropertiesFinished(KJob *job)
         return;
     }
 
-    mCollection = fetch->collections().first();
+    mCollection = fetch->collections().constFirst();
     const qlonglong result = mIndexedItems->indexedItems(mCollection.id());
     bool needToReindex = false;
     qCDebug(KMAIL_LOG) << "name :" << mCollection.name() << " mCollection.statistics().count() " << mCollection.statistics().count() << "stats.value(mCollection.id())" << result;