Summary:
Every time we open a configuration file, we are checking if this file is there.
Since it's a sysadmin setting I'd say it's fine to assume that it's not appearing
and disappearing.
Also we are not supporting the case of the file changing during runtime or so.
Reviewers: #frameworks, mpyne, dfaure
Reviewed By: mpyne, dfaure
Subscribers: dfaure, mpyne
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D8871
Summary: We will be using an external version of it in practice
Reviewers: #frameworks, davidedmundson
Reviewed By: davidedmundson
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D8457
Using initializer_lists for QList we reserve the right amount of memory in advance and also make for nicer code.
Also uses range-for where code was touched and a const container used.
Differential Revision: https://phabricator.kde.org/D7879
As per the Desktop Entry spec, we strip trailing whitespace from the key
when we split an entry into a key/value pair at the '='. Now we also
strip leading whitespace from the resulting value like we should.
CCBUG:310674
Differential Revision: https://phabricator.kde.org/D7169
Summary:
This is particularly useful for cross-compilation, where we only need the
kconfig_compiler on the host system.
Reviewers: #frameworks, apol, aacid
Reviewed By: aacid
Subscribers: aacid
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D6994
1) some of them can't run in parallel
2) kconfigskeletontest failed due to KSharedConfig being used under the
scene (for a year now), and there's probably some QPA or widget style
holding a ref (here, not in the CI). Indirectly, simply setting
QStandardPaths::setTestModeEnabled(true) fixes this since KSharedConfig
will then not share the instance with the non-test-mode-enabled instance.
Summary:
This is what other webbrowsers like Firefox and Chrome do,
and is certainly much more international than Ctrl+Comma/Ctrl+Dot which
is very qwerty centric.
Test Plan: Switching tabs in Konqueror
Reviewers: mdawson
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D6553
Using the new extra-cmake-modules module ECMAddQch (since 5.36.0)
this adds the option to automatically build and install a file
in QCH format with the docs about the public API, which then can be
used e.g. in Qt Assistant, Qt Creator or KDevelop.
Additionally the installed cmake config files will be extended
with a target KF5Config_QCH containing information about how to "link"
into the generated QCH file, which then can be used in the cmake build
system of other libraries building on this library, by
simply listing this target in "LINK_QCHS" of their ecm_add_qch() usage.
And a respective doxygen tag file with all the metadata about the
generated QCH file and used for the "linking" will be created and
installed.
Pass -DBUILD_QCH=ON to cmake to enable this.
Use the QProcess::start() variant with explicit (empty, in this case)
arguments, so the program string is not parsed as shell command, thus
preserving paths with spaces as such.
The "dir" and "path" variables were obviously swapped here by mistake.
This resulted in the relativePath always being empty, and made the
function return "~/.local/share/" (or "~/.config/") instead of the
correct path.
BUG: 345100
FIXED-IN: 5.34.0
Differential Revision: https://phabricator.kde.org/D5502
Summary:
When using a toolchain file one often would want to set a
CMAKE_FIND_ROOT_PATH to "re-root" lookups into a staging area to prevent
native host artifcats from being found. This in particular is usually the
case for lib/include/package finders as one would want the target
systems build artifacts rather than the hosts.
find_file() unfortunately draws its re-rooting rule from
CMAKE_FIND_ROOT_PATH_MODE_INCLUDE, which as mentioned would usually be
set not to look in the actual host paths to avoid picking up wrong includes
which would also prevent find_file to work here.
In the case of the coreaddonstooling it makes sense to look in the host
though. For one the lookup only runs when CROSS_COMPILING is set (which
usually is the case for toolchains), AND one explicitly has to specify a
HOST_TOOLING path. So in a way by specifying that one is already opting
out of whatever rooting rules one has set elsewhere as setting that var
is a clear indication that we have *specific* host tooling and we want
to use that rather than anything else.
As a result NO_CMAKE_FIND_ROOT_PATH is the way to go when looking for stuff
under a KF5_HOST_TOOLING conditional.
Reviewers: mdawson, apol
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D5218
Spotted because it leads to race conditions due to tzset
(surely a Qt bug, but anyway no point in finding out lastModified
for nothing).
While at it, remove the unused size field as well.
For some reason some people have kdeglobals entries like
Close=Ctrl+W; Ctrl+Esc; Ctrl+W; Ctrl+Esc;
having the same shortcut more than once in the shortcut declaration is clearly bogus so fix it
BUGS: 375555
REVIEW: 129987
Summary:
It can't possibly have been used anywhere, because it's not in the KConfig
API anywhere. The intended way to use this API was by providing a plugin
that would derive from KConfigBackend but the plugin loading code
in KConfigBackend::create has been disabled since before KF 5.0.
The reason I want to stop exporting this class is to be able to
optimize it (e.g. the QDateTime in it is completely unused but leads
to data races due to tzset)
Test Plan: Note, I'll rename it to _p.h if we agree, it would just have made this diff too big.
Reviewers: mdawson
Reviewed By: mdawson
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D4604
Montel Laurent
Aleix Pol
l10n daemon script
Kai Uwe Broulik
Elvis Angelaccio
David Faure
Michael Pyne
Dominik Haumann
Volker Krause
Friedrich W. H. Kossebau
Sebastian Holtermann
Pino Toscano
Wolfgang Bauer
Harald Sitter
Albert Astals Cid
Christoph Cullmann