Summary:
Removing the (typically empty) optional argument from the function
invocation avoids confusion and allows to remove the parameter.
See also D15558
Test Plan: make
Reviewers: #frameworks, apol
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D15848
Summary: They were not being split properly.
Test Plan: Tests pass, including the new one.
Reviewers: #frameworks, dfaure
Reviewed By: dfaure
Subscribers: dfaure, anthonyfieroni, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D14162
Summary:
it wasn't exactly clear what the inputs for a Color type may be. this is
now explained along with special type descriptions. it isn't perfectly
ideal here since it is a bit hard to find, but better be hard to find
than not documented at all.
from a quick glance at the code indeed anything goes that QColor can
construct from a QString. there is also custom regex code in the compiler
that allows construction from r,g,b,a via the appropriate ctor of qcolor.
Reviewers: broulik
Reviewed By: broulik
Subscribers: broulik, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D15576
Summary:
The concept of KStandardDirs resources no longer exists;
and anyway kiosk users disable things at the feature level, not at
the config file level.
Test Plan: Compiles without warnings
Reviewers: davidedmundson, arichardson, broulik
Reviewed By: broulik
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D14829
Summary:
Default shortcuts for zoom in ({key Ctrl +}) and out ({key Ctrl -})
already exists but not for going back to 100%.
The shortcut {key Ctrl 0} is widely used by different applications
for zoom to original size. This patch adds {key Ctrl 0} as system
default for `KStandardAction::ActualSize`.
FEATURE: 305702
FIXED-IN: 5.50
Test Plan:
Searched lxr for conflicts of `KStandardAction::ActualSize` and
usage of Ctrl+0 shortcut.
Checked the following applications with set system default shortcut:
* Gwenview
* KAlgebra
* KolourPaint
* KStars (FITS viewer)
* Cirkuit
Only Cirkuit uses Ctrl+0 for "Zoom To Fit" action. I'll create a
patch to solve this conflict.
Reviewers: dfaure, broulik, ngraham, rkflx
Reviewed By: dfaure, ngraham, rkflx
Subscribers: jriddell, rkflx, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D14201
Summary:
We expand the path of kdeglobals to
~/.qttest/kconfigtests/../kdeglobals
which works during the test, but this cleanup is run both on startup and
after removing ~/.qttest/kconfigtests at which point the expansion
fails.
Test Plan: Ran test, looked at qttest dir. It had cleaned up
Reviewers: broulik
Reviewed By: broulik
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D13032
Summary:
Since "Use override" (3985f2a0) kconfig_compiler.cpp
generates usrSave with override instead of Q_DECL_OVERRIDE. This causes
the KConfigCompiler_Test to fail [1], as the reference file of the test
was not updated.
[1]: https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/32/
Reviewers: #frameworks, mlaurent
Reviewed By: mlaurent
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D12892
Summary:
This way if another cmake project imports it when cross-compiling, it
can be executed.
Reviewers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D9652
Summary: FEATURE: Use Ctrl+Shift+, as the standard keyboard shortcut to invoke KDE programs' "Configure <Program>" menu items.
Test Plan:
This shortcut is not used by anything else. Searched on lxr, found one conflict in DigiKam, and the developers agreed to change it: https://bugs.kde.org/show_bug.cgi?id=386335
Will wait to land this until Digikam 5.8.0 is released to prevent any shortcut conflicts.
Tested in KDE Neon. Tried out Plasma, KWin, Dolphin, Kate, Konsole, Gwenview, Okular, Konversation, KTorrent, and Skanlite; all now have a consistent keyboard shortcut for their "Configure <Program>" menu items.
Reviewers: #frameworks, #vdg, broulik, rkflx
Reviewed By: rkflx
Subscribers: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D8296
Summary:
KDesktopFile::sortOrder() returns the value of SortOrder key
as a string whithout parsing it as a list.
But according to Desktop Entry Specification
https://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
it's type is "string(s)", i.e. the same type as the type of
Actions and MimeType keys, and thus it should be read the same way.
Reviewers: #frameworks, dfaure
Reviewed By: dfaure
Subscribers: dfaure, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D8689
Stefan Brüns
Aleix Pol
Friedrich W. H. Kossebau
Harald Sitter
Laurent Montel
l10n daemon script
David Faure
Peter Mühlenpfordt
David Edmundson
Antonio Rojas
Boudewijn Rempt
Maximiliano Curia
Allen Winter
Albert Astals Cid
Nathaniel Graham
Alexander Volkov