Fix some compiler warnings

Summary:
- Fix order of member initialisation (compiling with -Wreorder)
- Use Q_UNUSED where needed
- QAtomicInteger::loadRelaxed() has been available since Qt 5.14

Test Plan: make && ctest

Reviewers: #frameworks, dfaure, apol

Reviewed By: dfaure

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27158

src/kconfig_compiler/KConfigCodeGeneratorBase.cpp

@@ -30,7 +30,7 @@ KConfigCodeGeneratorBase::KConfigCodeGeneratorBase(
     const QString &fileName,
     const KConfigParameters &parameters,
     ParseResult &parseResult)
-    : m_inputFile(inputFile), m_baseDir(baseDir), m_fileName(fileName), m_cfg(parameters), parseResult(parseResult)
+    : parseResult(parseResult), m_inputFile(inputFile), m_baseDir(baseDir), m_fileName(fileName), m_cfg(parameters)
 {
     m_file.setFileName(m_fileName);
     if (!m_file.open(QIODevice::WriteOnly)) {

src/kconfig_compiler/KConfigXmlParser.cpp

@@ -166,6 +166,7 @@ void KConfigXmlParser::readParameterFromEntry(CfgEntry &readEntry, const QDomEle
 bool KConfigXmlParser::hasDefaultCode(CfgEntry &readEntry, const QDomElement &element)
 {
     Q_UNUSED(readEntry)
+
     for (QDomElement e = element.firstChildElement(); !e.isNull(); e = e.nextSiblingElement()) {
         if (e.attribute(QStringLiteral("param")).isEmpty()) {
             if (e.attribute(QStringLiteral("code")) == QLatin1String("true")) {

src/kconfig_compiler/kconfig_compiler.cpp

@@ -665,6 +665,8 @@ QString indent(QString text, int spaces)
 
 bool hasErrors(KConfigXmlParser &parser, const ParseResult& parseResult, const KConfigParameters &cfg)
 {
+    Q_UNUSED(parser)
+
     if (cfg.className.isEmpty()) {
         std::cerr << "Class name missing" << std::endl;
         return true;