This reverts commit 9f40b17e57.
The idea of a Tools Area separator only makes sense when there is a unibody
Tools Area. When using a color scheme without Header colors, there is no
Tools Area (just a disparate collection of titlebars, manubars, and
toolbars), so the line is just extra visual noise that various people
have objected to following the Plasma 5.21 release. Let's make it
conditional on using a color scheme with Header colors again.
BUG: 433118
FIXED-IN: 5.21.1
If the style is unloaded for example by an application dynamically
switching styles, the listener was still around leading us to call
into destroyed objects when the color scheme was changed.
BUG:432660
Same concept as 03fb4b4900. Not worth the attempt; most dialogs don't draw edge to edge, and the ones that do most likely don't work well with the top border.
This reverts commit ce4e031fc7.
This has been annoying when debugging the tools area, and also causes
many colour schemes that would look good with a tools area border to not
draw one. The cases where this commit improves on are far outweighed by
the ones where this commit causes a visual regression.
This reverts commit 0deecb4d57. This commit
caused many regressions in regards to how the tools area handles changing
toolbars at runtime, and doesn't even properly handle most cases where there
are no changes after application initialisation, as you cannot assume the widget
tree is fully complete at ::polish time.
Never mutate a widget while painting! This causes recursive repaints and makes
prorgams crash. There is a reason why const_casts are discouraged.
BUG:432246
FIXED-IN: 5.21
Otherwise this kconf_update binary writes Breeze colors to the users kdeglobals.
I created a new user, added its ~/.config/kdeglobals to auditd and saw that this binary wrote to it.
BUG: 431917
cac4b544db introduced drawing separators
of transparent QMenus with WindowText color with 0.25 opacity. While the change
in drawMenuItemControl uses the correct condition, drawPanelMenuPrimitive
checked whether the widget had an alpha channel. This is wrong because we set
Qt::WA_TranslucentBackground always on all menus. The very low opacity made it
look like the section headers, separators and highlight were drawing outside of
the menu.
BUG:428710
if a QQuickView is part of a QQuickWidget, we can't do window moving
from there because that window is not actually visible.
so ignore everything in this case.
the drag from anywhere will happen at the qwidget level automatically
if no qquickitem ever accepted the mouse
The author contacted me and requested that their pseudonym be changed
from "Metal Bender" to "ruvkr", which is their GitHub username.
The SVG source file for the wallpaper can be found at
https://github.com/ruvkr/milkyway
Removing hover animations makes controls feel more responsive due to taking less time to respond to the user.
Stripping out the hover code causes a lot of problems due to the code's architecture being highly dependent on the animation engines to keep track of stuff like subcontrol rects and whatnot, so simply hardcoding the values to 0 will suffice for now.
Despite the name, Complementary colors are used more like an always available set of dark color scheme colors. This means that in situations where you'd expect colors to always be dark, they become bright white with Breeze Dark because they were given Complementary colors rather than hardcoded dark colors. I don't think all these instances where the complementary color group is used like that will be fixed before Plasma 5.21 is released, so I'm making the Breeze Dark Complementary color set use normal Breeze Dark colors.
Jan Blackquill
Nate Graham
David Redondo
Laurent Montel
Anthony Fieroni
Noah Davis
Nicolas Fella
l10n daemon script
Jonathan Riddell
Kai Uwe Broulik
Marco Martin
Daan De Meyer