Summary:
This allows devs to run: "make clang-format" and format all files easily
using the preset KDE clang format style
This patch adds support so devs can easily test the intended formatting
now, it doesn't change the code yet.
Doing an initial run to commit everything will happen later.
Test Plan:
Ran script
git diff was full of amazingly cleaned code
See D25134
Summary:
Add some const & for things that return const & so there's no need to make a copy
Add a std::move for a thing that we pass by copy and it's just saved in another variable
Reviewers: zzag
Reviewed By: zzag
Subscribers: zzag, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24614
Summary: It bothered me that the groove for dials doesn't match the maximum area that the contents can use.
Test Plan:
Old: {F7366118, size=full}
New: {F7366127, size=full}
Reviewers: #vdg, #breeze, ngraham
Reviewed By: #vdg, #breeze, ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24008
Summary:
This fixes the colors of things like context menus and application menus
T11124#193132
Test Plan:
Old:
{F7096221}
New:
{F7248348}
Reviewers: #vdg, #breeze
Subscribers: hpereiradacosta, mglb, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23170
Summary: Apparently, the code to adjust the rectangle when a menu is present is what was causing the problem. Also added an if statement to move the separator with the button when sunken.
Test Plan:
Old:
{F7248297, size=full}
{F7248298, size=full}
New:
{F7248300, size=full}
{F7248301, size=full}
Reviewers: #vdg, #breeze, ngraham
Reviewed By: #vdg, #breeze, ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23169
The constructor of QMouseEvent actually expects windowPos and/or screenPos but never globalPos.
By only supplying a localPos we have Qt figure it out correctly on its own.
Differential Revision: https://phabricator.kde.org/D22851
Summary:
Remove unneeded 1 pixel margin around side panels, namely QAbstractScrollArea with property _kde_side_panel_view set to true.
In order to be able to still draw a vertical line on the side of the list, a one pixel margin is kept, on this side only, using SE_FrameContent subelementRect
The viewport background is kept to QPalette::Base, as for regular lists.
The logic in polishScrollArea has been adjusted accordingly
Differential Revision: https://phabricator.kde.org/D22138
- removed useless "virtual" specifications
- removed useless destructors
- cleanup variable initializations
- moved protected methods as private when possible for better encapsulation
Summary:
Without this patch, changing the application color scheme from system
settings only affects some widgets. Notably, checkboxes highlighting
colors stays the old color, leading to a hodge-podge color scheme and
bad contrast on some items.
The breeze QStyle caches the colors read via KSharedConfig, so it needs
to re-read the configuration when the application color changes.
QApplication emits a signal (originating in KGlobalSettings), which we
can react to.
This fixes the coloring of various widgets in breeze right after color
changes.
BUG:408416
FIXED-IN: 5.16
Those I haven't tested, but look quite suspicious (so please re-test):
CCBUG:382505
CCBUG:355295
Test Plan:
1. open kcmshell5 colors
2. change to a theme with a different highlight color
3. apply
* without patch: checkbox in color KCM (and a whole lot of other
widgets all over the place) don't change colors
* with patch: colors change as expected
Reviewers: #plasma, broulik, sitter
Reviewed By: #plasma, broulik, sitter
Subscribers: sitter, cfeck, broulik, zzag, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21646
Summary:
Without this patch, changing the application color scheme from system
settings only affects some widgets. Notably, checkboxes highlighting
colors stays the old color, leading to a hodge-podge color scheme and
bad contrast on some items.
The breeze QStyle caches the colors read via KSharedConfig, so it needs
to re-read the configuration when the application color changes.
QApplication emits a signal (originating in KGlobalSettings), which we
can react to.
This fixes the coloring of various widgets in breeze right after color
changes.
BUG:408416
FIXED-IN: 5.16
Those I haven't tested, but look quite suspicious (so please re-test):
CCBUG:382505
CCBUG:355295
Test Plan:
1. open kcmshell5 colors
2. change to a theme with a different highlight color
3. apply
* without patch: checkbox in color KCM (and a whole lot of other
widgets all over the place) don't change colors
* with patch: colors change as expected
Reviewers: #plasma, broulik, sitter
Reviewed By: #plasma, broulik, sitter
Subscribers: sitter, cfeck, broulik, zzag, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21646
Summary:
The comment says this should match the default border setting in Breeze. Unfortunately it already doesn't. This patch makes it match the new border size in {D13481}.
Depends on D13481
Reviewers: #breeze, abetts
Reviewed By: abetts
Subscribers: abetts, plasma-devel
Tags: #plasma
Maniphest Tasks: T8707
Differential Revision: https://phabricator.kde.org/D13278
Summary:
Adds a recommendation of border size "None" for the new KWin mechanism, which
allows window decoration plugins to recommend a size for KWin's auto border
size mode.
We want our default session with Breeze to have no window borders in order to
reduce visual clutter, make it look more in line with current design trends
and have cross platform apps look more native, in particular Kirigami apps.
This is a solution for T8707.
Test Plan:
Manually with patches to KWin. More testers desirable, needs a fully refreshed
build of Breeze, otherwise the new property is not part of the compiled shared
library for some reason.
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: pedrogomes1698, hein, januz, ngraham, davidedmundson, graesslin, abetts, mart, plasma-devel
Tags: #plasma
Maniphest Tasks: T8707
Differential Revision: https://phabricator.kde.org/D13481
Jacopo De Simoi
l10n daemon script
David Edmundson
Yuri Chornoivan
Albert Astals Cid
Jonathan Riddell
Hugo Pereira Da Costa
Noah Davis
Kai Uwe Broulik
Sebastian Kügler
Nathaniel Graham
Roman Gilg
Filip Fila
Santiago Cézar
Björn Feber