Summary:
At a given moment, menu items do not have empty space on the left side.
This feels not really comfortable or "natural"(I don't know how to
express this feeling).
This revision tries to solve the problem above by reserving space for checkable
widgets. Also, it achieves consistency with macOS/Windows/Unity/etc.
Before
{F5704700, layout=center, size=full}
After
{F5708012, layout=center, size=full}
Context menus with checkable widgets(e.g. radio buttons or checkboxes) look the same
{F5708014, layout=center, size=full}
Test Plan: * open context menu
Reviewers: #breeze, #vdg, ngraham, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: januz, fabianr, mmustac, abetts, anemeth, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10438
Summary:
with the new very slim scrollbars, the rounded rectangle could
go to have a radius more than half their width, making them look
"pointy", this ensures they stay properly round
Test Plan: slim scrollbars still round, bigger ones are unaltered
Reviewers: #plasma, #vdg, hpereiradacosta, hein
Reviewed By: #plasma, hein
Subscribers: hein, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10080
Summary:
the scrollbar handle will be very slim normally, and grow a bit on mouse
over, this makes it work better with QtQuickControls2 listviews where
the contents overlap the scrollbar (as other platform are going in
this direction since they all have scrollbars visible only on scroll
or mouse over)
this makes scrollbars appear more light but still always visible to
convey information
right now follows animations enabled to use this, as the scrollbar groove already did that, tough a "slim scrollbars" settings may make sense
Test Plan: works both as qwidget and with the qstyle-based qqc2-desktop-style
Reviewers: #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Reviewed By: #plasma, #vdg, hpereiradacosta, abetts
Subscribers: davidedmundson, ngraham, colomar, abetts, plasma-devel
Tags: #plasma, #kirigami
Differential Revision: https://phabricator.kde.org/D9792
Summary:
This implements the menu shadow changes proposed in D9549; now we use a combobox with five options: None, Small, Medium, Large, and Very Large.
Large is the new default value (64px window shadows, 16px menu/tooltip shadows), and implements what we recently changed the default to. Small is the old default value (16px window shadows, 12px menu/tooltip shadows) for people who preferred that.
I had a massive amount of help from @hpereiradacosta; in fact, probably 75% of these changes are his. It's a shame multiple authorship isn't possible. Hugo, feel free to commandeer the revision if you'd like the credit!
Test Plan:
Tested in KDE Neon. New smaller menu shadows for the default window shadow size:
{F5615780}
New shadow chooser UI, with different options:
None (1px border for windows, menus, and tooltips):
{F5623069}
Small (16px window shadows, 12px menu/tooltip shadows); replicates the the old default value:
{F5623071}
Medium (32px window shadows, 14px menu/tooltip shadows):
{F5623072}
Large (64px window shadows, 16px menu/tooltip shadows); the new default:
{F5623073}
Very Large (96px window shadows, 24px menu/tooltip shadows):
{F5623074}
Upgrade story: since this changes the way shadow size is stored in the breezerc file, users who previously had manually set their shadow size to some arbitrary pixel value will now get the new default Large 64 px shadow size.
Reviewers: #vdg, #breeze, hpereiradacosta, abetts, rkflx
Reviewed By: #vdg, hpereiradacosta, abetts, rkflx
Subscribers: rkflx, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9627
Summary:
FEATURE: 388256
#VDG has decided that shadows should be horizontally centered and bigger. This patch implements those changes in the following way:
- Window and menu shadows are now horizontally centered
- Shadow size increased to the maximum value
- Shadow color changed from pure black to a slightly lighter Breeze standard color: Shade Black
Test Plan:
Tested in KDE Neon. Before:
{F5587393}
After:
{F5587390}
Reviewers: abetts, hpereiradacosta, #vdg, #breeze, alake
Reviewed By: abetts, hpereiradacosta, #vdg
Subscribers: rkflx, zzag, cfeck, januz, rpelorosso, apol, mvourlakos, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9549
Summary:
Change "Display window borders for maximized windows" to "Allow resizing maximized windows from window esges"
This makes it obvious what the purpose of the feature is, and why one would want to turn it on.
CCBUG: 387675
Test Plan:
Tested in KDE Neon. feature still works, and only the text is changed. Before:
{F5540181}
After:
{F5542554}
Reviewers: hpereiradacosta, #breeze, #vdg
Reviewed By: hpereiradacosta
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9284
Summary:
Gwenview's {nav Operations} sidebar uses custom `QToolButtons` which are
wide and left aligned. Special support for this in Breeze was added with
2fb62271d7. However, compared to the KDE4 version there is not enough space
between the left button border and the icon:
{F5539728}
This is fixed by adding the appropriate margin:
{F5539730}
Note how this replicates exactly the spacing of the toolbuttons in the
regular toolbar on the top (which had its icon size set to "small" in
this screenshot).
CCBUG: 381535
Test Plan:
Icons on toolbuttons in Gwenview's {nav Operations} sidebar no longer
squished all the way to the left, text spacing still looking good.
Reviewers: hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9281
Summary:
BUG: 381288
For active elements, use Shade Black instead of Charcoal Grey and Paper White instead of Cardboard Grey. This slightly increases contrast and makes text easier to read.
Test Plan:
Insufficient text contrast has been noted in reviews of Plasma, for example http://www.ocsmag.com/2017/10/18/plasma-5-11-keep-the-momentum-going/
> However, font color and contrast are in need of an improvement. I had to change the theme and set the text color to pure black, and this provides an immediate ergonomic boost and helps reduce the strain on the eyes. I really don’t understand why distros don’t use simple black color for fonts. Everything else is configurable but the text should be crystal clear.
Pure black has a few disadvantages, since some people find pure black on pure white to be blinding. So I changed the gray text to a darker gray, but it's not solid black, so there is still never a solid-black-on-pure-white situation.
Compare old vs new and look at the text and tooltips:
Before:
{F5456910}
After:
{F5456911}
Before:
{F5456920}
After:
{F5456922}
IMHO the second ones are clearer and less muddy, and therefore **easier** on the eyes, not harder.
Reviewers: hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg, abetts
Reviewed By: #vdg, abetts
Subscribers: subdiff, abetts, januz, progwolff, broulik, sebas, plasma-devel
Tags: #plasma, #breeze
Differential Revision: https://phabricator.kde.org/D7424
Summary:
Adds a new settings on Breeze theme which allows the user to turn off the title bar separator drawn
{F5437291}
{F5437290}
Rationale behind this patch:
From what I understand, the separator is seen as a design choice so I won't argue over it, not to mention something like this is entirely subjective.
However, I personally dislike the separator, especially on darker windows. The only way to get rid of it is to either make a custom color scheme for each application so the colors match exactly or run a patched version of breeze (which is what I do). Before using my Breeze patched version I searched on the net on how to remove it, which led me to several threads with other users wanting to toggle it off which is why I make this patch public.
Below are screenshots where the separator is especially noticeable and in my non-design-expert opinion kind of distracting. I think it's a positive addition. Looking forward to your opinions on the matter.
{F5437332}
{F5437331}
{F5437330}
{F5437329}
Test Plan:
1. Use default breeze theme
2. Check the enable/disable the new setting
Reviewers: #breeze, #vdg, ngraham, hpereiradacosta
Reviewed By: ngraham
Subscribers: andreaska, abetts, jensreuterberg, broulik, rpelorosso, #breeze, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8362
Hugo Pereira Da Costa
Vlad Zagorodniy
Friedrich W. H. Kossebau
Albert Astals Cid
l10n daemon script
Bhushan Shah
Marco Martin
Jonathan Riddell
Nathaniel Graham
Laurent Montel
Henrik Fehlauer
Kai Uwe Broulik
Elvis Angelaccio
Emirald Mateli
Alexander Potashev
Martin Flöser