Summary:
In Qt 4, the compiler detection macros have no value, so they can't be compared
against. So just use the compiler-specific ones.
It also makes use of the fact that undefined tokens evaluate to 0 in
comparisons.
Test Plan: jriddell built it with GCC 5 and 7 against Qt 4 and 5.
Reviewers: #breeze, davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12277
Summary:
With this changes it's more clear where shadow tiles are created, also it
fixes one possible bug. For example, right now, there are two shady actors
who trigger creation of the shadow tiles:
* the first one lays inside of Style::loadConfiguration(). It creates
shadow tiles as a side effect of configuration of _mdiWindowShadowFactory
* the second one lays inside of ShadowHelper::createPixmapHandles()
Please note, ShadowHelper::createPixmapHandles() is invoked only for X11 not Wayland!
Reviewers: #breeze, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11533
Summary:
Qt has its own macro to tell the compiler that the lack of the break
statement is intentional. One of the advantages of using Q_FALLTHROUGH
is that it explicitly says other developers that the break statement is
missing on purpose. Another advantage is that we can use directives,
see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77817
Test Plan:
Compiled Breeze with GCC 7 and Clang, no "this statement may fall
through" warnings whatsoever.
Reviewers: #breeze, davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11860
Summary:
All these return statements are at the end of functions which return
nothing.
Reviewers: #breeze, mart
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11638
Summary:
The old null pointer constants(NULL, 0, etc) are converted to the
the new C++11 nullptr keyword with clang-tidy.
Reviewers: #breeze, mart
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11635
Summary:
When a menu doesn't have any icons, space between check boxes and
text is twice as big as it should be.
Before
{F5714217, layout=center, size=full}
After
{F5714219, layout=center, size=full}
Test Plan: * open menu which has at least one checkbox and doesn't have any icons
Reviewers: #breeze, #vdg, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10584
Summary:
Added option to set transparency and blur behind menu frames such as right click context menu, toolbar menu, etc.
Transparency and blur is disabled by default.
Test Plan: {F5680253}
Reviewers: hpereiradacosta, #plasma, colomar, alake
Reviewed By: hpereiradacosta, #plasma
Subscribers: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel
Tags: #plasma, #breeze
Differential Revision: https://phabricator.kde.org/D10170
Summary:
Before
{F5714193, layout=center, size=full}
After
{F5714196, layout=center, size=full}
Test Plan: * open a context menu with icons and check boxes
Reviewers: #breeze, #vdg, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10480
Summary:
At a given moment, menu items do not have empty space on the left side.
This feels not really comfortable or "natural"(I don't know how to
express this feeling).
This revision tries to solve the problem above by reserving space for checkable
widgets. Also, it achieves consistency with macOS/Windows/Unity/etc.
Before
{F5704700, layout=center, size=full}
After
{F5708012, layout=center, size=full}
Context menus with checkable widgets(e.g. radio buttons or checkboxes) look the same
{F5708014, layout=center, size=full}
Test Plan: * open context menu
Reviewers: #breeze, #vdg, ngraham, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: januz, fabianr, mmustac, abetts, anemeth, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10438
Summary:
with the new very slim scrollbars, the rounded rectangle could
go to have a radius more than half their width, making them look
"pointy", this ensures they stay properly round
Test Plan: slim scrollbars still round, bigger ones are unaltered
Reviewers: #plasma, #vdg, hpereiradacosta, hein
Reviewed By: #plasma, hein
Subscribers: hein, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10080
Summary:
the scrollbar handle will be very slim normally, and grow a bit on mouse
over, this makes it work better with QtQuickControls2 listviews where
the contents overlap the scrollbar (as other platform are going in
this direction since they all have scrollbars visible only on scroll
or mouse over)
this makes scrollbars appear more light but still always visible to
convey information
right now follows animations enabled to use this, as the scrollbar groove already did that, tough a "slim scrollbars" settings may make sense
Test Plan: works both as qwidget and with the qstyle-based qqc2-desktop-style
Reviewers: #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Reviewed By: #plasma, #vdg, hpereiradacosta, abetts
Subscribers: davidedmundson, ngraham, colomar, abetts, plasma-devel
Tags: #plasma, #kirigami
Differential Revision: https://phabricator.kde.org/D9792
Summary:
This implements the menu shadow changes proposed in D9549; now we use a combobox with five options: None, Small, Medium, Large, and Very Large.
Large is the new default value (64px window shadows, 16px menu/tooltip shadows), and implements what we recently changed the default to. Small is the old default value (16px window shadows, 12px menu/tooltip shadows) for people who preferred that.
I had a massive amount of help from @hpereiradacosta; in fact, probably 75% of these changes are his. It's a shame multiple authorship isn't possible. Hugo, feel free to commandeer the revision if you'd like the credit!
Test Plan:
Tested in KDE Neon. New smaller menu shadows for the default window shadow size:
{F5615780}
New shadow chooser UI, with different options:
None (1px border for windows, menus, and tooltips):
{F5623069}
Small (16px window shadows, 12px menu/tooltip shadows); replicates the the old default value:
{F5623071}
Medium (32px window shadows, 14px menu/tooltip shadows):
{F5623072}
Large (64px window shadows, 16px menu/tooltip shadows); the new default:
{F5623073}
Very Large (96px window shadows, 24px menu/tooltip shadows):
{F5623074}
Upgrade story: since this changes the way shadow size is stored in the breezerc file, users who previously had manually set their shadow size to some arbitrary pixel value will now get the new default Large 64 px shadow size.
Reviewers: #vdg, #breeze, hpereiradacosta, abetts, rkflx
Reviewed By: #vdg, hpereiradacosta, abetts, rkflx
Subscribers: rkflx, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9627
Summary:
FEATURE: 388256
#VDG has decided that shadows should be horizontally centered and bigger. This patch implements those changes in the following way:
- Window and menu shadows are now horizontally centered
- Shadow size increased to the maximum value
- Shadow color changed from pure black to a slightly lighter Breeze standard color: Shade Black
Test Plan:
Tested in KDE Neon. Before:
{F5587393}
After:
{F5587390}
Reviewers: abetts, hpereiradacosta, #vdg, #breeze, alake
Reviewed By: abetts, hpereiradacosta, #vdg
Subscribers: rkflx, zzag, cfeck, januz, rpelorosso, apol, mvourlakos, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9549
Summary:
Gwenview's {nav Operations} sidebar uses custom `QToolButtons` which are
wide and left aligned. Special support for this in Breeze was added with
2fb62271d7. However, compared to the KDE4 version there is not enough space
between the left button border and the icon:
{F5539728}
This is fixed by adding the appropriate margin:
{F5539730}
Note how this replicates exactly the spacing of the toolbuttons in the
regular toolbar on the top (which had its icon size set to "small" in
this screenshot).
CCBUG: 381535
Test Plan:
Icons on toolbuttons in Gwenview's {nav Operations} sidebar no longer
squished all the way to the left, text spacing still looking good.
Reviewers: hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9281
Jacopo De Simoi
Fabian Vogt
Vlad Zagorodniy
Hugo Pereira Da Costa
Alex Nemeth
Albert Astals Cid
l10n daemon script
Marco Martin
Nathaniel Graham
Henrik Fehlauer
Elvis Angelaccio
Alexander Potashev
Martin Flöser