The "activate" signal is not necessary because as soon as text is changed
a new search is started anyway. key-press-events have to be handed to
the underlying widget after processing.
The select object helper only checks the first object whose bounding box
contains the selection point. This commit fixes the issue by making the select
object helper check every such object until the criteria is matched.
Otherwise glib will provide a (likely spurious) last element in argv,
causing EFAULT to be returned from execve in the child:
...
[pid 32237] execve("/usr/local/bin/kpsewhich", ["kpsewhich", "standalone", 0x1], 0x7ffe7141a078 /* 69 vars */) = -1 ENOENT (No such file or directory)
[pid 32237] execve("/usr/bin/kpsewhich", ["kpsewhich", "standalone", 0x1], 0x7ffe7141a078 /* 69 vars */) = -1 EFAULT (Bad address)
...
Thats by the way why we should use the AAA style.
/home/febbe/ClionProjects/xournalpp/src/control/Control.cpp:2921:8: error: case value evaluates to -3, which cannot be narrowed to type 'guint' (aka 'unsigned int') [-Wc++11-narrowing]
case GTK_RESPONSE_ACCEPT:
^
/home/febbe/ClionProjects/xournalpp/src/control/Control.cpp:2931:8: error: case value evaluates to -2, which cannot be narrowed to type 'guint' (aka 'unsigned int') [-Wc++11-narrowing]
case GTK_RESPONSE_REJECT:
As the presentation remotes use the left and right keys for page/slide
navigation, map them to previous and next page in presentation
mode. It still preserves the Shift+Left/Right combination in dual page
view. It only masks out the relative scrolling which is not needed in
presentation mode, so thats okay.
removed leak in MainWindow.cpp
removed leak in SettingsDialog.cpp
Refactored DeviceListHelper to a static factory,
because this was a factory object which owned self created data.
Signed-off-by: Fabian Keßler <fabian_kessler@gmx.de>
Added const correctness to some functions.
refactored uninitialized local variables and unused code out.
replaced some virtuals in editited files with override since this is more clear.
Julius Lehmann
Nikolay Korotkiy
Fabian Keßler
Bryan Tan
Ulrich Huber
Lewin Bormann
Stefan Wallentowitz