rolandlo
f9b5e5ceb5
made padding, shaddows depend on zoom mode
5 years ago
Reed A. Cartwright
313ac06bed
Remove debug messages and comments
5 years ago
Reed A. Cartwright
7234b2922e
Fullscreen now works. Accelerators do not.
6 years ago
Reed A. Cartwright
f33acbd9af
Support a fullscreen/presentation view with no padding.
6 years ago
Bryan Tan
f873cff689
Fix MacOS 10.14 backwards compatibility issue
6 years ago
Marco Aurélio Graciotto Silva
f93a7a0de5
Fix issue #1867 .
...
When moving to the last page of the following PDF document, https://dx.doi.org/10.1109/TSE.1985.232210 ,
xournal++ hangs (segfaults). You can try to move to the last page either by scrolling
or by setting the page number in the spinpage box, the result will be the same.
After some debugging, I narrowed it down to the latest statement of Layout::updateVisibility():
this->view->getControl()->firePageSelected(mostPageNr). For some reason, this was triggering an
infinite storm of events.
Currently, the updateVisility() is always creating a page selected event, even if there is no
change in page visibility. My solution was to fire the event only if a change occurred
in the visibility.
I used std::optional for the variable mostPageNr. If it was not changed by updateVisibility()'s
algorithm, we do not fire the event that depends upon on mostPageNr's value.
6 years ago
Bryan Tan
22a0dd89a0
Block scroll event handler during scroll event (hotfix for #1660 )
6 years ago
Fabian Keßler
86aa7e5c98
removed obsolete LayoutMapper::opoptional_size_t
6 years ago
Febbe
e4fdfeffd8
Refactored Rectangle.h so that template code is only in the header file. Also replaced some bad code
6 years ago
lehmanju
9355113f1f
Make Rectangle a template class ( #1817 )
...
* Make Rectangle a template class
6 years ago
Fabian Keßler
bf3c63fee3
applied formatting
6 years ago
Fabian Keßler
985d0946e7
clang-tidy applied everything in .clang-tidy file,
...
disabled readability-identifier-naming for now,
since the naming convention has not be discussed.
It also it differs from the actual one.
6 years ago
Fabian Keßler
6af347bd4a
clang-tidy cppcoreguidelines-*
6 years ago
Ulrich Huber
6c2b7a74ce
Reintroduce algorithm to select current page when scroll changes
6 years ago
Fabian Keßler
a2e98f4bd7
clang-tidy init
6 years ago
Andreas Stallinger
81aeeba276
remove Arrayiterator from ToolHandler
...
remove Arrayiterator from stroke
remove Arraylist from Typelist
remove Arrayiterator from XournalView
delete Arrayiterator.h
cleanup Arrayiterator
run clang format
6 years ago
Fabian Keßler
fa33dc43f3
removed memory checks
7 years ago
Fabian Keßler
94ce38d7f6
Removed call of recalculate()
...
- which triggered a call to gtk_widget_queue_resize(nullptr);
7 years ago
JJones780
7a521bf233
fix #1405 background flash
7 years ago
JJones780
87573e33a8
review changes
7 years ago
JJones780
d561d14186
use binary search algorithm
7 years ago
JJones780
7766e70828
compare algo's
7 years ago
Fabian Keßler
6317b2a2b0
changed some 32 bit int types to corresponding 64bit type
7 years ago
Fabian Keßler
4b20b56b10
Refactored LayoutMapper to increase recalculation speed of the Layout
7 years ago
Fabian Keßler
be77ada72d
applied clang-format
7 years ago
Fabian Keßler
c0ac8f5412
replaced boost::optional with a temporary struct we want to remove
...
after switching to a newer boost version or stdc++17 (std::optional)
Signed-off-by: Fabian Keßler <fabian_kessler@gmx.de>
7 years ago
Fabian Keßler
286ce5b8b9
refactored layout & resize
7 years ago
Ulrich Huber
6b0852a06b
New input system
7 years ago
JJones780
b65a3b6e95
fixes 1042: Mouse grab: Can't move page up slowly
7 years ago
JJones780
9722334990
fixes #1005 Prefs setting for AddVertical/Horizontal space
7 years ago
JJones780
5d3bbc6557
changes to support peetCreative PR#1022 : LayoutMapper Presentation mode.
7 years ago
JJones780
5253b08fab
Store Mapper assigned row,col in PageView and expose mapper function to allow easy directional navigation of pages.
7 years ago
JJones780
056c6c544f
remove timing/test code from UpdateVisibility
7 years ago
JJones780
00841a8601
fix Layout::UpdateCurrentPage() - now UpdateVisibility - test/timing code in this check-in.
7 years ago
Peter Klausing
7f3f37fcfe
improve zoom behavior Presentation
7 years ago
JJones780
28eaf2d415
Simplify LayoutData class to the point it was no longer necessary - remaining functionality to pageView.
7 years ago
JJones780
769a878ada
Remove redundant page cache check. Various changes from reviewers notes - thanks.
7 years ago
JJones780
3a81d7b6b9
Formatting cleanup
7 years ago
JJones780
effa626cf8
Remove all pageposition, pagepositionHandler and pagePositionCache files and references.
7 years ago
JJones780
b8130bd11a
Cleanup. Using search: linear directional from last.
...
Searches Linear from before last and linear from last were slightly faster but I feel directional is more robust.
Binary search was by far the slowest - assumingly due to the overhead and relatively small search range.
7 years ago
JJones780
cbe0ebd55b
also compare linear search from previous, calculated aproximation, previous -2 oneway , previous -2 directed
7 years ago
JJones780
33c94caf8b
Add binary search - TIME vs linear search. Pre-accumulate sizeRow/Col for searches.
7 years ago
JJones780
4b3e404606
Cache last getViewAt result.
7 years ago
JJones780
7f6d4b73a3
add simple getViewAt() functionality to Layout.
7 years ago
JJones780
2e44c36997
Make LayoutMapper, row and column sizes persist within Layout
...
( preparing for quick pageposition lookup ).
7 years ago
JJones780
9137feff69
Center pages on screen when zoomed out to show all.
7 years ago
JJones780
fdb0a0b69a
re-implement 'Add Vertical Space' and 'Add Horizontal Space' lost during multiLayout changes.
7 years ago
Andreas Butti
5011e97c0e
Code cleanup
7 years ago
Andreas Butti
cdcf02d1a4
fixes #906
7 years ago
Andreas Butti
d977066eee
Compile with clang
7 years ago