Avoid appstream XML file validation failure, by using git tag -l
instead of git tag --list. Could also git tag -""-list, yuck.
$ lintian
E: xournalpp: appstream-metadata-invalid com.github.xournalpp.xournalpp.appdata.xml
$ appstreamcli validate desktop/com.github.xournalpp.xournalpp.appdata.xml
E: ~:~: xml-markup-invalid Could not parse XML data: Entity: line 80: parser error : Double hyphen within comment: <!-- Could be automated more:
`git tag
`git tag --list | grep "^[0-9]*\.[0-9]*\.[0-9]*$`"
^
Validation failed: errors: 1
Gbp-Pq: Name 0001-xml-validity.patch
* Daily snapshot
* Latest snapshot
* Latest snapshot
* Latest snapshot
* Latest snapshot
* Latest snapshot
* Remove depreciated Encoding key item
As quoted on freedesktop.org specification: The Encoding key is deprecated. It was used to specify whether keys of type localestring were encoded in UTF-8 or in the specified locale. Possible values are UTF-8 and Legacy-Mixed. See Appendix D, The Legacy-Mixed Encoding (Deprecated) for more details.
Reference: https://specifications.freedesktop.org/desktop-entry-spec/latest/apc.html
* Add Fedora
* Update spec
* Fix spec
* Update spec
* Fix spec
* Rebuilt
* Fix spec
* Fix spec
* Fix spec
* Fix spec
* Fix spec
* Bump
* Bump
* Fix spec
* Bump spec
* Bump
* Bump
* Add git in build dependency
* Attempt to fix error on compilation
* Attempt to build
* Fix commit variable
* Fix typo
* Workaround release tag refusing to get shortcommit macro
* Alternate versioning
* Update spec file per review
* Use make translation as workaround
* Update README.md
Add contact info and a link to Fedora update page.
This ensures, that both selected and inserted elements are inserted in the correct order.
Selected elements are handled as stack to emplace them to the old position.
New elements are pushed back now.
Audio*.cpp/h
PortAudio*.cpp/.h
Vorbis*.cpp/.hpp
replaced c owning pointers with std::unique_ptr<...>
replaced non nullable non owning pointers with references
fixed const correctness