From e770382aecbd6335f152fa3ed671878bc2dd55bf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabian=20Ke=C3=9Fler?= Date: Tue, 26 Nov 2019 12:44:53 +0100 Subject: [PATCH] fix obvious regression --- src/control/ClipboardHandler.cpp | 2 +- src/control/Control.cpp | 2 +- src/gui/toolbarMenubar/ToolMenuHandler.cpp | 2 +- src/gui/toolbarMenubar/model/ToolbarData.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/control/ClipboardHandler.cpp b/src/control/ClipboardHandler.cpp index 301f4a7f..dd853933 100644 --- a/src/control/ClipboardHandler.cpp +++ b/src/control/ClipboardHandler.cpp @@ -175,7 +175,7 @@ auto ClipboardHandler::copy() -> bool } } - string text = text; + string text{}; for (GList* l = textElements; l != nullptr; l = l->next) { Text* e = static_cast(l->data); diff --git a/src/control/Control.cpp b/src/control/Control.cpp index 1da34680..47e6ad9f 100644 --- a/src/control/Control.cpp +++ b/src/control/Control.cpp @@ -2665,7 +2665,7 @@ auto Control::showSaveDialog() -> bool void Control::updateWindowTitle() { - string title = title; + string title{}; this->doc->lock(); if (doc->getFilename().isEmpty()) diff --git a/src/gui/toolbarMenubar/ToolMenuHandler.cpp b/src/gui/toolbarMenubar/ToolMenuHandler.cpp index b4b79013..d989bf90 100644 --- a/src/gui/toolbarMenubar/ToolMenuHandler.cpp +++ b/src/gui/toolbarMenubar/ToolMenuHandler.cpp @@ -298,7 +298,7 @@ void ToolMenuHandler::signalConnectCallback(GtkBuilder* builder, GObject* object const gchar* handlerName, GObject* connectObject, GConnectFlags flags, ToolMenuHandler* self) { string actionName = handlerName; - string groupName = groupName; + string groupName{}; size_t pos = actionName.find(':'); if (pos != string::npos) diff --git a/src/gui/toolbarMenubar/model/ToolbarData.cpp b/src/gui/toolbarMenubar/model/ToolbarData.cpp index 3833d60e..292a082d 100644 --- a/src/gui/toolbarMenubar/model/ToolbarData.cpp +++ b/src/gui/toolbarMenubar/model/ToolbarData.cpp @@ -113,7 +113,7 @@ void ToolbarData::saveToKeyFile(GKeyFile* config) for (ToolbarEntry* e : this->contents) { - string line = line; + string line{}; for (ToolbarItem* it : e->getItems()) {