From acec19922b17837dc84f549b97a30fa2bf5e529c Mon Sep 17 00:00:00 2001 From: Unknown <14054505+piegamesde@users.noreply.github.com> Date: Thu, 31 May 2018 18:14:22 +0200 Subject: [PATCH] Fix two GUI bugs with uncaught exceptions Closes #263, #219, #190 and potentially #229 --- src/control/RecentManager.cpp | 6 +++++- src/gui/dialog/ExportDialog.cpp | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/control/RecentManager.cpp b/src/control/RecentManager.cpp index 439b029f..b02bda97 100644 --- a/src/control/RecentManager.cpp +++ b/src/control/RecentManager.cpp @@ -180,7 +180,11 @@ GList* RecentManager::filterRecent(GList* items, bool xoj) if (!ba::starts_with(uri, "file://")) continue; using namespace boost::filesystem; - if (!exists(path(uri.substr(7)))) continue; //substr is for removing uri's file:// + try { + if (!exists(path(uri.substr(7)))) continue; //substr is for removing uri's file:// + } catch (boost::filesystem::filesystem_error) { + continue; + } if (xoj && ba::ends_with(uri, ".xoj")) { diff --git a/src/gui/dialog/ExportDialog.cpp b/src/gui/dialog/ExportDialog.cpp index bfebc9c2..f19be396 100644 --- a/src/gui/dialog/ExportDialog.cpp +++ b/src/gui/dialog/ExportDialog.cpp @@ -386,7 +386,7 @@ bool ExportDialog::fileTypeByExtension() gtk_tree_model_get(GTK_TREE_MODEL(this->typesModel), &iter, COL_EXTENSION, ¤tExtension, -1); - if (extension == currentExtension) + if (currentExtension && extension == currentExtension) { gtk_tree_model_get(GTK_TREE_MODEL(this->typesModel), &iter, COL_TYPE, &this->type, -1);