Introduced check if XOpenDisplay is successful. It fails when DISPLAY is not set in ENV,

and caused segfault on later invocations that used self->data_conn or self->ctrl_conn.
13 years ago · 4932b18a67
parent b8b353c43b
commit 4932b18a67
1 changed files with 5 additions and 0 deletions
--- a/xcape.c
+++ b/xcape.c
@ -128,6 +128,11 @@ int main (int argc, char **argv)
    self->data_conn = XOpenDisplay (NULL);
    self->ctrl_conn = XOpenDisplay (NULL);

+    if (!self->data_conn || !self->ctrl_conn)
+    {
+        fprintf (stderr, "Unable to connect to X11 display. Is $DISPLAY set?\sn");
+        exit (EXIT_FAILURE);
+    }
    if (!XQueryExtension (self->ctrl_conn,
                "XTEST", &dummy, &dummy, &dummy))
    {