From e579ecbfb620036dd54fcf66fd684bad63cbe79f Mon Sep 17 00:00:00 2001 From: Syohei YOSHIDA Date: Sat, 8 Oct 2016 22:24:42 +0900 Subject: [PATCH 1/3] Specify parent group --- webpaste.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/webpaste.el b/webpaste.el index ba030c5..0e24f00 100644 --- a/webpaste.el +++ b/webpaste.el @@ -39,7 +39,8 @@ (defgroup webpaste nil "Configuration options for webpaste.el where you can define paste providers, -provider priority for which order which provider should be tried when used.") +provider priority for which order which provider should be tried when used." + :group 'web) (defcustom webpaste-provider-priority () From c6ea45cd202b1510fa5c24adebf3a20694549f8a Mon Sep 17 00:00:00 2001 From: Syohei YOSHIDA Date: Sat, 8 Oct 2016 22:26:11 +0900 Subject: [PATCH 2/3] Specify type attribute of custom variable --- webpaste.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/webpaste.el b/webpaste.el index 0e24f00..393c5f0 100644 --- a/webpaste.el +++ b/webpaste.el @@ -47,7 +47,8 @@ provider priority for which order which provider should be tried when used." "Define provider priority of which providers to try in which order. This variable should be a list of strings and if it isn't defined it will default to all providers in order defined in ‘webpaste-providers’ list." - :group 'webpaste) + :group 'webpaste + :type '(repeat string)) (defvar webpaste-tested-providers () @@ -111,7 +112,9 @@ each run.") Consists of provider name and lambda function to do the actuall call to the provider. The lamda should call ‘webpaste-return-url’ with resulting url to return it to the user." - :group 'webpaste) + :group 'webpaste + :type '(alist :key-type (string :tag "provider name") + :value-type (function :tag "lambda function to the provider"))) ;; Function we use to return the RETURNED-URL from the service From 53dcac833979248566e01f7e6012e85ff517cbb1 Mon Sep 17 00:00:00 2001 From: Syohei YOSHIDA Date: Sat, 8 Oct 2016 22:26:37 +0900 Subject: [PATCH 3/3] Move definition position It should be put before used. --- webpaste.el | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/webpaste.el b/webpaste.el index 393c5f0..100ef43 100644 --- a/webpaste.el +++ b/webpaste.el @@ -184,6 +184,12 @@ When we run out of providers to try, it will restart since (let ((text (buffer-substring (mark) (point)))) (webpaste-paste-text text))) +;;;###autoload +(defmacro webpaste-save-mark-and-excursion (&rest body) + "Wraps usage of sending BODY to ‘save-mark-and-excursion’ / ‘save-excursion’." + (if (< emacs-major-version 25) + `(save-excursion ,@body) + `(save-mark-and-excursion ,@body))) ;;;###autoload (defun webpaste-paste-buffer () @@ -195,15 +201,6 @@ When we run out of providers to try, it will restart since (goto-char (point-max)) ; Go to point-max (webpaste-paste-region))) ; Paste region - -;;;###autoload -(defmacro webpaste-save-mark-and-excursion (&rest body) - "Wraps usage of sending BODY to ‘save-mark-and-excursion’ / ‘save-excursion’." - (if (< emacs-major-version 25) - `(save-excursion ,@body) - `(save-mark-and-excursion ,@body))) - - (provide 'webpaste) ;;; webpaste.el ends here