You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tag: Branch: Tree: f67d61b391

wilder

wilder-5.14

wilder-5.17

wilder-5.18

wilder-5.19

wilder-5.22

wilder-5.24

wilder-5.25

wilder-5.26

wilder-5.26-rebase

wilder-broken-krunner

wilder-portage

wilder-portage-prov

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from 'f67d61b391'

${ noResults }

plasma-workspace/dataengines/hotplug

History

Harald Sitter f67d61b391 move SolidUiServer::showActionsDialog to hotplug dataengine ... Summary: it was the only remaining user of that dialog helper. the connection between the two was fairly meh. the engine would invoke the kded module over dbus, the module would then process the request, find that only one desktop entry is specified, resulting in one action being found and then running that action on behalf of the engine. this is overly complicated for no additional gain. the engine is the sole user of this functionality AND it already had knowledge of the service system, so soliduiserver in this case doesn't actually add anything. it's just a more involved call chain. the useful code of soliduiserver is now in the hotplug dataengine directly and the soliduiserver no longer supports the actions dialog. hotplug is now the sole authority for hotplugging. soliduiserver: - include cleanup - all classes no longer in use have been removed - kdelibs4support is no longer a link target - new link targets i18n + widgetsaddons (previously pulled in by kdelibs4support) hotplug: - hotplugjob now directly executes service actions using classes imported from soliduiserver - no longer links qtdbus - new translation domain plasma_engine_hotplug (for i18n call in imported service classes) - new link against ki18n for that reason Test Plan: running an action works same as before, internally it no longer relies on dbus/kded Reviewers: broulik Reviewed By: broulik Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D21761		7 years ago
..
CMakeLists.txt	move SolidUiServer::showActionsDialog to hotplug dataengine	7 years ago
Messages.sh	move SolidUiServer::showActionsDialog to hotplug dataengine	7 years ago
deviceaction.cpp	move SolidUiServer::showActionsDialog to hotplug dataengine	7 years ago
deviceaction.h	move SolidUiServer::showActionsDialog to hotplug dataengine	7 years ago
deviceserviceaction.cpp	move SolidUiServer::showActionsDialog to hotplug dataengine	7 years ago
deviceserviceaction.h	move SolidUiServer::showActionsDialog to hotplug dataengine	7 years ago
hotplug.operations	…
hotplugengine.cpp	[Hotplug Engine] Update actions at runtime and listen for added/removed	8 years ago
hotplugengine.h	[Hotplug Engine] Update actions at runtime and listen for added/removed	8 years ago
hotplugjob.cpp	move SolidUiServer::showActionsDialog to hotplug dataengine	7 years ago
hotplugjob.h	Use nullptr	8 years ago
hotplugservice.cpp	…
hotplugservice.h	…
plasma-dataengine-hotplug.desktop	SVN_SILENT made messages (.desktop file) - always resolve ours	7 years ago