ba44b69abf added logic to handle apps that
use an absolute path in their .desktop file to define their icon, which
works. However in the process it introduced a subtle bug: if the icon is
not an absolute path and it's just a normal icon name, when
QFileInfo::exists() checks for the existence of that string, it will
treat it as a relative file path and therefore look for it in the
current working directory, which is typically the user's homedir. If it
finds something, it will go down the wrong code path and end up
returning a blank QIcon. This can be verified by adding a folder with
the name of an app icon into ~ and restarting plasmashell; that app in
Kickoff will have a blank icon.
To fix this, the icon loading code now first checks whether the icon
returned by m_service->icon() is actually an absolute path. If not, it
skips the logic to look for it on disk and goes straight to the
codepath that looks for an icon with that name in the icon theme.
To minimize disk reads, it checks for absolute-file-path-ness by
inspecting the string returned by m_service->icon() rather than using
QFileInfo::isAbsolute(), because this is a hot code path and most icons
will not have relative paths, so checking the disk for every one of
them would be a waste of resources.
BUG: 457965
FIXED-IN: 5.24.7
Use icu transliterator to convert i18n'ed name into ascii for initial
character grouping. Since AppsModel does not use group(), just use group
to store this value for convenience.
Relevant qt feature request for having a new mode for section:
https://bugreports.qt.io/browse/QTBUG-91258
Strategy used by this code mainly focused on CJK language.
1. Japanese locale will group all Han script together.
Katakana will be converted to hiragana.
2. Hangul will decompose and use consonant as group name.
3. Han will use icu "Han-Latin" transliteration to convert to pinyin.
BUG: 433297
This allows 3rd parties to provide additional actions in the context
menu of applications in kicker, kickoff,... by supplying suitable
desktopfiles in GENERIC_DATA_LOCATION/plasma/kickeractions similar
to mechanism used for service menues.
Entries for which the actions are displayed can be controlled by
X-KDE-OnlyForAppIds in the [Desktop Entry], for example
X-KDE-OnlyForAppIds=org.kde.kate,org.kde.dolphin
This was requested as a patch for steam, but we've made a generic
solution so that it can be used by everyone.
Summary: And use KNotificationJobUiDelegate in case of errors
Test Plan: Untested other than compilation
Reviewers: broulik, davidedmundson
Reviewed By: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29124
Summary: The icon name seems a bit weird to me, but it's what Dolphin uses for a similar purpose
Reviewers: #plasma, hein, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23640
For KCMs we get a relative entryPath() for our KService resulting in an invalid URL being created.
BUG: 397070
FIXED-IN: 5.14.0
Differential Revision: https://phabricator.kde.org/D14647
Summary:
The favourites are based on KAStats (already released version) **and kactivitymanagerd master (to be released with the next Plasma release)**. It allows favourites to be set to all activities, or the user can choose which activities to show a specific favourite application on.
This change covers applications, files and contacts, other favourites are still based on the old model (now named SimpleFavoritesModel).
{F1028047}
Test Plan:
Tested in Kicker, Dashboard and Kickoff the following:
Transitioning mechanism:
- load default favorites for the blank user
- load custom default favorites set in the plasmoidsetupscripts script for Kicker
- transition old results - when transitioning, merge the favourites from all launchers. The ordering for each launcher is kept separate (newly added items due to the merge go to the end)
Favorite manipulation:
- right-click add favorite to all activities
- right-click remove favorite from all activities
- right-click add favorite to specific activity (current)
- right-click remove favorite from specific activity (current)
- right-click add favorite to specific activity (not current)
- right-click remove favorite from specific activity (not current)
- right-click move from all to specific
- right-click move from specific to all
- right-click move from one activity to another
- dnd reorder items in the model (up)
- dnd reorder items in the model (down)
- dnd add to favorites at a specific position
Other:
- launch the application
- ordering persists after restart
- ordering from the previous is kept on the activity that has no ordering
Reviewers: mart, hein
Reviewed By: hein
Subscribers: Zren, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3805
Summary:
Normally I would just close any bug report saying a 3rd party lib should
be optional, but it's quite a big dependency chain for a fairly minor
feature that is easy to ifdef out.
Also we're depending on something that was only released a few weeks ago,
in experience that generally will cause some distro to patch it out anyway.
BUG: 374310
Test Plan:
My AppstreamQt (from distro packages) is broken, so needed to do a temporary workaround anyway.
Built this and it works, haven't been able to test a with appstream version.
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: anthonyfieroni, huber, hein, mak, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3923
Summary:
PackageKitQt5_FOUND can never be set, it's a leftover that should be
removed wtih 27d71ef5f394f6a53aff3e022ae0145e09e89765
Reviewers: #plasma, hein, apol
Reviewed By: #plasma, hein, apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3921
So far we had a (commented out) entry that was called `Remove <application
package>` that would open the configured application.
* Instead of looking up the service files in PackageKit, it does so on
AppStream, allowing for a faster and sync approach.
* Renames the action to `Open <application name>`.
* Uses `appstream://` URI scheme, allowing for the system to decide which
application handles it rather than an awkward configuration entry.
* Drops PackageKit-Qt opcional dependency, adds a required AppstreamQt
dependency instead.
This also means that applications coming from other sources than the
packaging system (i.e. Snappy, Flatpak or AppImage) would also be supported,
as long as it's supported by the software center.
REVIEW: 129697
Summary:
This does three changes needed to support the Simple Menu UI:
* Support for pagination with configurable page size and related
API naming changes.
* Make showing the Power / Session top-level category optional.
* Emit a signal on wheel move events in WheelInterceptor.
As well as adding inheritance from QQmlParserStatus to RootModel
to avoid startup churn.
Reviewers: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3655
Summary:
And default to on.
I don't like this, but downstream complains that their users get
confused when using kmenuedit to edit their menu and newly-
installed apps are no longer sorted-in alphabetically in the
presence of the kmenuedit-generated files causing sorting to be
disabled. And we don't have the resources to fix kmenuedit.
Reviewers: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2940
Currently we cannot populate the context menu asynchronously which means we
block waiting for PackageKit which takes multiple seconds. While fixing the missing
include was correct, the result is a terrible regression in a bugfix release.
Once changes to the context menu can be notified by the Kicker backend, ie. 5.8,
this feature will return, sorry.
As discussed with Eike
"new KRun" is only meant to run absolute file paths and so breaks when we get a
service with relative entryPath() like when finding a KCModule.
The tempFile argument causes this call to be asynchronous as to not block the UI.
Once we can depend on KDE 5.24 and D1902 is merged, use KRun::runApplication instead
Differential Revision: https://phabricator.kde.org/D1898
starting the desktop file from URL doesn't make too much sense as it
means we parse the mimeType beore then finding it's a desktop file.
Worse, this is broken where we only have a name, for example if you add
a KCM as a favourite.
It's done to avoid the blocking static methods, however there is an
alternate trick to save it blocking.
Reviewed-by: David Faure/Kai Uwe Broulik
When widgets are SystemImmutable, as opposed to UserImmutable, this is because
the system was consciously locked-down by a system administrator, in this case
Kickoff should become essentially read-only, ie.:
* Favorites can no longer be added, removed, or re-arranged
* Applications can no longer be added as launchers to Task Manager
* Applications can no longer be edited or hidden or uninstalled
* The KMenuEdit shortcut is removed from the right-click menu
You can, however, still:
* Drag applications elsewhere to make eg. a desktop shortcut
* Access recent documents in the application context menus as well as jump list actions
CHANGELOG: Applications and favorites in Kickoff are now locked when widgets are locked by KIOSK restrictions
Differential Revision: https://phabricator.kde.org/D1609
Nate Graham
Weng Xuetian
Fushan Wen
David Redondo
Aleix Pol
Volker Krause
Laurent Montel
Alexander Lohnau
Mikel Johnson
Nicolas Fella
David Faure
Méven Car
Kai Uwe Broulik
Bhushan Shah
Shubham Jangra
Ivan Čukić
Eike Hein
David Edmundson
Andrey Bondrov