Summary:
The patch D5036 did calculate wrong whether the background color is light or not which resulted in always black background. The problem was that color reported by plasma is in range 0.0 -- 1.0 not 0 -- 255. Now the background is black only when button background color is dark and otherwise it respects button background color.
BUG: 382264
Reviewers: mart, #plasma
Reviewed By: mart, #plasma
Subscribers: fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11262
Summary:
Currently, to navigate the list of results after typing a search term, you need to press the down arrow twice: first to focus the result list, and a second time to actually change the selection. This patch fixes that by changing the selection during the focus oprtation.
BUG: 392197
Test Plan:
Deployed change, killed, restarted, and activated KRunner, typed a search term:
- The down arrow key now moves to the second item
- Clicked on the text field; up arrow now moves to the previous item in the results list
Activating the {nav Open Containing Folder} button for the first result via the keyboard changes slightly with this patch:
- Currently, it's {nav down arrow > tab key}
- With this patch, it's {nav tab key three times} or {nav down arrow > shift + tab}
Seems like an acceptable change to me to better support the common case of just wanting to easily navigate to the results list items.
Reviewers: #plasma, broulik, mart
Reviewed By: #plasma, broulik, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11611
In the logout screen we use activeFocus to determin which action will be triggered.
Here you only have those buttons as controls, tabbing essentially changing it, so having an underline for focus isn't needed
and clutters the layout since the opacity already changes depending on your selection.
Differential Revision: https://phabricator.kde.org/D9452
Globals need to be constant in shader code for some GL ES versions.
Otherwise leads to non-compiling shader.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9158
The switch user greeter accesses it to get the "vtNumber" when you click the "Switch" button.
CHANGELOG: Fixed being unable to switch users from the Switch User screen
This reverts commit cc86474810.
Summary:
BUG: 382668
The shader compilation currently fails on GLES with errors like:
"0:6(2): error: No precision specified in this scope for type `vec4'"
GLES requires variable qualifiers like highp/lowp, whereas desktop OpenGL
does not. As QGlShaderProgram adds suitable defines on desktop OpenGL
for these qualifiers, it is safe to add these to a declarations, see:
http://doc.qt.io/qt-5/qglshaderprogram.html#writing-portable-shaders
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T7071
Differential Revision: https://phabricator.kde.org/D7770
Summary:
Add more explicit text to labels (available via "flat review" keys)
Add names to media controls
Test Plan: Ran lockscreen with orca running
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7789
Summary:
enable actual keyboard navigation, as the previous
completely manual keyboard navigation in krunner completely broke
the screen reader support, rendering it inaccessible (while
potentially krunner is one of the most useful apps for blind
users)
Test Plan:
tested to navigate with keyboard (still similar behavior as before)
while having orca running, which correctly read the result entries
Reviewers: #plasma, davidedmundson, broulik
Reviewed By: #plasma, davidedmundson
Subscribers: gladhorn, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7765
Summary:
In the lock screen the user delegate has to elide the text when there
are multiple items next to each other, otherwise it will overlap.
When there's only one item (which is quite common) we don't need to
and doing so looks weird.
Test Plan:
Modified SDDM dummydata/userModel to have one entry with a long name
and back to multiple entries.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7472
Summary: Not sure what I was thinking when I wrote it.
Test Plan:
Grepped m is not used in file.
Grepped it's not used in any other users of the delegate
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7473
Summary:
BUG: 382834
Per the QML specification, the animation Easing.InQuad should be specified with easing.type, not easing.
Test Plan:
run kscreenlocker --testing
The console output should not display a warning about the animation.
Reviewers: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6970
"maysd" stands for "may shut down" apparently.
Kickoff already removed the options in this case but clicking "Logout" yields the new dialog
which offers them all again.
Differential Revision: https://phabricator.kde.org/D6574
Summary:
When clicking the hide button provided by the virtual keyboard, the
keyboard hides, but the state is not updated. This means the animation
for hide is not triggered and even more important the next call to
showHide sets a wrong state. The state assumes it is in visible, when
clicking it goes to hidden. So the virtual keyboard is not getting shown
when clicking the show virtual keyboard button.
To address this problem a change handler for keyboardActive is added
which ensures the state is correct whenever the keyboardActive value
changes.
BUG: 381833
FIXED-IN: 5.10.4
Reviewers: #plasma, sitter
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6456
Summary:
When the TabBox is in the noModifierGrab mode we should activate an
item when being clicked/touched.
Test Plan:
Tested on X11 and Wayland. On Wayland both touch and pointer
work, on X11 only pointer works - requires further investigation.
Reviewers: #kwin, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5415
Summary:
use a state machine to define in a cleaner way
the layout of the lock screen when the keyboard is
open on closed. animate between the state changes with
a slide animation
Depends on D4870
Test Plan:
tested opening the keyboard with different screen locker sizes
to see the text field and the button always stay visible
Reviewers: graesslin, #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4893
Summary:
Just like in the lock screen this adds support for virtual keyboard.
Note: this requires adjustments in sddm, the greeter must specify the
env variable QT_IM_MODULE=qtvirtualkeyboard to have the virtual keyboard
shown.
If the virtual keyboard is not available, the button to enable it will
not be shown.
Test Plan: run in qmlscene
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5061
Summary:
* use backgroundcontrast effect, improves readability a lot
* non-current actions a bit more translucent
* background is actually black if the color scheme is dark, looks washed out otherwise
* add an OK button, that was complained a lot
* short fade animation at the beginning
Test Plan: see screenshot
Reviewers: #plasma, sebas, broulik
Reviewed By: #plasma, broulik
Subscribers: graesslin, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5036
Summary:
If the Loader fails to load we do not need to show the virtual keyboard
button. It won't be functional.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5062
Summary:
This change integrates QtVirtualKeyboard into the Lock screen UI.
A new button is added to the bottom row to toggle the appearance of the
virtual keyboard. The actual keyboard is integrated through a Loader so
that not having qtvirtualkeyboard plugin installed results in a graceful
error instead of a failing lock screen.
When the virtual keyboard is shown the remaining UI shifts upwards. This
is done through adding the stack view into a ColumnLayout. Unfortunately
this can result in an overlap with the clock. This needs some general
improvement as on e.g. my system the clock is never really visible.
To have the virtual keyboard working in the lock screen one also needs
another change to kscreenlocker_greet.
Test Plan: See screenshots
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4870
Summary:
If we show a virtual keyboard, better make sure that useful password
hints are set.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4876
Summary:
The clock so far was manually positioned in a hard coded way which could
result in the clock not being visible or only partly visible. This is the
case for example on my high dpi system with Wayland. See F2672846 for an
example.
This changes the layouting of the clock to use a ColumnLayout, with
spacer elements to ensure that the clock stays visible. It is possible
that the position of the clock now does no longer fully reflects the
ideas of the VDG.
Test Plan: Looks better on my system ;-)
Reviewers: #plasma, #vdg
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4877
Otherwise it fails to lock the screen and since it waits for the lock screen to show up before switching, it never does it.
BUG: 375941
FIXED-IN: 5.9.1
Differential Revision: https://phabricator.kde.org/D4470
Summary: as discussion about branding, as the main logo is changed, add a mention that Plasma is a KDE project in a fine print on the bottom of the screen
Test Plan:
displays correctly in the splash as the attached screenshot
if this is a good change or not i don't have much opinion
Reviewers: #plasma
Subscribers: andreaska, hein, broulik, graesslin, mck182, subdiff, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4050
NativeRendering often utterly breaks at large font sizes. We had this in the previous lock screen design.
Differential Revision: https://phabricator.kde.org/D3823
Brings it in line with the Leave overlay.
Reviewers: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3033
There was code added (approved by me) to make sure we always cast
battery icon percent to an integer if it's undefined. It had the
unintended side effect that a battery life of 0 would also be 'cast' to
100.
When this is undefined we don't show the icon anyway, so
it doesn't really matter what value we fall back to.
The sddm breeze theme battery icon is trying to access the battery
percent. In a batteryless system it produces the syslog message:
Nov 14 22:28:23 samd sddm-greeter[3210]: file:///usr/share/sddm/themes/breeze/components/Battery.qml:39:18: Unable to assign [undefined] to int
Based on https://gist.github.com/Zren/4e5709d842965227088f6e1d3fd42016
Debian-Bug: https://bugs.debian.org/844194
Allows to show the password on click, similar to how it's done in most other
password fields throughout the workspace.
Differential Revision: https://phabricator.kde.org/D3616
I've quite often seen people wondering how to change the keyboard layout on the lock screen.
By adding a keyboard icon it makes the button somewhat more visible but it's
still quite hidden in the corner of the screen.
Differential Revision: https://phabricator.kde.org/D3549
Only show the button if there's a session to switch to and/or the user is allowed to launch a new session.
Differential Revision: https://phabricator.kde.org/D3231
Ask the model instead. The entry might not be there if the user is not allowed to start a new session
Differential Revision: https://phabricator.kde.org/D3232
Radek Hušek
Kai Uwe Broulik
Nathaniel Graham
Friedrich W. H. Kossebau
David Edmundson
Roman Gilg
Aleix Pol
Алексей Шилин
Stefan Brüns
Marco Martin
David Greengas
Martin Flöser
Anthony Fieroni
Maximiliano Curia