Summary:
For url with parameter like audiocd:/1.wav?device=/dev/sr0, the filename
displayed in notifications applet is not correct ("sr0") instead of 1.wav.
This commit try to remove the query string before extract the last path
component.
Test Plan: Manually with audiocd-kio
Reviewers: mart, davidedmundson
Reviewed By: davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4879
Summary:
Bug 378032.
With these changes, notifications can be configured to always persist in the notifications applet.
Todo: filter by application, see https://bugs.kde.org/show_bug.cgi?id=378032#c27
Test Plan: Open the notification plasmoid's settings. Check 'Show a history of notifications'. Trigger some notifications. They should show up in the applet.
Reviewers: #plasma, #vdg, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: mart, graesslin, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7271
While I'm usually a huge fan of States, this is done only half-way with States in the compact
representation (NotificationIcon) overwriting the plasmoid's state in addition to there being
a binding on it in main.qml.
It also used a "default" state (note: the default state in QML is empty string) in addition to
assigning default values on items themselves anyway.
This seems to shift evaluation of bindings into an order where we first stop the BusyIndicator
and then become passive, moving the the systray popup, working around the Qt crash we're seeing.
It's a nice clean up in any case imho.
CCBUG: 381105
Differential Revision: https://phabricator.kde.org/D7319
In QtQuick Layouts implicit size, which is taken from the SVG's preferred size, takes
precedence potentially destroying the layout.
Also, it should have been medium to be consistent with the rest.
BUG: 383213
FIXED-IN: 5.8.8
* Make links clickable again
* Don't pass visualParent to context menu as we already give it a position, fixes it being positioned incorrectly
* Open context menu on press already like is done everywhere else
* Give "Copy" the edit-copy icon
* Deselect text after copying again, otherwise it stays selected but the user cannot unselect it.
BUG: 382263
FIXED-IN: 5.10.5
Differential Revision: https://phabricator.kde.org/D7029
Update the list of country names to the current names in iso-codes
(as output by isoquery -c).
The motivation is updating the name of Czechia as a followup to
https://git.reviewboard.kde.org/r/129644/
As suggested by Albert Astals Cid, fixing the name in i10n is not
enough:
country names are hardcoded in many places and they need to be fixed
separately.
REVIEW: 129691
We copy "ctx" pointer by value into our lambda but by the time our timer fires, it might be gone already.
Instead, pass "ctx" as context to QTimer::singleShot so it won't fire when it's gone.
BUG: 382386
FIXED-IN: 5.10.5
Differential Revision: https://phabricator.kde.org/D6951
According to specification only body text may contain HTML and this keeps apps from screwing up
the layout or even loading remote images.
Differential Revision: https://phabricator.kde.org/D6671
My previous attempt only fixed the case when notifications were directly in a panel.
Now it also no longer crashes when removing a panel that has a System Tray with the
notifications applet in it.
BUG: 378508
FIXED-IN: 5.8.8
Differential Revision: https://phabricator.kde.org/D6653
Summary: Only use is a label which is API identical.
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6649
Summary:
The license key is specified as GPL, while the actual code (I checked)
in all these cases is licensed under GPL version 2 or later. This commit
fixes the metadata.desktop files to reflect the actual license.
Test Plan: Manually checked, also compared to the keys looked for in kaboutdata.cpp
Reviewers: #plasma, sitter, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6627
Since Qt 5.8 for some reason the Connections {} on plasmoid.nativeInterface breaks.
BUG: 375535
FIXED-IN: 5.10.3
Differential Revision: https://phabricator.kde.org/D6335
Summary:
drop most of the positioning code, drop the animation of the
window position. position the popup in the signal handler of
visibleChanged as we are sure there the size is final and the
first expose event didn't arrive yet.
at that point we are sure the size is the final and correct one
the animation is supposed to be done by the morphingpopups effect
instead.
Test Plan:
notification positions are always correct now, both on X11 and
Wayland.
Unfortunately on x11 the notification typ doesn't seem to pass,
so they are correctly animated only in wayland
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: apol, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6216
We used to always delete the backing .desktop file if we changed a property in a Link (to
a document) hoping that setUrl would call populate. However, it won't do that if the URL
didn't change, so if you only changed the icon, the .desktop file was removed and never
re-created, breaking the applet.
BUG: 380922
FIXED-IN: 5.10.2
Differential Revision: https://phabricator.kde.org/D6148
Label has verticalAlignment: lineCount > 1 ? Text.AlignTop :
Text.AlignVCenter
but in this delegate the height stretches to fit the text:
- height depends on verticalAlignment
- lineCount depends on height
creating a loop with this in the middle.
In this case we always want delegates in the middle, so we can just
override the superclass.
When multiple jobs of the same kind are listed, visually group them.
While this doesn't actively group them (i.e. having a copy, a move, and a copy again
won't move the second copy job to the first - there's no real model underneath, so we
cannot just drop a sort proxy model ontop),
it still improves the most likely situation of copying multiple different things at once.
Differential Revision: https://phabricator.kde.org/D6109
Summary:
The lockscreen uses the MPRIS dataengine. This leads to two applications
registring the service using the same component name which leads to the
shortcuts not working when the lock screen closes.
We want to have the applet register the shortcuts, but not every
dataengine user.
Ideally this shouldn't be in the dataengine either because DataEngines
are read only. This moves the logic to the service which is writable and
registers the shortcuts for the multiplexer there when requested from
the applet.
BUG: 380526
FIXED-IN: 5.10.1
Test Plan:
Opened media player.
Used play/pause shortcut. (the only one my keyboard has)
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6100
Summary:
--the highlight item used in the systray now uses
the panel thickness for correct positioning. In
the past there were cases that the highlight item
wasnt shown at all or was positioned a bit far from
the panel edge
Test Plan:
use the systray and investigate that highlight item
is positioned correctly
Reviewers: #plasma, mart, davidedmundson
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5927
QtQuick Text auto-interprets HTML tags when it finds them, this can lead
to unexpected results if a file is named e.g. `<h1>foo</h1>`.
Since notifications do interpret HTML tags by design, we manually escape
them there.
Differential Revision: https://phabricator.kde.org/D5706
Weng Xuetian
Julian Wolff
Kai Uwe Broulik
l10n daemon script
Jiri Bohac
David Edmundson
Sebastian Kügler
Marco Martin
Eike Hein
Aleix Pol
Montel Laurent
Michail Vourlakos