The previous names did not communicate what those variables were
responsible for.
Hopefully this can make things more understandable and help making
this bit of code more maintainable.
This commit adds a new option to the "Copy to Clipboard" menu that
shows the date with seconds when "show seconds" is not enabled and
without seconds when "show seconds" is enabled.
BUG: 453111
This commit organizes the "Copy to Clipboard" options and removes
a lot of duplicated options when "show seconds" is enabled.
It also makes the code more readable. :)
BUG: 453111
Currently this is hardcoded to KOrganizer, but Kalendar is a nice app and we should be able to launch that too.
Check for the default handler for calendar files and take that if it is KOrganizer or Kalendar. The check is to avoid launching an app that can technically open ics files but isn't a calendar app, e.g. Kate.
We can extend the logic with other known calendar apps
the new script uses tzdata.zi data to construct the tables of timezone
cities and continents. this way humans don't need to maintain the table.
since timezone city names aren't necessarily correct names there's an
additional mapping table inside the script specifically to map from TZ
city names to the english name we want to use
this still needs running manually every once in a while. we need this
source file up-to-date in the repository so the names can be translated
This patch:
* Adds new timezone cities
Acquired from:
$ qdbus-qt5 --system org.freedesktop.timedate1 \
/org/freedesktop/timedate1 org.freedesktop.timedate1.ListTimezones
* Updates country names to match `isoquery -c`
Sometimes, the filter in the timezone selector would only
show those items already selected.
Initialize the property 'showOnlyChecked' on the proxy model
so it doesn't depend on random initialization
We do this sometimes, but not consistenly.
The benefit is twofold.
First it improves the diff when adding new values since no existing line needs to be touched.
Second it prevents clang-format from collapsing the definition into a single line, which is undesired for large enums.
Right now we have a usability problem: the Digital Clock applet has two
ways to let you change the timezone displayed in the applet itself, but
has no easy link to the correct way to change the timezone systemwide. As
a result, users change the timezone in the clock and wonder why times are
wrong everywhere else throughout the OS.
This commit removes the feature of changing the timezone in just the
clock, and replaces it with an overhauled Time Zones page in the config
dialog and a new button in the popup that links you to the Date & Time
KCM where you can change the systemwide time zone in the correct way.
I anticipate that this may cause some grumbling from people who currently
use the "mouse wheel to cycle through timezones" behavior, but now that
all the timezones and their times are displayed prominently in the popup,
you can just click on the applet to show the popup instead of rolling the
mouse wheel over it to cycle through times; it's different, but no worse.
BUG: 428096
FIXED-IN: 5.21
Update the list of country names to the current names in iso-codes
(as output by isoquery -c).
The motivation is updating the name of Czechia as a followup to
https://git.reviewboard.kde.org/r/129644/
As suggested by Albert Astals Cid, fixing the name in i10n is not
enough:
country names are hardcoded in many places and they need to be fixed
separately.
REVIEW: 129691
Instead of an hardcoded list of translations of country names, look
them up in the iso_3166 domain, provided by iso-codes. The names of
countries are changes to their ISO 3166 versions in iso-codes.
Look for iso-codes in cmake, but just as indication of it as runtime
dependency.
REVIEW: 126879
In kde4 times, the layout of clock's tooltip was nicely arranged using a
table. Now it's a bit of a mess so this brings back some nice layout.
Also simplifies the timeForZone function which is used only for the
tooltip.
BUG: 357005
BUG: 351472
CCBUG: 357004
FIXED-IN: 5.6.0
REVIEW: 124047
Heiko Becker
Felipe Kinoshita
Laurent Montel
Nicolas Fella
David Edmundson
Alexander Lohnau
Harald Sitter
Adrien Faveraux
Ilya Bizyaev
Carl Schwan
Andreas Cord-Landwehr
Ismael Asensio
Ahmad Samir
Willyanto Willyanto
Eugene Popov
Nate Graham
Yuri Chornoivan
Bernhard Schiffner
Friedrich W. H. Kossebau
Kai Uwe Broulik
Jiri Bohac
Aleix Pol Gonzalez
Elias Probst
Pino Toscano
Martin Klapetek