- Increase the size of next/previous media toolbuttons. I didn't think there was enough padding around the buttons here.
- Set a default width and height of LockScreen.qml. This makes it start with a sane default size when run with qmlscene.
(cherry picked from commit 99475b09a5)
Some users reported this button becoming too small after KF5.74 was released, but I could not reproduce it myself. However, this code did look suspicious. Hopefully this fixes the issue.
Simplifies the logic of the busy indicator since now it will already
fade out when it's not running.
Also addresses the logic of the timer which was off.
This made krunner freak out on Wayland for some reason to investigate,
both opacity animations were triggering a repaint and we tried to render
too often making the process block. With this change it works fine
again.
"Show" vs "Show always" is technically precise, but awkward in practice,
and I don't think the distinction is helpful. People are accustomed to
media controls appearing on demand, so I think we can safely put it in a
group with the label "Show".
There were three principal sources of errors and warnings:
1. Un-ported `onFooChanged` statements
2. `config.fontSize` being unconditionally referenced from components
without access to it (it comes from the SDDM config)
3. Accessing units from the context property rather than the singleton
All are fixed now. Tested with:
1. `sddm-greeter --test-mode --theme ~/kde/usr/share/sddm/themes/breeze/`
2. `~/kde/usr/lib64/libexec/kscreenlocker_greet --testing --theme ~/kde/src/plasma-workspace/lookandfeel`
3. `/kde/usr/lib64/libexec/ksmserver-logout-greeter --fakearg`
No regressions found.
BUG: 425349
FIXED-IN: 5.20
This was previously done in the component itself, but that was removed
in 711789908b0c6c0f76597596d567fba4ae9151ca (plasma-framework). For the
most part, buttons look better without the old minimum width, but these
buttons here relied on that behavior and do in fact look better with it.
So let's set it manually on these buttons.
This begins the process of porting plasma-workspace to PlasmaComponents3. At
this point, only the relatively easy work is done. Every file not ported
now has been given the reason for still using PC2 in a comment on the import
line so you can see at a glance what the blocker is by running
`grep -r "org.kde.plasma.components 2.0"` in the repo.
Everything is tested and there are no breakages or functional regressions. In
the process, a few unused imports are removed.
Here are the remaining PC3 omissions blocking what's left from getting easily
ported:
- No Highlight
- No ListItem
- No PageStack
- No ContextMenu
- No QueryDialog
- No ModelContextMenu
- TabBar has no left and right tab states
- ToolButton has no built-in method to show a menu when clicked
On the lockscreen or on a single user system you can currently move the user
item horizontally across the screen without it doing anything. If the list only
contains one entry, disable interacting with it.
We've now made it easier to increase the maximum volume to 150% for
those who need it due to quiet speakers. However since this could
potentially lead to excessive volume or damage to loud speakers with
long-term use, let's colorize the text to subtly indicate that this is
not a normal state.
The volume setting in plasma-pa can exceed 100%. Currently the display is limited to 100%, which can result in a mismatch between what is shown in the applet and in the OSD.
This adds an overload to volumeChanged to keep the old one compatible given it is used by e.g. kmix
Right now the clearPassword() signal does not actually clear the
password; it only selects all text. This is a violation of its name
as well as being pointless since there's no longer a way to see the
unmasked text, which means you always need to re-enter the whole
password anyway.
BUG: 412252
FIXED-IN: 5.20
Currently on the login screen after some idle time (60 seconds) all controls become hidden, including clock. This commit makes the clock remain visible after idle time (similar to the lock screen).
The new design makes this visually simple, and in fact I think it
improves the composition to have the progrss bar anchored by dark-colored
elements on both sides.
OSDs without progress bars are unaffected.
BUG: 385602
FIXED-IN: 5.20
Merge Request: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/15
Depending on font size and settings the ProgressBar's implicit size might be wider
than our minimum size of 15 gridUnit. This causes the Popup to change size when switching
from ProgressBar (e.g. changing volume) to Text (e.g. volume muted).
By setting preferredWidth to 1 we ensure we never exceed the overall minimum size
when the ProgressBar is shown.
Summary:
A frequent complaint over the years is the size of the OSD. It was tried to alleviate that by having it start fading out slowly immediately but the way it was done wasn't ideal, didn't work on Wayland, and also causes flickering issues in recent Qt versions.
This changes the OSD to a bar-like design similar to the one used in Plasma 4.
BUG: 344393
BUG: 372665
FIXED-IN: 5.20.0
Depends on D29263
Test Plan:
Various OSD messages
{F6773939}
It can grow, if necccessary, to accomodate translations, up to half the screen width.
With Air theme
{F6773940}
Full desktop screenshot for some context
{F6773941}
Reviewers: #plasma, #vdg, broulik, niccolove, ndavis
Reviewed By: #vdg, niccolove, ndavis
Subscribers: ndavis, kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, Codezela, filipf, zzag, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D20569
Jacopo De Simoi
Aleix Pol
Alexander Lohnau
l10n daemon script
Noah Davis
Nate Graham
Niccolò Venerandi
David Redondo
Yuri Chornoivan
Nicolas Fella
Filip Fila
Eugene Popov
Kai Uwe Broulik