property tooSmall depends on height
If it's tool small it changes what text is shown on top of each other
Whether text is shown changes the height; super complex binding loop
that because it throws in a visibility change and goes via layouts isn't
being caught.
From what I can tell of other code when vertical we always want to show
both bits of text.
BUG: 351479
REVIEW: 124874
This patch allows to filter the loaded Plasmoids by formFactor. It uses
a property of host, and passes this down to the PlasmoidProtocol, which
then decides based on formFactor whether or not to show a Plasmoid.
The value for FormFactor can be changed from QML.
REVIEW:124634
In my opinion this is just a temporary workaround and not a very good
one (generally, code-wise it's awesome :P). There should really be a
global config option for that but as we now rely on QLocale and QLocale
is...bad at this, here's at least this small help, which will at least
change the clock format on the panel.
Imo we could really really use something like KLocale again.
REVIEW: 124453
BUG: 345378
FIXED-IN: 5.4.0
One of the most reported bugs wrt digital clock is that the second line
text (date or timezone) is unreadable on small panels so this adds new
state to the clock applet that lays things horizontally when the panel
is too small to show text with the "small" font (set in system
settings).
When there is a date displayed, a delimiter is put in between to allow
easier and faster spotting the time (as on a first glance there is just
a bunch of numbers, so quickly orienteering is super important). I used
the dot symbol first but then went for pipe which I think looks more
clean.
REVIEW: 124449
CCBUG: 348072
- Battery and device notifier go into Hardware category
- Clipboard goes to SystemServices category
- Notifications and media controller go to ApplicationStatus category
This way we don't need to keep three different models in sync which has shown to
break quite often resulting in gaps in the layout and other strange behavior.
BUG: 347554
FIXED-IN: 5.4.0
REVIEW: 124380
- Remove unused imports
- Ensure the heading is readable (needs to use SystemPalette color not Plasma theme color)
- Use a more sensible heading
- Make sure at least one action remains enabled
Now when the applet is on the Desktop the dialog is positioned properly
but in a panel it's still broken. Looks like a bug in PlasmaComponents.Dialog
CCBUG: 349887
The shown percentage now comes from the cumulative Battery rather than an aggregation
of the individual once hence we now need to update when it changes there.
BUG: 349370
FIXED-IN: 5.4.0
This reworks the notification sizing computation to use Layouts. This
should fix all the popup sizing issues there are (including a binding
loop error).
Now it also properly elides after max 4 lines of text.
REVIEW: 124149
FIXED-IN: 5.3.2
BUG: 339588
BUG: 349142
According to Kai:
"object literal is more performant
same with [] vs new Array()
also you should avoid putting the keys in ""
{"foo": bar} is also less performant than {foo: bar} :)"
And so I did to his bidding.
Reviewed-by: Kai Uwe Broulik
With the previous patch, now everything has "notification N" source
name, so there's needed another way to detect that it's a job's
notification.
Reviewed-by: Kai Uwe Broulik