It used to cause an error like this:
[03:21:31.246] (WW) GREETER: file:///usr/share/sddm/themes/breeze/KeyboardButton.qml:19: TypeError: Cannot read property 'shortName' of null
(cherry picked from commit 2e9020ca6c)
Right now we change the intensity of shadows based on the color scheme's
text color, but with a property called "lightBackground". This indicates
that we wanted to do it based on the background color itself, but did
not or could not, so settled on using the text color as a proxy. However
this is wrong; there is no relationship between the active color
scheme's text color and the color of the background image.
Even if we could or did fix that, it would probably still be wrong,
because using lighter shadows on a genuinely light background would
result in worse contrast and readability, especially if the light
background was very visually busy.
For these reasons, in most other places, we have since settled on the
mantra of "shadows should be black", and this commit makes the lock and
login screens follow that convention as well.
BUG: 449985
FIXED-IN: 5.24.2
(cherry picked from commit 146ef22fcb)
The Plasma 5.24 wallpaper changed to a JPEG but this change had to be
reflected in the SDDM config file, which calls out the wallpaper by its
exact file path. This commit does that.
(cherry picked from commit 8edb71570a)
On this page there is no concept of the user being passwordless because
no username has been specified by the user yet; we cannot know ahead of
time. As a result, userList.currentItem.needsPassword is blank so the
password field gets hidden.
We should just assume that in username/password entry mode, all users
have a password set. For any users where this is not the case, they can
just leave the password blank, and it's not any worse than it was in
Plasma 5.22.
BUG: 443737
FIXED-IN: 5.23.1
The UserDelegate has no "m" member (anymore?) and thus that was always
undefined. Expose it through a property instead.
Additionally, reset the login button's preferred width by setting it to -1.
"undefined" is not a valid value for the Layout property.
This reverts commit 2e4b1e1f2d.
That commit was too broad in scope and changed the sizes of more pieces
of text than were needed to fix Bug 442650. It is fixed correctly in
this commit.
CCBUG: 442650
As described here https://github.com/sddm/sddm/issues/751#issuecomment-847347450
SDDM provides the `needsPassword` property, which can be used to hide the
password prompt for passwordless accounts.
This merge request provides a basic implementation for the breeze SDDM theme.
The shadows can look rather harsh against light backgrounds; this commit
softens them a little bitty bit to reduce that effect, while still
preserving adequate contrast to keep the text readable.
BUG: 436247
FIXED-IN: 5.22
The context property version is slower to access and won't be supported
in Qt6. Let's port away from it and use the singleton version instead.
Here was my full process for making this change:
1. Made the change with `find . -name '*.qml' | xargs perl -pi -e 's/units\./PlasmaCore\.Units\./g'`
2. Verified no more occurrences with `grep -r " units."`
3. Made sure this didn't change any comments in a silly way by inspecting the output of `git diff | grep "+ " | grep "//"`
4. Manually inspected the full git diff to make sure there were no other unintentional or silly changes (there were none)
5. verified that all changed files have the PlasmaCore import with the correct name with `for FILE in `git status | grep modified | cut -d ":" -f 3`; do grep -q "as PlasmaCore" $FILE || echo "$FILE needs the PlasmaCore import"; done`
Without this, the virtual keyboard appears and takes focus, which
doesn't make sense:the password field needs to retain focus or else
the keystrokes you type using the virtual keyboard get eaten.
BUG: 430209
FIXED-IN: 5.21
Some users reported this button becoming too small after KF5.74 was released, but I could not reproduce it myself. However, this code did look suspicious. Hopefully this fixes the issue.
There were three principal sources of errors and warnings:
1. Un-ported `onFooChanged` statements
2. `config.fontSize` being unconditionally referenced from components
without access to it (it comes from the SDDM config)
3. Accessing units from the context property rather than the singleton
All are fixed now. Tested with:
1. `sddm-greeter --test-mode --theme ~/kde/usr/share/sddm/themes/breeze/`
2. `~/kde/usr/lib64/libexec/kscreenlocker_greet --testing --theme ~/kde/src/plasma-workspace/lookandfeel`
3. `/kde/usr/lib64/libexec/ksmserver-logout-greeter --fakearg`
No regressions found.
BUG: 425349
FIXED-IN: 5.20
This begins the process of porting plasma-workspace to PlasmaComponents3. At
this point, only the relatively easy work is done. Every file not ported
now has been given the reason for still using PC2 in a comment on the import
line so you can see at a glance what the blocker is by running
`grep -r "org.kde.plasma.components 2.0"` in the repo.
Everything is tested and there are no breakages or functional regressions. In
the process, a few unused imports are removed.
Here are the remaining PC3 omissions blocking what's left from getting easily
ported:
- No Highlight
- No ListItem
- No PageStack
- No ContextMenu
- No QueryDialog
- No ModelContextMenu
- TabBar has no left and right tab states
- ToolButton has no built-in method to show a menu when clicked
ivan tkachenko
l10n daemon script
Nate Graham
Jonathan Riddell
Fabian Vogt
Oleg Solovyov
Carson Black
Alexander Lohnau
Aleix Pol
Tadej Pecar
Felipe Kinoshita
Niccolò Venerandi
Rik Mills
Noah Davis