Summary: {F7331506}
Test Plan: Open Kicker and open the context menu for a menu item.
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: #vdg, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23793
Summary:
Even with the Discover icon added in D23623, the text is still fairly unclear,
especially for the common case of wanting to uninstall the app.
This patch re-words the menu item to add that all-important word "Uninstall", while not
losing any of the current meaning.
Test Plan: {F7306465, size=full}
Reviewers: #vdg, #plasma, hein, nicolasfella
Reviewed By: nicolasfella
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23652
Summary: While not 100% technically correct since another app might be associated with appstream URLs it's still much more expressive than the current icon
Test Plan: {F7302971}
Reviewers: #plasma, hein, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23623
Otherwise if none of the results are viable, we could end up in an infinite loop because we continue before
we actually advance the iterator but also never reach the actionCount limit.
Differential Revision: https://phabricator.kde.org/D22004
Makes it consistent with other places where such an entry exists, such as Dolphin's context menu
Differential Revision: https://phabricator.kde.org/D14671
For KCMs we get a relative entryPath() for our KService resulting in an invalid URL being created.
BUG: 397070
FIXED-IN: 5.14.0
Differential Revision: https://phabricator.kde.org/D14647
Summary:
Users get confused by the difference between "Pin to Task Manager" and "Add to Panel (Widget)", and we get bugs about this.
This patch resolves that confusion by only showing "Add to Panel (Widget)" when there's no Task Manager widget.
BUG: 390817
FIXED-IN: 5.14.0
Test Plan:
Dragging-and-dropping an app from Kicker or Kickoff pins it to the Task Manager if there's a Task Manager, or creates a Panel launcher if there's no Task Manager.
Context menu items:
Task Manager, widgets unlocked:
{F5856628}
Task Manager, Widgets locked:
{F5856629}
No Task Manager, Widgets unlocked:
{F5856630}
Task Manager, Widgets unlocked:
{F5856631}
Reviewers: #plasma, davidedmundson, mart
Reviewed By: #plasma, mart
Subscribers: mart, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12969
Summary:
D10890 was a workaround related to KRecentDocument::add() bug (see D10863)
which is fixed in Frameworks 5.46. Given that Plasma 5.13 depends on that
Frameworks version, it's safe to remove this no longer needed workaround
without breaking anything.
Reviewers: #plasma, broulik, hein
Reviewed By: #plasma, hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12701
Summary:
Due to KRecentDocument::add() bug, application name '<app>' could
be stored for recent documents instead of its desktop entry name
'org.kde.<app>'. This issue mostly affects items opened from apps
themselves, while items opened from e.g. Dolphin are not affected.
(The bug is fixed by D10863, but we depend on Frameworks 5.42 which
doesn't include it.)
Kicker and taskmanager used to query for '<app>' agent only, thus
excluding items with correct 'org.kde.<app>' agent.
This commit makes kicker and taskmanager query for both '<app>' and
'org.kde.<app>' agents in order to get all recent documents for the
application.
Test Plan:
# Create 'test1' and 'test2' text files.
# Open 'test1' in Kate from Dolphin.
# Open 'test2' from Kate itself.
# Right-click Kate in Kicker/Kickoff and Task Manager and check
that both files are present there.
Reviewers: #plasma, broulik, hein
Reviewed By: #plasma, hein
Subscribers: anthonyfieroni, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10890
Summary:
When the code was refactored to show this action also for runner
matches, proper care wasn't taken to test for this, so the action
was shown for document matches as well. It's not safe to use for
docs currently (which should probably be fixed in
KPropertiesDialog) and at any rate isn't meant to be a generic
editing feature as per the action name.
BUG:388340
Reviewers: #plasma, broulik, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9612
Summary:
- Get rid of the unwieldy "Show a launcher when not running" and use Pin instead
- Clarify that "Add to Panel" adds a widget to distinguish from adding to Task Manager
- Use "Pin to Task Manager" in launchers as well
Often-discussed, often-desired, VDG-approved.
BUG:368549
Reviewers: #plasma, mart, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3948
Summary:
For the Plasma 5.7, we will be able to use the kactivities-stats
framework instead of having our internal copy
Reviewers: mart, sebas, hein
Subscribers: plasma-devel
Projects: #plasma
Differential Revision: https://phabricator.kde.org/D1086
This version is a mostly-from-scratch reimplementation of
the Plasma 1 version.
Some minor-in-scope loose ends are left, both external and
internal to the code; check TODO for whether your issue is
already known.
Bhushan Shah
Björn Feber
Nicolas Fella
Laurent Montel
Nate Graham
Kai Uwe Broulik
Eike Hein
Алексей Шилин
Ivan Čukić