The delimiter might change if the settings are changed.
By having a member variable, we still avoid re-creating the same regex for every time the runner is queried.
BUG: 454596
By setting the deprecation version for KRunner to 5.91,
the negated deprecation wrapper will evaulate to true and
we get compatibility typedefs.
This way we do not need to add the typedefs manually or
add `using namespace Plasma` to the plugins.
Task: https://phabricator.kde.org/T15140
Because we can't have nice things the private browsing action in Firefox
sometimes has a %u placeholder for the URL and sometimes doesn't.
The current code only accounts for the case without placeholder, which
is also what Chrome does.
Replace the placeholder if found, otherwise append the URL
The current KRunner utility methods have some issues:
- The runner id is kindof useless, especially when we only have one
action
- We basically create a bunch of temporaries whenever we use the utility
methods
- If one really has more actions and more complex logic one is better of
using QHash with the actions and an enum as the key
Summary:
The foreach has been refactored and the loadSyntaxes method gets now called directly.
Additionally the cached (failed) key/provider can be reused for multiple sessions and is only cleared when the config changes.
Test Plan: Should compile and open urls as before.
Reviewers: ngraham, broulik, meven, apol
Reviewed By: broulik, meven
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27566
This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:
http://community.kde.org/Frameworks/GitOldHistory
If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.
Branched from the monolithic repo kde-workspace, frameworks branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0
Alexander Lohnau
Volker Krause
Nicolas Fella
Friedrich W. H. Kossebau
Laurent Montel
Aleix Pol Gonzalez
Kai Uwe Broulik
Rohan Garg