Summary: Should in some odd case (language) the color wallpaper's "Color:" label be longer than "Layout:" or "Wallpaper Type:" we can ensure the alignment between parent and child layout will not be broken.
Test Plan:
This patch ie. alias works thanks to D20313.
Before:
{F6803859}
After:
{F6803860}
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D20965
Summary:
Porting to Kirigami.FormLayout and using twinFormLayouts in order to ensure alignment with the main layout.
NOTE: Vertical spacing is still clearly wrong, but I could fix that as well if someone could offer a suggestion on how to do it.
Test Plan:
D19932 needed before testing.
Before:
{F6707737}
After:
{F6707739}
Before:
{F6707742}
After:
{F6707740}
Everything still worked.
Reviewers: #plasma, ngraham, mart, hein
Reviewed By: #plasma, ngraham, mart, hein
Subscribers: hein, davidre, mart, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19873
Summary: This patch aligns the color wallpaper plugin's options with the FormLayout above it by making use of twinFormLayouts.
Test Plan:
D19932 needed before testing.
Before:
{F6719634}
After:
{F6719629}
Before:
{F6719633}
After:
{F6719630}
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D20048
Summary:
This allows to exlude single images from the slideshow by unchecking the little checkbox in the top right corner.
Feature or todo?: If a folder is removed I don't touch the unchecked Slides. So the list could get very big but if a formerly removed folder is
added again an excluded image will be excluded again.
Test Plan:
{F6684113}
- Uncheck some images
- They don't appear in the slideshow
Reviewers: #plasma, #vdg, ngraham, davidedmundson
Reviewed By: #plasma, #vdg, ngraham, davidedmundson
Subscribers: davidedmundson, filipf, abetts, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19687
Summary:
This shows all the pictures inside the folders added to the Folders list. I also tried to make single pictures excludable via a checkbox on the thumbnail. This is the first time for me programming with QT/QML/Singals-Slots and I tried to use as much existing code as possible. The thumbnail view is the same as for single images and I simply subclassed the listmodel. However even if I tried to do everything like the code for slidePaths it doesn't work correctly. The checking/unchecking of images only applies on restart of plasmashell. Maybe it's a single mistake that is easily spotted by a more experienced programmer otherwise if the thumbnail view is accepted I can also revert all the checkbox stuff.
FEATURE: 403703
FIXED-IN: 5.16.0
{F6595564}
Reviewers: #vdg, ngraham, davidedmundson
Reviewed By: #vdg, ngraham, davidedmundson
Subscribers: filipf, mart, alexde, davidedmundson, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18809
Summary:
This patch makes the wallpaper chooser grid view delegates show the wallpaper's
title (if it has a desktop file) or filename (if it doesn't). Authorship information
is shown via a tooltip, if present.
Test Plan:
{F6587535, size=full}
{F6587536, size=full}
Reviewers: #vdg, #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18737
Summary:
BUG: 400549
FIXED-IN: 5.15.0
Test Plan:
On the lock screen KCM at 1.2x scale, before: {F6554037}
After: {F6554040}
All functionality continues to work on the lock screen and SDDM KCMs and desktop containment window.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18343
Summary: The current default setting is "Scaled", which results in images that don't match the screen's aspect ratio being compressed along the X or Y axis which almost never looks good. Cropping the image instead of deforming it is a much better default setting.
Test Plan:
- Create new user account
- Right-click on desktop > Configure Desktop
- See that "Scaled and Cropped" is the default setting for the Image and Slideshow plugins
Reviewers: #vdg, #plasma, ndavis
Reviewed By: #vdg, ndavis
Subscribers: ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18004
Summary:
BUG: 402223
FIXED-IN: 5.15.0
Test Plan: Added multiple images from the file dialog. They all showed up in the wallpaper grid.
Reviewers: #konsole, broulik, davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17815
Summary: No big visible changes, but simplifies and modernizes the code
Test Plan: used all functionality of the systray config dialog
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17212
Previously it would use an on-disk KImageCache which would never be invalidated.
Moreover, it just uses KIO::PreviewJob which does its own more clever (compares mtime and other properties) on-disk caching already.
It is using its own QCache rather than QPixmapCache to not jeopardize other caching for the potentially large wallpaper thumbnails
that are only relevant while the dialog is open.
BUG: 395447
FIXED-IN: 5.15.0
Differential Revision: https://phabricator.kde.org/D16095
org.kde.slideshow is duplicated at compile time, so translations aren't extracted for it.
Setting an explicit domain fixes that.
Differential Revision: https://phabricator.kde.org/D16037
Summary:
10 seconds isn't the best default value for slideshows. 15 minutes is more reasonable, and easier on battery life for laptops, too.
For comparison: macOS and Windows both default to 30 minutes.
Test Plan: {F6287038}
Reviewers: #plasma, broulik, mart, #vdg, abetts, davidedmundson
Reviewed By: #plasma, #vdg, abetts, davidedmundson
Subscribers: abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15785
Summary:
Slideshow wallpapers use the same Blur/Color selector that single image
wallpapers use. However, the Blur config entry was added to the image
xml but not the slideshow xml. The result was that the selection was
never persisted and reverted to the default on restart. This allows the
slideshow blur config to persist.
Test Plan:
Configure the desktop backgrounds.
Select slideshow with one or more images that are smaller than the screen.
Choose fill with solid color. Apply and exit.
Note that the background fill takes on the solid color
Restart
Note that the background fill is still the solid color
Configure desktop background
Choose fill with blur. Apply and exit
Note that the background fill is a blur
Restart
Note that the background fill is still a blur.
Reviewers: #plasma_workspaces, davidedmundson
Reviewed By: #plasma_workspaces, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D13555
They are usually hidden for a reason and shouldn't show up in the slideshow.
BUG: 394882
FIXED-IN: 5.12.6
Differential Revision: https://phabricator.kde.org/D13260
Summary:
With slideshow desktop wallpaper plugin, selecting "Open wallpaper Image" from RMB does nothing. It looks like the `action_open` method called by the RMB menu action is using an old field that no longer exists.
The patch updates the code to use the correct field.
BUG: 394035
Reviewers: #plasma_workspaces, ngraham, broulik
Reviewed By: #plasma_workspaces, ngraham, broulik
Subscribers: broulik, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12777
Summary:
update the wallpaper dialog to the same design as the new KCMS
for consistency
Test Plan:
dialog loads with proper wallpaper selected, and both clicking on one
works and the attached toolbuttons work too
Reviewers: #plasma, #vdg, davidedmundson, broulik
Reviewed By: #plasma, broulik
Subscribers: davidedmundson, broulik, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12148
This broke in the transition to StackView as the blur needs a full-size source. Additionally
* put the item into a Loader to avoid needless shader compilation and other work
* only load the blur for image fill modes where the image does not cover the full size
* don't render background color when blur is enabled as you cannot see it anyway
Differential Revision: https://phabricator.kde.org/D11981
Summary:
The image wallpaper is a mess of 4 different fade functions, some not in
sync, and very complicated swapping images about.
This simplifies the whole thing by using a StackView, we just pop our
setup with a new configuration on and it handles deleting old objects
when the transition ends.
Code is 1/3 the size, whilst doing the same thing and should result in
having fewer items about.
In addition with this patch changing the transition effect in future
would be super trivial.
Test Plan:
Set as both image and wallpaper
Renders stuff as before
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11726
l10n daemon script
Filip Fila
David Redondo
Aleix Pol
David Redondo
Laurent Montel
Nate Graham
David Edmundson
Marco Martin
Kai Uwe Broulik
David Edmundson
Yuri Chornoivan
Oded Arbel
Friedrich W. H. Kossebau