The context property version is slower to access and won't be supported
in Qt6. Let's port away from it and use the singleton version instead.
Here was my full process for making this change:
1. Made the change with `find . -name '*.qml' | xargs perl -pi -e 's/units\./PlasmaCore\.Units\./g'`
2. Verified no more occurrences with `grep -r " units."`
3. Made sure this didn't change any comments in a silly way by inspecting the output of `git diff | grep "+ " | grep "//"`
4. Manually inspected the full git diff to make sure there were no other unintentional or silly changes (there were none)
5. verified that all changed files have the PlasmaCore import with the correct name with `for FILE in `git status | grep modified | cut -d ":" -f 3`; do grep -q "as PlasmaCore" $FILE || echo "$FILE needs the PlasmaCore import"; done`
consider an applet acceptable for the formfactor if at least one
of its formfactors are contained in KDeclarative::runtimePlatform
or if either KDeclarative::runtimePlatform or applet formfactors
are empty.
(before informFactor failed if even one of the applet supported
formfactors was not in runtimePlatform
BUG:433983
After getting the Icons KCM set up using an ActionToolbar for the row of
buttons at the bottom of the KCM, it seemed like a good idea to adapt
that method for more of the KCMs. This is the first of those patches,
and it adapts the Colors, Cursor Theme, Desktop Theme, Global Theme, and
Style KCMs to using an ActionToolbar (and consequently allowing them to
scale their UI more correctly).
ListUnitByNames did not quite work as the author (me) expected. Whilst a
search for "adsfasf" yeilded an empty list a well-formed name like
"asdfasdf.service" would return a result to say that service was not
loaded.
This means our runtime detection of xdg-autostart-generator failed.
By using ListUnitFilesByPatterns we can filter on the status in the
query, meaning this code works again. We also can query the case of it
being available but explicitly disabled.
BUG: 433333
It was broken because its visiblity was not bound to activeFocus
correctly. This would have broken in Qt6 anyway but fixing it now makes
the focus effect work as intended again.
BUG: 433755
FIXED-IN: 5.22.3
This is a workaround for the page being totally broken on when opened
again after the dialog was closed for the first time. Using a new controller
works around that.
BUG:424458
Instead of adding an unprintable character to the UI the history view is
closed and the text field it focused.
To prevent unprintable characters like backspace a regex is used,
just like we already do in the ResultsView Keys.onPressed slot.
BUG: 433723
FIXED-IN: 5.21.2
forward containmentDisplayHints from panel to the systray, adding the
systray specific ones which are
Plasma::Types::ContainmentDrawsPlasmoidHeading and
Plasma::Types::ContainmentForcesSquarePlasmoids
This add fix to avoid session specific environement variable to be
leaked into new session.
Also, it will restore the old systemd session variable upon shutting
down.
It's dest*url* after all. Makes it easier to debug why it's not displaying correctly.
According to Qt `/foo/bar` is a child of `stfp://foo`, which completely throws
off `KFilePlacesModel`...
The restriction on having an amount of files to be processed was to avoid
showing whatever last file had been copied as destination.
However, we already only fall back to using the "destination" label contents
when there is a single file (cf. `NotificationManager::JobPrivate::destUrl()`),
making it safe to assume destUrl is always a predicatble/useful location.
CCBUG: 408778
if we know the conector name of a qscreen, use it to recover the internal
integer screen id.
used by external scripts to do things to the "current" containment
for instance systemsettings invoking the wallpaper configuration
dialog for the same containment for the screen systemsettings currently resides in
Prior to this, when resizing the dialogue to a sufficiently small size
(such as happens on Plasma Mobile on the Pinephone), the row would
overflow, resulting in a distinctly unpleasant look with a cut-off
button. This patch fixes this by using a Kirigami ActionToolBar for
the right-side buttons, allowing them to move into an overflow menu
when there isn't sufficient horizontal space.
The test depends on the applications being installed and the path being
correctly set. To make it more robust the path is set inside of the test
and the files the test used are shipped with it.
Nate Graham
Marco Martin
Fabian Vogt
Nicolas Fella
Dan Leinir Turthra Jensen
David Redondo
David Edmundson
l10n daemon script
Alexander Lohnau
Niccolò Venerandi
Willyanto Willyanto
Weng Xuetian
Kai Uwe Broulik
Aleix Pol