The KWin setting for whether or not to wrap around was not respected, so
wrap was always true even if the user has turned it off. This commit
fixes that.
BUG: 425787
In the past, this was considered to be a way to make KRunner more
discoverable by users.
However today Kickoff exposes all the same runners as KRunner, so its
full functionality is therefore more discoverable in a different way,
so making the KRunner UI itelf more discoverable is not as important.
Furthermore, this was always a questionable way to increase
discoverability in the first place, because the menu item did not expose
the keyboard shortcut, which is the typical way that people show
KRunner. Also, context menus are generally considered shortcuts for
experts; novice users don't tend to use context menus very much. But
experts are the people more likely to already know about KRunner and its
keyboard shortcut, and would never invoke it using the desktop context
menu.
Removing this menu item de-clutters the desktop context menu a bit, and
we do get complaints that the menu is overwhelming because it has too
many things in it. This is a fairly unimportant item that we can remove
without any real consequences.
Finally, Marco didn't like the change to refer to KRunner using the
actual term "KRunner" in the main UI, so this change removes one of the
two places where that happened. :)
We do this sometimes, but not consistenly.
The benefit is twofold.
First it improves the diff when adding new values since no existing line needs to be touched.
Second it prevents clang-format from collapsing the definition into a single line, which is undesired for large enums.
It can apparently happen that virtual desktops is empty at a given point
in time. Potentially due to other bugs on the system.
Calls to desktopIds.at(N) will fail.
BUG: 427106
This came up in today's VDG meeting. A user who right-clicks on the
desktop is highly likely to want to change the wallpaper, but the menu
item that does this is the last item in the menu, not the first. We can
move it up to the top.
The "Open with Dolphin" item is likewise moved up too so that we don't
have two single-item sections in a row.
Summary:
In Plasma, 5.18, this ishn't a user-facing option anymore. It's still visible in the
context meny configuration dialog though, and it's still referenced in some of the
context menu building code.
This patch removes it from those places
BUG: 416578
FIXED-IN: 5.18.0
Test Plan:
Context menu still looks the same on the desktop and panel, both in and out of edit mode
The action no longer shows up in the configuration UI.
Please review carefully as this code is fairly unfamiliar to me.
Reviewers: mart, #plasma
Reviewed By: mart, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26845
Summary:
ContainmentActions had some old windows code was dropped as that's
clearly unused.
logout and leave actions now enable/disable at runtime, so in future can
respond to config changes when that's added to libkworkspace.
DataEngines and the krunner code should have no visible changes
Test Plan:
Left from the desktop and from krunner
Changed the default action in ksmserver's kcm
Confirmed that changes the default leave action changed
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21764
Summary: "Edit Panel..." already enters the edit mode, so there's no need to clutter the context menu with another "Customize Layout..." menu item.
Test Plan: Open the panel context menu.
Reviewers: #plasma, #vdg, mart, ngraham
Reviewed By: #plasma, #vdg, mart, ngraham
Subscribers: mart, #vdg, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25053
Summary: Not needed for normal users with the new edit mode system.
Test Plan: Lock the widgets before compiling this patch. Then compile with it, unlock widgets and see that there is no lock option in the panel context menu.
Reviewers: #plasma, #vdg, ngraham, mart
Reviewed By: #plasma, #vdg, ngraham, mart
Subscribers: broulik, mart, ngraham, #vdg, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24839
Summary:
edit mode menu action
edit mode dbus property for systemsettings
containmentlayoutmanager goes out of edit mode only when the whole
plasma app loses focus, so the panel controlled doesn't make it go out
of it
Test Plan:
iaction shows in context menu, works
property exposed on dbus works
Reviewers: #plasma, #vdg, ngraham, GB_2, davidedmundson
Reviewed By: #plasma, #vdg, ngraham, GB_2, davidedmundson
Subscribers: GB_2, ngraham, davidedmundson, plasma-devel
Tags: #plasma
Maniphest Tasks: T10190, T11094, T10402
Differential Revision: https://phabricator.kde.org/D24264
Yuri Chornoivan
Nate Graham
l10n daemon script
Nicolas Fella
Alexander Lohnau
David Edmundson
Björn Feber
Marco Martin