Summary:
BUG: 345940
Move the "Enable Power Management" checkbox to the top of the window to match other applets (bluetooth, network)
Reviewers: #plasma_workspaces, broulik, mck182, davidedmundson, mart
Reviewed By: #plasma_workspaces, davidedmundson, mart
Subscribers: mart, jensreuterberg, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8607
Summary:
This was tricky bug to track down, needed to add debug statements in
literally every functions.
The flow of events is something like this, At startup:
- We don't have information about actual brightness for few seconds
- In this period, brightness slider have default value of 1
- This triggers the function which sets batterymonitor.screenBrightness
- onScreenBrightnessChanged gets called, which sets the actual
brightness
- onScreenBrightnessChanged have a guard for disableBrightnessUpdate but
since we have it marked as false initially, we proceed to set actual
brightness to 1
- However before we set value of brightness to 1, we do get actual
brightness back from dataengine, and our call overrides it to 1 later.
- On desktop we do get 2nd dataChanged event from somewhere, so
brightness is proper, but on mobile that is not case and results in
brightness staying at 1.
To fix this bug, we set disableBrightnessUpdate true at startup, and
when there is actual brightness change from powerdevil or
powermanagement engine, Logic.js takes care of enabling and disabling
brightness change.
(I quite like the boolean trap there in variable name :P .. will fix in
another change in master)
Test Plan:
Tested on desktop and mobile, verified that
- Brightness keys work
- Brightness slider works
- Scroll to change brightness works
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8462
Summary: BUG: 381174
Test Plan:
Had debug in QtWayland
Clicked on systray
Had parent, menu was in the right position
Reviewers: #plasma, mart, graesslin
Reviewed By: #plasma, mart, graesslin
Subscribers: apol, graesslin, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8338
Summary:
A user can "pin" the calendar so that it won't get closed on focus
change, but only when the clock is clicked again.
This persists across open/close operations, but currently doesn't
persist across Plasma restarts.
This patch loads the saved config value of the last pinned state.
Test Plan:
Opened calendar, set pin, closed it, reopened and it was still pinned
(which is the current state)
killed plasma, restarted plasma, was still pinned (new)
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8252
Summary:
This sets a transient parent on the shown menus, meaning a panel knows
to stay open whilst it has any menu showing.
We also pulse setStatus() to trigger activating an autohidden panel if
activated via a shortcut.
BUG: 384861
Test Plan:
Ran menu
Using both mouse and keyboard shortcuts navigated a menu
and submenus
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7883
This makes the font selector more compact and moves it to the end of the dialog.
Settings like show seconds and date are more important than using a custom font for the clock.
Differential Revision: https://phabricator.kde.org/D7633
This replaces the loop with fixed values by an Instantiator creating bindings on the model.
CCBUG: 372090
Differential Revision: https://phabricator.kde.org/D7603
Summary:
QDBusConnection::serviceOwnerChanged is deprecated, with the intended
replacement being QDBusServiceWatcher. QDBusServiceWatcher only creates
a match rule for the relevant services, resulting in less noise and
wakeups.
(practically this has no impact as the the system tray also connects to
watch every service change, and that runs in the same process)
Test Plan:
Ran appmenu
Had dolphin open showing the menu
Closed dolphin
menu immediately closed
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7611
We have a custom compact representation anyway.
All it does is change the tooltip icon but more importantly break the notification icon in System Tray settings.
BUG: 375093
FIXED-IN: 5.11.0
Differential Revision: https://phabricator.kde.org/D7542
In QtQuick Layouts implicit size (set by IconItem to the SVG's natural size) takes
precedence over width/height. This was fixed in DeviceItem but forgotten here.
BUG: 382541
FIXED-IN: 5.8.8
Summary:
For url with parameter like audiocd:/1.wav?device=/dev/sr0, the filename
displayed in notifications applet is not correct ("sr0") instead of 1.wav.
This commit try to remove the query string before extract the last path
component.
Test Plan: Manually with audiocd-kio
Reviewers: mart, davidedmundson
Reviewed By: davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4879
Summary:
Bug 378032.
With these changes, notifications can be configured to always persist in the notifications applet.
Todo: filter by application, see https://bugs.kde.org/show_bug.cgi?id=378032#c27
Test Plan: Open the notification plasmoid's settings. Check 'Show a history of notifications'. Trigger some notifications. They should show up in the applet.
Reviewers: #plasma, #vdg, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: mart, graesslin, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7271
While I'm usually a huge fan of States, this is done only half-way with States in the compact
representation (NotificationIcon) overwriting the plasmoid's state in addition to there being
a binding on it in main.qml.
It also used a "default" state (note: the default state in QML is empty string) in addition to
assigning default values on items themselves anyway.
This seems to shift evaluation of bindings into an order where we first stop the BusyIndicator
and then become passive, moving the the systray popup, working around the Qt crash we're seeing.
It's a nice clean up in any case imho.
CCBUG: 381105
Differential Revision: https://phabricator.kde.org/D7319
In QtQuick Layouts implicit size, which is taken from the SVG's preferred size, takes
precedence potentially destroying the layout.
Also, it should have been medium to be consistent with the rest.
BUG: 383213
FIXED-IN: 5.8.8
* Make links clickable again
* Don't pass visualParent to context menu as we already give it a position, fixes it being positioned incorrectly
* Open context menu on press already like is done everywhere else
* Give "Copy" the edit-copy icon
* Deselect text after copying again, otherwise it stays selected but the user cannot unselect it.
BUG: 382263
FIXED-IN: 5.10.5
Differential Revision: https://phabricator.kde.org/D7029
Update the list of country names to the current names in iso-codes
(as output by isoquery -c).
The motivation is updating the name of Czechia as a followup to
https://git.reviewboard.kde.org/r/129644/
As suggested by Albert Astals Cid, fixing the name in i10n is not
enough:
country names are hardcoded in many places and they need to be fixed
separately.
REVIEW: 129691
We copy "ctx" pointer by value into our lambda but by the time our timer fires, it might be gone already.
Instead, pass "ctx" as context to QTimer::singleShot so it won't fire when it's gone.
BUG: 382386
FIXED-IN: 5.10.5
Differential Revision: https://phabricator.kde.org/D6951
Aleix Pol
l10n daemon script
Kai Uwe Broulik
Nathaniel Graham
Bhushan Shah
David Edmundson
Alexander Potashev
Pino Toscano
Jonathan Riddell
Weng Xuetian
Julian Wolff
Jiri Bohac