Summary:
--when the user has enabled PLASMA_USE_QT_SCALING
under X11 environment the screen and window geometries
can not be trusted for comparison before window
geometries have been adjusted properly
BUG: 404500
FIXED-IN: 5.15.2
Test Plan: check that global menu still works properly
Reviewers: #plasma, davidedmundson, broulik
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19126
In 12h system locales (eg: en_US), checked=1 is cast as
Qt::PartiallyChecked=1 which defaults to the system locale (12h).
Since it's no longer a tri-state button, the user can't select
Qt::Checked=2 which forces the 24h state.
BUG: 404292
FIXED-IN: 5.15.1
Summary:
Before this patch if you had no active menu and configured your plasmoid
it would be invisible.
After this patch a placeholder is shown in that configuration.
BUG: 403232
Test Plan:
* Window with menu - menu shown, no placeholder (as before)
* Window without menu - state is hidden so nothing is shown (as before)
* Window with menu whilst configuring - menu shown (as before)
* Window without menu whilst configuring - placeholder shown (new)
* Compact represenation remains the same
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18481
Summary: setting an icon via i18n makes no sense
Test Plan: Put in vertical panel, had an icon
Reviewers: #plasma, broulik, ngraham
Reviewed By: #plasma, broulik, ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18480
Summary: This patch improves the up/down display for the Monitor widgets
Test Plan:
Before, no activity: {F6549441}
After, no activity: {F6550787}
Before, some activity: {F6549443}
After, some activity: {F6550788}
All the other ones still look good or are improved: {F6550789}
Reviewers: #plasma, #vdg
Subscribers: abetts, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18255
Adds a new customDateFormat config key which is used when the dateFormat "StringEnum" is set to custom.
Shows a link to the Qt time formatting documentation next to the text field.
Qt doc link and text field are hidden when not set to custom date format.
CCBUG: 340982
Differential Revision: https://phabricator.kde.org/D18019
Summary: This patch aims to add padding to the notification widget and fully remedy the issues that arise once it is applied.
Test Plan:
Before:
{F6533139}
After:
{F6533140}
(More padding, and margins as even as can be)
Reviewers: #vdg, #plasma, ngraham, davidedmundson
Reviewed By: #vdg, #plasma, ngraham, davidedmundson
Subscribers: broulik, Codezela, abetts, filipf, davidedmundson, hein, ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17975
Summary:
This patch fixes two issues:
- the 'state' of the device now propagates correctly, that makes the busy indicator be displayed again, device emblems are also updated correctly
- there is no more delay between the moment when the device is actually mounted and the moment the device notifier says it is. The worst case used to be 5 seconds.
BUG: 354321
BUG: 399986
Reviewers: #plasma, #vdg, broulik, bruns, ngraham, davidedmundson
Reviewed By: #plasma, #vdg, ngraham, davidedmundson
Subscribers: mart, cfeck, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16170
Summary:
When unmounting a device, the device notifier keeps the information
of the device and its icon for a few seconds before it disappears.
But the binding on the label and the icon was making them go blank
before, leaving an emblem without an icon and a 'This device can
now be safely removed' notice without the name of the device
(although it did not always happen, this I am not sure why).
The problem appeared with commit 61b2b173e8
Test Plan:
Unmount a removable device with the device notifier: for a few
seconds, the device name and icon should still be displayed
An example of the problem:
{F6442095}
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, filipf, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17127
Summary: This patch adds the ellipsis (...) to the search field label in Clipboard so as to make it consistent with the labels in Kickoff, Kicker and KRunner.
Test Plan:
Before:
{F6521497}
After:
{F6521498}
Reviewers: ngraham, #plasma, #vdg
Reviewed By: ngraham, #vdg
Subscribers: abetts, filipf, plasma-devel
Tags: #plasma
Maniphest Tasks: T10258
Differential Revision: https://phabricator.kde.org/D17935
Summary:
There's an early return before the memory cleanup that happens at the
end of this function.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17561
Summary:
1. Remove the left margin.
2. Change '&' to "and".
Before:
{F6474493}
After:
{F6476224}
Test Plan: Open System Tray.
Reviewers: #vdg, broulik, #plasma, mart
Reviewed By: #vdg, #plasma, mart
Subscribers: fabianr, abetts, loh.tar, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17556
Summary:
In the specific case of having the device notifier opened
and inserting a device that has been configured to be
automatically mounted, the transition animation could be
interrupted resulting in the opacity being wrong.
Test Plan:
In the setup discribed in the summary, you should never
see something like the attached screenshot where the list
of action opacity is not 1.
{F6460038}
See http://doc.qt.io/qt-5/qml-qtquick-viewtransition.html#handling-interrupted-animations
for more information.
Reviewers: #plasma, #vdg, ngraham, davidedmundson
Reviewed By: #plasma, #vdg, ngraham, davidedmundson
Subscribers: broulik, davidedmundson, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17394
Summary:
BUG: 400663
FIXED-IN: 5.15.0
Test Plan:
Before: {F6455075}
After: {F6459462}
(label alignment being a bit off is unrelated to this patch)
Everything still works.
Reviewers: #plasma, #vdg, mart, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: alexde, mvourlakos, abetts, zzag, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17354
Summary:
use QQC2 and FormLayout for alignment
also, qqc2 combobox doesn't suffer from 390801 anymore
BUG: 390801
Test Plan: tried to set all the options
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17333
Summary: No big visible changes, but simplifies and modernizes the code
Test Plan: used all functionality of the systray config dialog
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17212
Summary:
--as @mart requested we can rename "menuHidden" property
to "visible" in order to follow Qt naming
Test Plan:
--check that global menu applet is functioning the same
way as when using removed menuHidden property
Reviewers: #plasma, mart, davidedmundson
Reviewed By: #plasma, mart
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17107
Summary:
--a new screenGeometry property is added in the
AppMenuModel in order to be used for filtering
windows based on their geometry.
BUG: 384895, 395853
Test Plan:
--validate that when moving a window between different screens the global menu applet is updated accordingly
--checkout that nothing has broke because of this new behavior
Reviewers: #plasma, broulik, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: mart, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16768
Summary:
SystemTray::serviceRegistered is called tons of times; the regexp
construction inside the for-loop is expensive and should be avoided.
Thus construct the regexp once, and re-use the regexp object each time.
Test Plan:
Before:
{F6432674}
After:
{F6432675}
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17025
Summary:
Now if appIcon isn't defined, it will set the property as undefined.
file:///home/apol/devel/kde5/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/NotificationDelegate.qml:114: ReferenceError: appIcon is not defined
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16771
Michail Vourlakos
l10n daemon script
Chris Holland
Tranter Madi
David Edmundson
Nate Graham
Anthony Fieroni
Krešimir Čohar
Thomas Surrel
Shubham Jangra
Laurent Montel
Marco Martin
Kevin Funk
Aleix Pol