Some users reported this button becoming too small after KF5.74 was released, but I could not reproduce it myself. However, this code did look suspicious. Hopefully this fixes the issue.
There were three principal sources of errors and warnings:
1. Un-ported `onFooChanged` statements
2. `config.fontSize` being unconditionally referenced from components
without access to it (it comes from the SDDM config)
3. Accessing units from the context property rather than the singleton
All are fixed now. Tested with:
1. `sddm-greeter --test-mode --theme ~/kde/usr/share/sddm/themes/breeze/`
2. `~/kde/usr/lib64/libexec/kscreenlocker_greet --testing --theme ~/kde/src/plasma-workspace/lookandfeel`
3. `/kde/usr/lib64/libexec/ksmserver-logout-greeter --fakearg`
No regressions found.
BUG: 425349
FIXED-IN: 5.20
This begins the process of porting plasma-workspace to PlasmaComponents3. At
this point, only the relatively easy work is done. Every file not ported
now has been given the reason for still using PC2 in a comment on the import
line so you can see at a glance what the blocker is by running
`grep -r "org.kde.plasma.components 2.0"` in the repo.
Everything is tested and there are no breakages or functional regressions. In
the process, a few unused imports are removed.
Here are the remaining PC3 omissions blocking what's left from getting easily
ported:
- No Highlight
- No ListItem
- No PageStack
- No ContextMenu
- No QueryDialog
- No ModelContextMenu
- TabBar has no left and right tab states
- ToolButton has no built-in method to show a menu when clicked
Summary:
Even when the vendor logo is turned off it can be briefly seen when the login screen changes from the fadeout state back into normal.
Comments in other code say that "OpacityAnimator when starting from 0 is buggy (it shows one frame with opacity 1)" so this patch replaces it with NumberAnimation.
There's also a minor fix included - placing the drop shadow sooner in the hierarchy because it should be drawn underneath an object, not in front of it.
Test Plan:
Reduce the fadeout time to something small and then:
`sddm-greeter --test-mode --theme /usr/share/sddm/themes/breeze`
Reviewers: ngraham, cblack, #plasma, mart
Reviewed By: ngraham, #plasma, mart
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29351
Summary:
Also drop the prefix and use the KDE_INSTALL_FULL.. variant for an
absolute path (similar to logo=${KDE_INSTALL_FULL_DATADIR}...).
Test Plan:
Checked that the path of the background image is the same as
before.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27241
Summary:
We switched to .jpg for Next but SDDM theme's code still points to .png so we got a white screen instead.
Have the code point to .jpg instead.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27018
Summary:
sddm-greeter will have a button for the reveal password button, but due
to sddm-greeter not loading a relevant QPT has no code to force it to
load the breeze icon set.
Without the breeze icon set, the clear button does not show.
There are ways to solve this, but none are trivial or reliable.
I threatened to do a revert in 5.12 (https://phabricator.kde.org/D9040)
but the bug has still not been fixed since.
BUG: 396039
CCBUG: 387418
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26675
This reverts commit 5c8ce892e3.
Due to the looming LTS release date and bugs (415098, 414873, 4145094, 414852) that keep piling up, we are reverting the QQC2 and PC3 port of the SDDM theme.
In b7b25010aa the import line was changed
but nothing else was, causing errors in QML loading which ultimately
prevented SDDM from loading the theme.
BUG: 414252
CCMAIL: i@guoyunhe.me
Summary:
The TableView in digital clock widget time zone configuration is replaced with ListView. Other UI didn't change.
{F7635385}
Reviewers: #plasma, #plasma_workspaces, ngraham
Reviewed By: ngraham
Subscribers: GB_2, ahiemstra, broulik, kmaterka, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24798
Summary: The Breeze SDDM theme now shows a logo that can be configured by distro vendors or curious users or anyone else.
Test Plan:
Test configuration and defaults.
Default logo:
{F7028488}
Example with a distro logo:
{F7023244}
Reviewers: #vdg, #plasma, filipf, ngraham
Reviewed By: #vdg, filipf, ngraham
Subscribers: GB_2, Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22458
Summary: Components that used QQC1 in `sddm-theme/` (excluding the symlinked `components` folder) have been changed to use QQC2.
Test Plan:
Ensure no loss of functionality, style, or bugs from the port of QQC1 to QQC2.
{F7256235}
Reviewers: #plasma, #vdg, davidedmundson, filipf
Reviewed By: #plasma, #vdg, davidedmundson, filipf
Subscribers: ndavis, GB_2, ngraham, filipf, davidedmundson, plasma-devel
Tags: #plasma
Maniphest Tasks: T10958
Differential Revision: https://phabricator.kde.org/D21815
Summary:
Otherwise SDDM has to load all users even if they're not shown.
See https://github.com/sddm/sddm/pull/1017
Test Plan: Using this for several releases downstream to support >1500 users.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: ngraham, davidedmundson, filipf, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24333
Summary:
The session selector's and keyboard layout's menus are now styled to resemble the Breeze theme rather than the default QML style.
BUG: 408702
Test Plan: Ensure the styling looks good regardless of various conditions. (resolution, dpi, distro, amount of sessions, etc.)
Reviewers: #vdg, filipf
Reviewed By: #vdg, filipf
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21794
l10n daemon script
Niccolò Venerandi
Noah Davis
Nate Graham
Daan De Meyer
Filip Fila
Heiko Becker
David Edmundson
Yuri Chornoivan
Luca Beltrame
Guo Yunhe
Carson Black
Fabian Vogt