Our dear friend Notification plasmoid has slipped the surly bonds of Earth
to touch the face of eternal preservation in Git history. It leaves a huge
emptiness in the hearts of all of us who loved it, many who here its friends.
Originally concveived in 2011 as a "New QML based notifications plasmoid
for mobile", it quickly outgrew its creator's vision and became a vital
component of the Plasma Desktop. When the new kid on the block arrived in
the form of Plasma 5, it showed its willpower to survive this stark transition
and served us for another half a decade. It taught us to seize every
opportunity to increase productivity and improve user experience,
yet it became evident that it reached its limits and so on April Fools' Day 2019
its heart beat for the last time.
Farewell!
- Improve compact reprsentation
- Keep popup open during interaction (context menu, drag)
- Improve "ago" label (e.g. show "Last Sunday")
- Improve group visuals (still pretty much WIP)
- Hide popups when interacted (opened file, triggered file action, etc)
Closing when having invoked an action isn't implemented yet but is probably neccessary
- Make autohide job popup setting work
- Set critical AlwaysOnTop (requires KWin patch)
- Improve error handling in ThumbnailStrip
Show file icon if thumbnail generation failed instead of a blank space
- Add heuristic for popup placement and make custom setting work
- Add deviceName and displayApplicationName (for KDE Connect)
So it can show from which device and which app this notification originally came from
- Improved service discovery (and defaultComponent handling)
Quite a few notifications, e.g. DrKonqi crashes are in plasma_workspace.notifyrc
When we get an event like this, show the original app instead
- Make blacklist for popup and history work
- Add "lastRead" property for "unread" handling vs "expired" (latter likely to be dropped)
- Add sortMode so history is strictly sorted by date (it's grouped after all)
- Begin work on do not disturb UI in plasmoid
- Support replacing notifications properly
- Now that we have nice models we can finally do the replacing in the way the spec
asks for "atomically (ie with no flicker or other visual cues)"
- Catch some more cases in notification details text (trash:/ stuff)
- Prefer notifyrc name over desktop entry name in case a service within another app sends
an event (e.g. Discover notifier in Plasma, KNotification automatically sends desktop-entry
of the parent app)
- Implement x-kde-urls thumbnailer with drag and drop and fancy blur
Originally intended to be able to show multiple files but in practise only used for
single pictures, so the code is significantly simplified for that usecase
- Add "Open" feature for finished job notification, offers a context menu as well with
all the KFileItemActions (component from the Thumbnailer)
- Copy description labels to clipboard
Once menu opens the update is paused so the text you copy is what you see
- Fixup sanitizer so we can properly collapse notifications without body text
... and more
Summary:
Move the {nav Open With} items into the top group of the context menu for notifications with images or files that you can open and see in the filesystem. This makes it consistent with Dolphin, which now has all the Open in/with items grouped together at the top of the menu.
I didn't move the {nav Open With} items all the way to the top because my sense is that {nav Open containing folder} is the more common action and deserves to be the top item. Also, putting it below the {nav Open With} actions would result in an extra ugly separator.
Test Plan: {F5848641}
Reviewers: broulik
Reviewed By: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12882
BUG: 385097
This revision further improves the quality of images in notifications
that was addressed in revision D9993. When I first looked into this, I
tried setting ScaleType on the PreviewJob but it had no effect. I found
that the preview images were being scaled to the small vertical size
that was requested, and this resulted in my first revision. I should
have tried setting ScaleType in addition.
Notification with unpatched libnotificationshelperplugin.so
{F5677396}
Notification with patch applied
{F5677397}
Test Plan:
Take screenshot with Spectacle with unpatched
libnotificationshelperplugin.so installed and observe the blurry
preview image in the notification.
Install the patched libnotificationshelperplugin.so and restart
plasmashell.
Take another screenshot with Spectacle and observe the much improved
quality of the preview image in the notification.
Reviewers: #plasma_workspaces, #plasma, broulik, ngraham
Subscribers: #plasma, #plasma_workspaces, plasma-devel, broulik, ngraham
Tags: #plasma, #spectacle
Differential Revision: https://phabricator.kde.org/D10146
Summary:
BUG: 385097
FIXED-IN: 5.12.0
This patch to plasma-workspace is to improve the quality of images in notifications as reported in [[ https://bugs.kde.org/show_bug.cgi?id=385097 | Bug 385097 ]].
It is still not perfect because KIO::PreviewJob is used to create the thumbnail, and it only produces two sizes, 128px and 256px, so it is likely that a small image will be scaled up, blurring it somewhat.
I took two screenshots of the same Dolphin window. Here is the before, without the patch:
{F5665511}
And the after, with the patch:
{F5665513}
Better, but still not perfect.
Test Plan: Take screenshots with Spectacle with and without the patched libnotificationshelperplugin library and observe the image quality in the notification. plasmashell must be restarted when the library file is changed for it to take effect.
Reviewers: #plasma_workspaces, #plasma, broulik
Reviewed By: #plasma_workspaces, #plasma, broulik
Subscribers: broulik, ngraham, plasma-devel, #plasma_workspaces, #plasma
Tags: #spectacle, #plasma
Differential Revision: https://phabricator.kde.org/D9993
Makes it more obvious there's a menu with more options.
You can still right-click the thumbnail area as before.
Differential Revision: https://phabricator.kde.org/D9255
Since it represents a file, right clicking it should provide similar options found in a file manager.
This allows to open the application with an application other than the default, e.g. if you
want to edit the screenshot right away. It also offers a "Copy to clipboard" action as well as
service actions, such as send as email.
Differential Revision: https://phabricator.kde.org/D4838
When a notification contains URLs, they will be shown as a large preview (in case of one
thumbnail) or multiple in a strip (similar to what Klipper does).
The previews can be clicked to open the file and can be dragged anywhere (e.g. to a
webbrowser or chat window).
Differential Revision: https://phabricator.kde.org/D3539
Kai Uwe Broulik
Yuri Chornoivan
Nathaniel Graham
Laurent Montel
Randy Kron
David Edmundson