Summary:
Acts like requestVirtualDesktops only with a QStringList
make runningActivities invokable
Test Plan: See subsequent plasma-desktop review
Reviewers: hein, #plasma
Reviewed By: hein, #plasma
Subscribers: hein, mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1814
Summary: clang-check as well cppcheck complains about it
Test Plan: builds
Reviewers: hein, #plasma
Reviewed By: hein, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1962
Summary:
This is needed for subsequent feature work which needs to be able
to turn this off.
This review also includes a number of bug fixes to the model:
- Fix an off-by-one when explicitly breaking a group apart.
- Fix rowCount() returning the value for a top-level item with
the same row when called for a group member.
- Fix updating/invalidating persistent indices endRemoveRows()
doesn't know how to handle.
- Update data for former parent item ahead of child-reparenting
insert when breaking a group apart.
None of these fixes actually matter for the applet view, but
they obviously improve correctness, and will matter for later
work.
Reviewers: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1838
Summary:
QAbstractProxyModel forwards hasChildren() to the source model, which
will return a wrong value for our tree-restructuring model. Current
views/proxies don't call hasChildren(), which is how this oversight
happened, but implementing it improves model hygiene - could blow up
in the future otherwise.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1799
David Edmundson
Bhushan Shah
Eike Hein