According to Kai:
"object literal is more performant
same with [] vs new Array()
also you should avoid putting the keys in ""
{"foo": bar} is also less performant than {foo: bar} :)"
And so I did to his bidding.
Reviewed-by: Kai Uwe Broulik
With the previous patch, now everything has "notification N" source
name, so there's needed another way to detect that it's a job's
notification.
Reviewed-by: Kai Uwe Broulik
Leading and trailing spaces, tabs, and line-breaks are now highlighted in the
theme's highlight color (blue in Breeze) and replaced by printable characters
REVIEW: 123821
BUG: 159267
FIXED-IN: 5.4.0
if new plasmoids are installed that are systray enabled and
enabled by default, automatically add them, unless they were
disabled explicitly. This solves a problem distributions seem
to add while updating to new plasma releases.
obtain this by keeping both a list of explicitly enabled stuff
and all the already known stuff
REVIEW:123789
BUG:345872
As notifications support <img/> tags, it can happen that a big image is
sent and that is then painted even outside of the popup's frame. So we
need to clip it.
BUG: 346419
FIXED-IN: 5.3.1
Adds a simple QSortFilterProxyModel on top of TimeZonesModel and
reimplements filterAcceptsRow using QStringMatcher (supposedly faster
according to qtdocs).
REVIEW: 123740
BUG: 346681
FIXED-IN: 5.3.1
This was added for KDeclarative 5.9 which we already depend on, so let's
just use it. Battery applet already does.
Backports parts of f5a177b6fa
BUG: 347032
FIXED-IN: 5.3.1
applet loading in systemtray doesn't depend from sycoca anymore
it uses Plasma::PluginLoader, so it works with both sycoca-based
libplasma and with the new branch without
It can happen that a notification is placed in the show queue and then
it's closed (eg. programatically) before it was even shown. In this case
the notification must be cleared from the show queue otherwise it will
get displayed and hidden but the popup is never freed for reuse,
resulting in notificaions starting at higher position from the panel.
BUG: 342605
It can happen that a notification is placed in the show queue and then
it's closed (eg. programatically) before it was even shown. In this case
the notification must be cleared from the show queue otherwise it will
get displayed and hidden but the popup is never freed for reuse,
resulting in notificaions starting at higher position from the panel.
BUG: 342605
DataSources source is a QStringList property which means changes within cannot be tracked
causing all the job delegates to be destroyed and re-created when sourcesChanged is emitted.
This is pretty wasteful and also causes the delegates to lose their state (eg. details expanded)
REVIEW: 123502
BUG: 346673
FIXED-IN: 5.3.1
There's a bug with MouseArea which causes the containsMouse to not be
updated when the Item moves away from below the mouse while the mouse is
not being moved. This should help at least with those cases where the
notification gets stuck.
Reviewed-by: Kai Uwe Broulik
CCBUG: 345973