When all players are closed, media player applet on the
desktop still shows a track from the last player, and
player control buttons are still clickable but have no effect.
Add a new signal named `playerListEmptied()`. When the proxy list is empty,
the signal is emitted and `m_multiplexer` is scheduled to be deleted, so
the media player applet on the desktop can indicate the right status of
no player opened.
BUG: 446098
FIXED-IN: 5.24
QDBusServiceWatcher gained wildcard support in Qt 5.14. We can now port
to use it over the deprecated signal on QDBusConnectionInterface.
This not only ports away from deprecated code, but should reduce
plasmashell wakeups for unreltaed enties.
Properties like Identity, SupportedUriSchemes, SupportedMimeTypes are mandatory.
Ignore the player if it's clearly violating the spec.
CHANGELOG: Players not compliant to MPRIS specification will no longer work with Media Controller applet.
Differential Revision: https://phabricator.kde.org/D22596
Summary: This is needed so Plasma::DataEngine can construct the metadata
Test Plan: Debug. Lots of debug.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4554
Summary:
Also set a consistent naming structure and to be only Info+ by default.
This may mean you need to update your logging rules if you want debug
output.
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: graesslin, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1956
Current usage of QDBusServiceWatcher is not a intended feature and will
be removed in Qt 5.6 (see https://bugreports.qt.io/browse/QTBUG-51683 ).
Use the old fashioned QDBusConnectionInterface::serviceOwnerChanged to
implement the same thing.
REVIEW: 127285
If there was a vlc engine it got skipped due to a bug in VLC. This
bug seems to be fixed as of VLC 2.1.5 which contains the following
item in the changelog:
"dbus: Upgrade to an mpris2 compliant interface"
Given that the workaround breaks with the fixed VLC (no media control
at all), it's better to drop it and brake VLC installations which
haven't updated for more than half a year.
REVIEW: 122589
There's a more correct fix to that (see the comment in the diff) but
given the situation, it's just much easier to go with this way.
Reviewed-by: David Edmundson
BUG: 332584
This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:
http://community.kde.org/Frameworks/GitOldHistory
If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.
Branched from the monolithic repo kde-workspace, frameworks branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0
Fushan Wen
Alexander Lohnau
David Edmundson
Kai Uwe Broulik
Weng Xuetian
Montel Laurent
Martin Gräßlin
Martin Klapetek
Aleix Pol