Summary:
When the TabBox is in the noModifierGrab mode we should activate an
item when being clicked/touched.
Test Plan:
Tested on X11 and Wayland. On Wayland both touch and pointer
work, on X11 only pointer works - requires further investigation.
Reviewers: #kwin, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5415
Summary:
use a state machine to define in a cleaner way
the layout of the lock screen when the keyboard is
open on closed. animate between the state changes with
a slide animation
Depends on D4870
Test Plan:
tested opening the keyboard with different screen locker sizes
to see the text field and the button always stay visible
Reviewers: graesslin, #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4893
Summary:
Just like in the lock screen this adds support for virtual keyboard.
Note: this requires adjustments in sddm, the greeter must specify the
env variable QT_IM_MODULE=qtvirtualkeyboard to have the virtual keyboard
shown.
If the virtual keyboard is not available, the button to enable it will
not be shown.
Test Plan: run in qmlscene
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5061
Summary:
* use backgroundcontrast effect, improves readability a lot
* non-current actions a bit more translucent
* background is actually black if the color scheme is dark, looks washed out otherwise
* add an OK button, that was complained a lot
* short fade animation at the beginning
Test Plan: see screenshot
Reviewers: #plasma, sebas, broulik
Reviewed By: #plasma, broulik
Subscribers: graesslin, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5036
Summary:
If the Loader fails to load we do not need to show the virtual keyboard
button. It won't be functional.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5062
Summary:
This change integrates QtVirtualKeyboard into the Lock screen UI.
A new button is added to the bottom row to toggle the appearance of the
virtual keyboard. The actual keyboard is integrated through a Loader so
that not having qtvirtualkeyboard plugin installed results in a graceful
error instead of a failing lock screen.
When the virtual keyboard is shown the remaining UI shifts upwards. This
is done through adding the stack view into a ColumnLayout. Unfortunately
this can result in an overlap with the clock. This needs some general
improvement as on e.g. my system the clock is never really visible.
To have the virtual keyboard working in the lock screen one also needs
another change to kscreenlocker_greet.
Test Plan: See screenshots
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4870
Summary:
If we show a virtual keyboard, better make sure that useful password
hints are set.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4876
Summary:
The clock so far was manually positioned in a hard coded way which could
result in the clock not being visible or only partly visible. This is the
case for example on my high dpi system with Wayland. See F2672846 for an
example.
This changes the layouting of the clock to use a ColumnLayout, with
spacer elements to ensure that the clock stays visible. It is possible
that the position of the clock now does no longer fully reflects the
ideas of the VDG.
Test Plan: Looks better on my system ;-)
Reviewers: #plasma, #vdg
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4877
Otherwise it fails to lock the screen and since it waits for the lock screen to show up before switching, it never does it.
BUG: 375941
FIXED-IN: 5.9.1
Differential Revision: https://phabricator.kde.org/D4470
Summary: as discussion about branding, as the main logo is changed, add a mention that Plasma is a KDE project in a fine print on the bottom of the screen
Test Plan:
displays correctly in the splash as the attached screenshot
if this is a good change or not i don't have much opinion
Reviewers: #plasma
Subscribers: andreaska, hein, broulik, graesslin, mck182, subdiff, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4050
NativeRendering often utterly breaks at large font sizes. We had this in the previous lock screen design.
Differential Revision: https://phabricator.kde.org/D3823
Brings it in line with the Leave overlay.
Reviewers: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3033
There was code added (approved by me) to make sure we always cast
battery icon percent to an integer if it's undefined. It had the
unintended side effect that a battery life of 0 would also be 'cast' to
100.
When this is undefined we don't show the icon anyway, so
it doesn't really matter what value we fall back to.
The sddm breeze theme battery icon is trying to access the battery
percent. In a batteryless system it produces the syslog message:
Nov 14 22:28:23 samd sddm-greeter[3210]: file:///usr/share/sddm/themes/breeze/components/Battery.qml:39:18: Unable to assign [undefined] to int
Based on https://gist.github.com/Zren/4e5709d842965227088f6e1d3fd42016
Debian-Bug: https://bugs.debian.org/844194
Allows to show the password on click, similar to how it's done in most other
password fields throughout the workspace.
Differential Revision: https://phabricator.kde.org/D3616
I've quite often seen people wondering how to change the keyboard layout on the lock screen.
By adding a keyboard icon it makes the button somewhat more visible but it's
still quite hidden in the corner of the screen.
Differential Revision: https://phabricator.kde.org/D3549
Only show the button if there's a session to switch to and/or the user is allowed to launch a new session.
Differential Revision: https://phabricator.kde.org/D3231
Ask the model instead. The entry might not be there if the user is not allowed to start a new session
Differential Revision: https://phabricator.kde.org/D3232
Several small improvements to design and usability of the lockscreen:
- Keyboard focus changes to switchSessionPage (typing password and issuing
unlock requests in this view not any longer possible) and other way around
- Keyboard commands for switchSessionPage: Left/Right, Return, Enter, Escape
- Password field is cleaned on changing back to the main screen or session
- Quick fade in of input elements on invocation of lockscreen
- Animating slide out of clock and input elements when switching user, which
is in line with the other sliding animation of the Stackview. It also helps
to easen the transition, when the users have different themes or languages
Reviewers: davidedmundson
Tags: #plasma #vdg
Differential Revision: https://phabricator.kde.org/D3055
Instead of showing the "New Session" item on the main lockscreen and
the subpage switchSessionPage, we only show it on the second one.
The lockscreen's functionality is in the first place to lock the
screen and therefore it shouldn't largely advertise the possibility
of creating a new session.
That's why we move the creation of a new session completely to the
subpage switchSessionPage, where it fits better to the other
possibility of switching to an already existing one.
Reviewers: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3034
and make it use the full width before wrapping
Test Plan:
Tested on the same system that reported the bug; works for all
combinations of font, font size and DPI tested.
BUG: 370281
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, jensreuterberg, pritambaral, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2984
Summary: Alternate fix for D2956 [Lock Screen] When pressing Return just trigger button
Test Plan:
Locked screen hit enter
Locked screen selected new session hit enter
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2976
Summary:
Renamed userPrompt to userPromptComponent and add an id
(userListComponent) to the initialItem Login component.
Disable user list when there are too many users in the system
In sddm 0.14, there's a userModel.disableAvatarsThreshold property
that defines how many users are "too many" in the system so loading of
avatars should be disabled. This commit honors that property, so if
there are more than disableAvatarsThreshold users, then the user list
is disabled and a prompt is shown to ask for a username and password.
If the property is not available (for example, because sddm 0.13 is
being used) then it works as usual.
This threshold is specially useful for large enterprises with NFS
automounted home directories. In such environments, using sddm while
avatars are enabled results in all remote home directories being
mounted in the system before one user is able to log in. This has been
reported to take hours in cases with thousands of users.
By default the threshold has a value of 7, but it can be modified
in sddm.conf, under the Theme section, in the
UsersThresholdToDisableAvatars variable.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2874
This makes it consistent with what we do with the Plasma sidebars (Widget Explorer, Activity Manager).
Also enables LayoutMirroring.
Differential Revision: https://phabricator.kde.org/D2761
This cleans up and simplifies the tabbox code, mainly by replacing manual anchoring by QtQuick Layouts.
Spacing and fonts are also streamlined.
Differential Revision: https://phabricator.kde.org/D2741
Set avatarPath to the user avatar and iconSource to the fallback icon.
With the different margins it became apparent that it was rendering the avatar through IconItem.
Differential Revision: https://phabricator.kde.org/D2612
Summary:
This (optionally) appends an entry to the SessionsModel to append a "New
Session" option. The lock screen / user switcher are then modified to
use it.
Messages.sh is modified so all components are covered by the same pot.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2594
SessionManagementScreen already has this very same label and the notificationMessage populates it.
The one in the Lock Screen was unused.
Differential Revision: https://phabricator.kde.org/D2572
Marco Martin
Kai Uwe Broulik
Martin Gräßlin
Anthony Fieroni
Roman Gilg
David Edmundson
Maximiliano Curia
Yuri Chornoivan
Pritam Baral
Antonio Larrosa