Summary:
Right now windy conditions are not handled at all. I live in an area with very frequent
windy conditions especially during certain times of year so this is annoying because I
see the purple question mark icon a lot, which in the past has made me stop using the
weather widget.
This patch implements handling for windy + clear and cloudy conditions for NOAA. I
don't know how to implement this for Wettercom.
Depends on D24537
Test Plan:
Before: {F7568603}
After: {F7568554}
Reviewers: kossebau, #plasma, spstarr
Reviewed By: #plasma, spstarr
Subscribers: spstarr, plasma-devel, #vdg
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24483
Summary: Include duplication, no newline at the end of file and missing argument to the i18n() call
Test Plan: Should work fine but needs a review for i18n() calls
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24580
Summary:
Those information mostly clutter the plasmoid UI and are not very useful in the energy plasmoid
The battery plasmoid represents the state of the battery, for battery information we have the Energy information KCM in kinfocenter that will display this after D23152 .
Test Plan:
Before:
{F7257309}
After:
{F7257310}
Reviewers: ngraham, #plasma, broulik, #vdg, filipf
Reviewed By: ngraham, #vdg, filipf
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23237
Properties like Identity, SupportedUriSchemes, SupportedMimeTypes are mandatory.
Ignore the player if it's clearly violating the spec.
CHANGELOG: Players not compliant to MPRIS specification will no longer work with Media Controller applet.
Differential Revision: https://phabricator.kde.org/D22596
Summary:
It wasn't ported before due to the slot being overloaded.
Code became cleaner if we renamed one of the private slots.
Test Plan: Compiles
Reviewers: #plasma, sitter
Reviewed By: sitter
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22841
Summary: It seems it's unused and also is the only source code in all of the KDE repos that uses kjsembed
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22691
Summary:
Ejecting e.g. a USB stick removes it from the bus (bus power is removed),
but the last notification should be kept, otherwise a message like
"The device can be savely removed" immediately disappears.
Unfortunately it is almost impossible to tell when a device has been
physically removed (only indirectly, when a new device is plugged into
the same port), so allow some small leakage - in case the same device is
later replugged, no leakage happens.
Test Plan:
Card reader:
1.insert medium, mount, unmount
-> message "Device can be savely removed" is shown in device notifier
for 5 seconds
2. eject medium, reinsert
-> device appears without message and with default label
Reviewers: #plasma, broulik, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22312
Summary:
it was the only remaining user of that dialog helper.
the connection between the two was fairly meh. the engine would invoke the
kded module over dbus, the module would then process the request, find that
only one desktop entry is specified, resulting in one action being found
and then running that action on behalf of the engine. this is overly
complicated for no additional gain. the engine is the sole user of this
functionality AND it already had knowledge of the service system, so
soliduiserver in this case doesn't actually add anything. it's just a more
involved call chain.
the useful code of soliduiserver is now in the hotplug dataengine directly
and the soliduiserver no longer supports the actions dialog. hotplug is now
the sole authority for hotplugging.
soliduiserver:
- include cleanup
- all classes no longer in use have been removed
- kdelibs4support is no longer a link target
- new link targets i18n + widgetsaddons (previously pulled in by
kdelibs4support)
hotplug:
- hotplugjob now directly executes service actions using classes imported
from soliduiserver
- no longer links qtdbus
- new translation domain plasma_engine_hotplug (for i18n call in imported
service classes)
- new link against ki18n for that reason
Test Plan: running an action works same as before, internally it no longer relies on dbus/kded
Reviewers: broulik
Reviewed By: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21761
Nate Graham
Yuri Chornoivan
l10n daemon script
Laurent Montel
David Edmundson
Shawn Starr
Méven Car
David Faure
Christophe Giboudeaux
Kai Uwe Broulik
Albert Astals Cid
Stefan Brüns
Harald Sitter